Re: [PATCH v2] eal: Pointer alignment check improvements

2022-09-30 Thread David Marchand
On Fri, Sep 23, 2022 at 10:25 AM Bruce Richardson wrote: > On Thu, Sep 22, 2022 at 01:44:13PM +0200, Morten Brørup wrote: > > Checking a const pointer for alignment would emit a warning about the > > const qualifier being discarded. > > > > No need to calculate the aligned pointer; just check the

Re: [PATCH v2] eal: Pointer alignment check improvements

2022-09-23 Thread Bruce Richardson
On Thu, Sep 22, 2022 at 01:44:13PM +0200, Morten Brørup wrote: > Checking a const pointer for alignment would emit a warning about the > const qualifier being discarded. > > No need to calculate the aligned pointer; just check the last bits of the > pointer. > > v2: > - Remove compiler attribute

RE: [PATCH v2] eal: Pointer alignment check improvements

2022-09-22 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 22 September 2022 13.59 > > On Thu, Sep 22, 2022 at 12:52:42PM +0100, Bruce Richardson wrote: > > On Thu, Sep 22, 2022 at 01:44:13PM +0200, Morten Brørup wrote: > > > Checking a const pointer for alignment would emit a

Re: [PATCH v2] eal: Pointer alignment check improvements

2022-09-22 Thread Bruce Richardson
On Thu, Sep 22, 2022 at 12:52:42PM +0100, Bruce Richardson wrote: > On Thu, Sep 22, 2022 at 01:44:13PM +0200, Morten Brørup wrote: > > Checking a const pointer for alignment would emit a warning about the > > const qualifier being discarded. > > > > No need to calculate the aligned pointer; just c

Re: [PATCH v2] eal: Pointer alignment check improvements

2022-09-22 Thread Bruce Richardson
On Thu, Sep 22, 2022 at 01:44:13PM +0200, Morten Brørup wrote: > Checking a const pointer for alignment would emit a warning about the > const qualifier being discarded. > > No need to calculate the aligned pointer; just check the last bits of the > pointer. > > v2: > - Remove compiler attribute

[PATCH v2] eal: Pointer alignment check improvements

2022-09-22 Thread Morten Brørup
Checking a const pointer for alignment would emit a warning about the const qualifier being discarded. No need to calculate the aligned pointer; just check the last bits of the pointer. v2: - Remove compiler attribute ((const)) from function; it was a coding style issue. Signed-off-by: Morten