Re: [PATCH v2] dts: fix verify argument in set forward mode

2024-11-06 Thread Patrick Robb
Thanks Dean. I reworded the commit message to "Condition set_forward_mode verify code on the verify argument, which was originally omitted" because I think even with a tiny bugfix, we want to explain for the commit history what the commit is doing, instead of a vague "this is a bugfix" type message

Re: [PATCH v2] dts: fix verify argument in set forward mode

2024-11-04 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Thu, Oct 10, 2024 at 2:42 PM Dean Marx wrote: > > Fix optional verify argument in set_forward_mode > method in testpmd shell class. > > Bugzilla ID: 1410 > Fixes: fc0f7dc47ee3 ("dts: add testpmd shell params") > > Signed-off-by: Dean Marx > --- > dts/framework/r

Re: [PATCH v2] dts: fix verify argument in set forward mode

2024-10-10 Thread Patrick Robb
Reviewed-by: Patrick Robb

[PATCH v2] dts: fix verify argument in set forward mode

2024-10-10 Thread Dean Marx
Fix optional verify argument in set_forward_mode method in testpmd shell class. Bugzilla ID: 1410 Fixes: fc0f7dc47ee3 ("dts: add testpmd shell params") Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) d