Re: [PATCH v2] doc: add new driver guidelines

2024-09-08 Thread fengchengwen
Hi Ferruh, Thanks for the explanation. In the next new version: Acked-by: Chengwen Feng Thanks On 2024/9/6 16:27, Ferruh Yigit wrote: > On 9/6/2024 9:05 AM, fengchengwen wrote: >> On 2024/8/15 3:08, Stephen Hemminger wrote: >>> From: Nandini Persad >>> >>> This document was created to assist

Re: [PATCH v2] doc: add new driver guidelines

2024-09-06 Thread Ferruh Yigit
On 9/6/2024 9:05 AM, fengchengwen wrote: > On 2024/8/15 3:08, Stephen Hemminger wrote: >> From: Nandini Persad >> >> This document was created to assist contributors in creating DPDK drivers >> and provides suggestions and guidelines on how to upstream effectively. >> >> Co-authored-by: Ferruh Yig

Re: [PATCH v2] doc: add new driver guidelines

2024-09-06 Thread fengchengwen
On 2024/8/15 3:08, Stephen Hemminger wrote: > From: Nandini Persad > > This document was created to assist contributors in creating DPDK drivers > and provides suggestions and guidelines on how to upstream effectively. > > Co-authored-by: Ferruh Yigit > Co-authored-by: Thomas Monjalon > Signed

RE: [EXTERNAL] [PATCH v2] doc: add new driver guidelines

2024-09-05 Thread Akhil Goyal
> >> +Additional Suggestions > >> +-- > >> + > > .ini file shall be updated for each of the new feature added in the same > > patch as > code. > > > > This is mentioned above as: > "Update relevant documentation and .ini file with each patch." Ok. I missed that.

Re: [EXTERNAL] [PATCH v2] doc: add new driver guidelines

2024-09-05 Thread Ferruh Yigit
On 9/5/2024 10:16 AM, Akhil Goyal wrote: > Few crypto specific suggestions. > >> >> v2 - review feedback >>- add co-author and reviewed-by >> >> doc/guides/contributing/index.rst | 1 + >> doc/guides/contributing/new_driver.rst | 202 + >> 2 files changed, 203 i

RE: [EXTERNAL] [PATCH v2] doc: add new driver guidelines

2024-09-05 Thread Akhil Goyal
Few crypto specific suggestions. > > v2 - review feedback >- add co-author and reviewed-by > > doc/guides/contributing/index.rst | 1 + > doc/guides/contributing/new_driver.rst | 202 + > 2 files changed, 203 insertions(+) > create mode 100644 doc/guides/cont

[PATCH v2] doc: add new driver guidelines

2024-08-14 Thread Stephen Hemminger
From: Nandini Persad This document was created to assist contributors in creating DPDK drivers and provides suggestions and guidelines on how to upstream effectively. Co-authored-by: Ferruh Yigit Co-authored-by: Thomas Monjalon Signed-off-by: Nandini Persad Reviewed-by: Stephen Hemminger ---

Re: [PATCH v2] doc: add new driver guidelines

2024-08-14 Thread David Marchand
On Wed, Aug 14, 2024 at 4:36 AM Stephen Hemminger wrote: > > From: Nandini Persad > > This document was created to assist contributors in creating DPDK drivers > and provides suggestions and guidelines on how to upstream effectively. > > Signed-off-by: Nandini Persad > --- > v2 - text should be

[PATCH v2] doc: add new driver guidelines

2024-08-13 Thread Stephen Hemminger
From: Nandini Persad This document was created to assist contributors in creating DPDK drivers and provides suggestions and guidelines on how to upstream effectively. Signed-off-by: Nandini Persad --- v2 - text should be i file not patch doc/guides/contributing/index.rst | 1 + doc/gui