RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-27 Thread Konstantin Ananyev
> Subject: RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine > > > > >>>>>>> TSO breaks when MSS spans more than 8 data fragments. Those > > > >>>>>>> packets will be dropped by Tx preparation API, but it will &

RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-26 Thread Morten Brørup
> > >>> TSO breaks when MSS spans more than 8 data fragments. Those > > >>> packets will be dropped by Tx preparation API, but it will > > >>> cause > > >>> MDD event if txonly forwarding engine does not call the Tx > > > preparation > > >>> API before transmitting packets. > >

RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-26 Thread Konstantin Ananyev
> >>> TSO breaks when MSS spans more than 8 data fragments. Those > >>> packets will be dropped by Tx preparation API, but it will > >>> cause > >>> MDD event if txonly forwarding engine does not call the Tx > > preparation > >>> API before transmitting packets. > >>> > >>

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-23 Thread Andrew Rybchenko
On 2/22/24 21:28, Konstantin Ananyev wrote: +CC: Ethernet API maintainers +CC: Jerin (commented on another branch of this thread) From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] Sent: Sunday, 11 February 2024 16.04 TSO breaks when MSS spans more than 8 data fragments. Those

RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-22 Thread Konstantin Ananyev
> +CC: Ethernet API maintainers > +CC: Jerin (commented on another branch of this thread) > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Sunday, 11 February 2024 16.04 > > > > > > > > TSO breaks when MSS spans more than 8 data fragments. Those > > > > > > packets

RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-13 Thread Morten Brørup
+CC: Ethernet API maintainers +CC: Jerin (commented on another branch of this thread) > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Sunday, 11 February 2024 16.04 > > > > > > TSO breaks when MSS spans more than 8 data fragments. Those > > > > > packets will be dropped

RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-11 Thread Konstantin Ananyev
> > > > TSO breaks when MSS spans more than 8 data fragments. Those > > > > packets will be dropped by Tx preparation API, but it will cause > > > > MDD event if txonly forwarding engine does not call the Tx > > preparation > > > > API before transmitting packets. > > > > > > > > > > txonly is us

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-09 Thread Ferruh Yigit
On 2/8/2024 12:09 PM, Jerin Jacob wrote: > On Thu, Feb 8, 2024 at 6:15 AM Ferruh Yigit wrote: >> >> On 1/11/2024 5:25 AM, Kaiwen Deng wrote: >>> Txonly forwarding engine does not call the Tx preparation API >>> before transmitting packets. This may cause some problems. >>> >>> TSO breaks when MSS

RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-08 Thread Konstantin Ananyev
> > > >> On 1/11/2024 5:25 AM, Kaiwen Deng wrote: > >>> Txonly forwarding engine does not call the Tx preparation API > >>> before transmitting packets. This may cause some problems. > >>> > >>> TSO breaks when MSS spans more than 8 data fragments. Those > >>> packets will be dropped by Tx prepara

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-08 Thread Jerin Jacob
On Thu, Feb 8, 2024 at 6:15 AM Ferruh Yigit wrote: > > On 1/11/2024 5:25 AM, Kaiwen Deng wrote: > > Txonly forwarding engine does not call the Tx preparation API > > before transmitting packets. This may cause some problems. > > > > TSO breaks when MSS spans more than 8 data fragments. Those > > p

RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-08 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Thursday, 8 February 2024 11.50 > > > On 1/11/2024 5:25 AM, Kaiwen Deng wrote: > > > Txonly forwarding engine does not call the Tx preparation API > > > before transmitting packets. This may cause some problems. > > > > > >

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-08 Thread Ferruh Yigit
On 2/8/2024 10:50 AM, Konstantin Ananyev wrote: > > >> On 1/11/2024 5:25 AM, Kaiwen Deng wrote: >>> Txonly forwarding engine does not call the Tx preparation API >>> before transmitting packets. This may cause some problems. >>> >>> TSO breaks when MSS spans more than 8 data fragments. Those >>>

RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-08 Thread Konstantin Ananyev
> On 1/11/2024 5:25 AM, Kaiwen Deng wrote: > > Txonly forwarding engine does not call the Tx preparation API > > before transmitting packets. This may cause some problems. > > > > TSO breaks when MSS spans more than 8 data fragments. Those > > packets will be dropped by Tx preparation API, but it

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-07 Thread Ferruh Yigit
On 1/11/2024 5:25 AM, Kaiwen Deng wrote: > Txonly forwarding engine does not call the Tx preparation API > before transmitting packets. This may cause some problems. > > TSO breaks when MSS spans more than 8 data fragments. Those > packets will be dropped by Tx preparation API, but it will cause >

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-01-12 Thread David Marchand
On Thu, Jan 11, 2024 at 7:06 AM Kaiwen Deng wrote: > > Txonly forwarding engine does not call the Tx preparation API > before transmitting packets. This may cause some problems. > > TSO breaks when MSS spans more than 8 data fragments. Those > packets will be dropped by Tx preparation API, but it

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-01-11 Thread Stephen Hemminger
On Thu, 11 Jan 2024 13:25:55 +0800 Kaiwen Deng wrote: > Txonly forwarding engine does not call the Tx preparation API > before transmitting packets. This may cause some problems. > > TSO breaks when MSS spans more than 8 data fragments. Those > packets will be dropped by Tx preparation API, but

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-01-10 Thread lihuisong (C)
lgtm, Acked-by: Huisong Li 在 2024/1/11 13:25, Kaiwen Deng 写道: Txonly forwarding engine does not call the Tx preparation API before transmitting packets. This may cause some problems. TSO breaks when MSS spans more than 8 data fragments. Those packets will be dropped by Tx preparation API, but

[PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-01-10 Thread Kaiwen Deng
Txonly forwarding engine does not call the Tx preparation API before transmitting packets. This may cause some problems. TSO breaks when MSS spans more than 8 data fragments. Those packets will be dropped by Tx preparation API, but it will cause MDD event if txonly forwarding engine does not call