Re: [PATCH v1 1/1] usertools/devbind: update coding style

2024-12-03 Thread Stephen Hemminger
On Mon, 2 Dec 2024 15:09:34 + Anatoly Burakov wrote: > +# For kernels < 3.15 when binding devices to a generic driver (i.e. one > that doesn't have a PCI > +# ID table) using new_id, some devices that are not bound to any other > driver could be bound > +# even if no one has as

Re: [PATCH v1 1/1] usertools/devbind: update coding style

2024-12-03 Thread Burakov, Anatoly
On 12/2/2024 6:01 PM, Stephen Hemminger wrote: On Mon, 2 Dec 2024 15:09:34 + Anatoly Burakov wrote: +# For kernels < 3.15 when binding devices to a generic driver (i.e. one that doesn't have a PCI +# ID table) using new_id, some devices that are not bound to any other driver cou

[PATCH v1 1/1] usertools/devbind: update coding style

2024-12-02 Thread Anatoly Burakov
Devbind is one of the oldest tools in DPDK, and is written in a way that uses a lot of string matching, no type safety, lots of global variables, and has a few inconsistencies in the way it handles data (such as differences between lspci calls and parsing in different circumstances). This patch is