Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread David Marchand
On Fri, Nov 29, 2024 at 10:52 AM Anatoly Burakov wrote: > > On some systems (particularly ones with NUMA disabled in BIOS), even > though NUMA nodes may be present in sysfs, the lspci command will not > have NUMANode keys in them, which will cause an exception. Fix to check > if NUMANode keys are

[PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread Anatoly Burakov
On some systems (particularly ones with NUMA disabled in BIOS), even though NUMA nodes may be present in sysfs, the lspci command will not have NUMANode keys in them, which will cause an exception. Fix to check if NUMANode keys are available in lspci output before enabling NUMA node output. Fixes:

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread Burakov, Anatoly
On 11/29/2024 10:12 AM, Burakov, Anatoly wrote: On 11/28/2024 6:20 PM, Stephen Hemminger wrote: On Thu, 28 Nov 2024 16:08:55 + Anatoly Burakov wrote: +    # occasionally, system may report NUMA support but lspci will not, so we +    # want to go through all devices and see if any of them

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread Burakov, Anatoly
On 11/28/2024 6:20 PM, Stephen Hemminger wrote: On Thu, 28 Nov 2024 16:08:55 + Anatoly Burakov wrote: +# occasionally, system may report NUMA support but lspci will not, so we +# want to go through all devices and see if any of them do not have NUMANode +# property - this will

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread Robin Jarry
Anatoly Burakov, Nov 28, 2024 at 17:08: On some systems, even though NUMA nodes may be present in sysfs, the lspci command will not have NUMANode keys in them, which will cause an exception. Fix to check if NUMANode keys are available in lspci output before enabling NUMA node output. Fixes: a7d6

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-28 Thread Stephen Hemminger
On Thu, 28 Nov 2024 16:08:55 + Anatoly Burakov wrote: > +# occasionally, system may report NUMA support but lspci will not, so we > +# want to go through all devices and see if any of them do not have > NUMANode > +# property - this will mean it is not safe to try to access it >

[PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-28 Thread Anatoly Burakov
On some systems, even though NUMA nodes may be present in sysfs, the lspci command will not have NUMANode keys in them, which will cause an exception. Fix to check if NUMANode keys are available in lspci output before enabling NUMA node output. Fixes: a7d69cef8f20 ("usertools/devbind: print device