RE: [PATCH dpdk v2 16/16] ipv6: add function to check ipv6 version

2024-10-11 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Thursday, 10 October 2024 22.01 > > Hi Morten, > > Morten Brørup, Oct 06, 2024 at 11:02: > > Personally, I would prefer following the convention of rte_ether > functions to return boolean (as int)... > > > > static inline int > rte_is_ signed

Re: [PATCH dpdk v2 16/16] ipv6: add function to check ipv6 version

2024-10-10 Thread Robin Jarry
Hi Morten, Morten Brørup, Oct 06, 2024 at 11:02: Personally, I would prefer following the convention of rte_ether functions to return boolean (as int)... static inline int rte_is__ether_addr(const struct rte_ether_addr *ea) Sorry, I haven't followed your recommendation in v3, but I have a

RE: [PATCH dpdk v2 16/16] ipv6: add function to check ipv6 version

2024-10-10 Thread Konstantin Ananyev
> This is a slow path version to verify the version field in IPv6 headers. > > Signed-off-by: Robin Jarry > --- > > Notes: > v2: new patch > > app/test/test_net_ipv6.c | 16 > lib/net/rte_ip6.h| 17 + > 2 files changed, 33 insertions(+) > > diff

RE: [PATCH dpdk v2 16/16] ipv6: add function to check ipv6 version

2024-10-06 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Tuesday, 1 October 2024 10.17 > > This is a slow path version to verify the version field in IPv6 > headers. It doesn't look slow to me. No need to mention slow path here. > > Signed-off-by: Robin Jarry > --- > > Notes: > v2: new patc

[PATCH dpdk v2 16/16] ipv6: add function to check ipv6 version

2024-10-01 Thread Robin Jarry
This is a slow path version to verify the version field in IPv6 headers. Signed-off-by: Robin Jarry --- Notes: v2: new patch app/test/test_net_ipv6.c | 16 lib/net/rte_ip6.h| 17 + 2 files changed, 33 insertions(+) diff --git a/app/test/test_net_ip