RE: [EXT] [PATCH 3/8] trace: fix leak with regexp

2022-09-23 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Friday, September 23, 2022 12:05 PM > To: Sunil Kumar Kori > Cc: dev@dpdk.org; sta...@dpdk.org; Jerin Jacob Kollanukkaran > > Subject: Re: [EXT] [PATCH 3/8] trace: fix leak with regexp > > On Thu, Sep 22,

Re: [EXT] [PATCH 3/8] trace: fix leak with regexp

2022-09-22 Thread David Marchand
On Thu, Sep 22, 2022 at 1:00 PM Sunil Kumar Kori wrote: > > @@ -210,15 +210,18 @@ rte_trace_regexp(const char *regex, bool enable) > > return -EINVAL; > > > > STAILQ_FOREACH(tp, &tp_list, next) { > > - if (regexec(&r, tp->name, 0, NULL, 0) == 0) { > > -

RE: [EXT] [PATCH 3/8] trace: fix leak with regexp

2022-09-22 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Wednesday, September 21, 2022 5:34 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Jerin Jacob Kollanukkaran ; Sunil > Kumar Kori > Subject: [EXT] [PATCH 3/8] trace: fix leak with regex

[PATCH 3/8] trace: fix leak with regexp

2022-09-21 Thread David Marchand
The precompiled buffer initialised in regcomp must be freed before leaving rte_trace_regexp. Fixes: 84c4fae4628f ("trace: implement operation APIs") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/eal/common/eal_common_trace.c | 19 +++ 1 file changed, 11 insertions(+)