Re: [PATCH 3/6] dts: add testpmd shell params

2024-04-10 Thread Juraj Linkeš
On Wed, Apr 10, 2024 at 12:49 PM Luca Vizzarro wrote: > > On 09/04/2024 17:37, Juraj Linkeš wrote: > > As Jeremy pointed out, going forward, this is likely to become bloated > > and moving it to params.py (for example) may be better. > > > > There's a lot of testpmd args here. I commented on the i

Re: [PATCH 3/6] dts: add testpmd shell params

2024-04-10 Thread Luca Vizzarro
On 09/04/2024 17:37, Juraj Linkeš wrote: As Jeremy pointed out, going forward, this is likely to become bloated and moving it to params.py (for example) may be better. There's a lot of testpmd args here. I commented on the implementation of some of them. I didn't verify that the actual values ma

Re: [PATCH 3/6] dts: add testpmd shell params

2024-04-09 Thread Juraj Linkeš
As Jeremy pointed out, going forward, this is likely to become bloated and moving it to params.py (for example) may be better. There's a lot of testpmd args here. I commented on the implementation of some of them. I didn't verify that the actual values match the docs or, god forbid, tested all of

Re: [PATCH 3/6] dts: add testpmd shell params

2024-03-28 Thread Jeremy Spewock
We talked about this in DTS meeting, looking at this some more, we already use default parameters for Eal and structure those, so we already have sort of tied ourselves into a situation of if those ever change (unlikely) we would need to change as well, so maybe this could be something we use, I'd

[PATCH 3/6] dts: add testpmd shell params

2024-03-26 Thread Luca Vizzarro
Implement all the testpmd shell parameters into a data structure. Signed-off-by: Luca Vizzarro Reviewed-by: Jack Bond-Preston Reviewed-by: Honnappa Nagarahalli --- dts/framework/remote_session/testpmd_shell.py | 633 +- 1 file changed, 615 insertions(+), 18 deletions(-) diff -