Re: [PATCH 3/4] argparse: fix argument flags operate as uint32 type

2024-03-07 Thread fengchengwen
Hi David, On 2024/3/7 1:34, David Marchand wrote: > On Tue, Feb 20, 2024 at 2:16 PM Chengwen Feng wrote: >> >> The struct rte_argparse_arg's flags was 64bit type, uint64_t should be >> used instead of uint32_t where the operation happened. > > Something is strange. > An enum in C is represented

Re: [PATCH 3/4] argparse: fix argument flags operate as uint32 type

2024-03-06 Thread David Marchand
On Tue, Feb 20, 2024 at 2:16 PM Chengwen Feng wrote: > > The struct rte_argparse_arg's flags was 64bit type, uint64_t should be > used instead of uint32_t where the operation happened. Something is strange. An enum in C is represented as an int. Plus, this enum type is not used anywhere: lib/arg

[PATCH 3/4] argparse: fix argument flags operate as uint32 type

2024-02-20 Thread Chengwen Feng
The struct rte_argparse_arg's flags was 64bit type, uint64_t should be used instead of uint32_t where the operation happened. Also, the flags' bit16 was also unused, so don't test bit16 in testcase test_argparse_invalid_arg_flags. Fixes: 6c5c6571601c ("argparse: verify argument config") Fixes: 31