Re: [PATCH 2/6] dts: use Params for interactive shells

2024-05-28 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote: > > Make it so that interactive shells accept an implementation of `Params` > for app arguments. Convert EalParameters to use `Params` instead. > > String command line parameters can sti

Re: [PATCH 2/6] dts: use Params for interactive shells

2024-04-10 Thread Juraj Linkeš
On Wed, Apr 10, 2024 at 11:34 AM Luca Vizzarro wrote: > > On 09/04/2024 15:56, Juraj Linkeš wrote: > > On Thu, Mar 28, 2024 at 5:48 PM Jeremy Spewock wrote: > >> > >> I'm not sure if allowing None should be the solution for these shells > >> as opposed to just supplying an empty parameter object.

Re: [PATCH 2/6] dts: use Params for interactive shells

2024-04-10 Thread Luca Vizzarro
On 09/04/2024 15:56, Juraj Linkeš wrote: On Thu, Mar 28, 2024 at 5:48 PM Jeremy Spewock wrote: I'm not sure if allowing None should be the solution for these shells as opposed to just supplying an empty parameter object. Maybe something that could be done is the factory method in sut_node allo

Re: [PATCH 2/6] dts: use Params for interactive shells

2024-04-09 Thread Juraj Linkeš
On Thu, Mar 28, 2024 at 5:48 PM Jeremy Spewock wrote: > > On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote: > > > > Make it so that interactive shells accept an implementation of `Params` > > for app arguments. Convert EalParameters to use `Params` instead. > > > > String command line paramete

Re: [PATCH 2/6] dts: use Params for interactive shells

2024-03-28 Thread Jeremy Spewock
On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote: > > Make it so that interactive shells accept an implementation of `Params` > for app arguments. Convert EalParameters to use `Params` instead. > > String command line parameters can still be supplied by using the > `StrParams` implementation. >

[PATCH 2/6] dts: use Params for interactive shells

2024-03-26 Thread Luca Vizzarro
Make it so that interactive shells accept an implementation of `Params` for app arguments. Convert EalParameters to use `Params` instead. String command line parameters can still be supplied by using the `StrParams` implementation. Signed-off-by: Luca Vizzarro Reviewed-by: Jack Bond-Preston Rev