Re: [PATCH 2/3] net/ionic: remove duplicate barriers

2024-02-20 Thread Boyer, Andrew
d mailto:n...@arm.com>> Subject: RE: [PATCH 2/3] net/ionic: remove duplicate barriers Hi Andrew, I think that this barrier may have been added to ensure any writes to q- hw_index and q->head_idx complete before ionic_q_flush computes val. Dependency chains can also prevent reordering if

RE: [PATCH 2/3] net/ionic: remove duplicate barriers

2024-02-19 Thread Wathsala Wathawana Vithanage
> -Original Message- > From: Wathsala Wathawana Vithanage > Sent: Monday, February 19, 2024 4:17 PM > To: Andrew Boyer ; dev@dpdk.org > Cc: Neel Patel ; nd ; Honnappa > Nagarahalli ; nd > Subject: RE: [PATCH 2/3] net/ionic: remove duplicate barriers > > H

RE: [PATCH 2/3] net/ionic: remove duplicate barriers

2024-02-19 Thread Wathsala Wathawana Vithanage
Hi Andrew, I think that this barrier may have been added to ensure any writes to q->hw_index and q->head_idx complete before ionic_q_flush computes val. Dependency chains can also prevent reordering if that's the case this barrier is not required. However, I have the following concern. > diff --

[PATCH 2/3] net/ionic: remove duplicate barriers

2024-02-16 Thread Andrew Boyer
These barriers are duplicated by the barriers inside rte_write64(). Remove them to improve performance. Signed-off-by: Neel Patel Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_main.c| 1 - drivers/net/ionic/ionic_rxtx_sg.c | 1 - drivers/net/ionic/ionic_rxtx_simple.c | 1 -