Re: [PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Stephen Hemminger
On Fri, 10 Feb 2023 20:25:41 +0300 Levend Sayar wrote: > Accessing a stack variable is faster. > So copying to given stats pointer will be done at once. > But of course, given stats pointer can also be used. I doubt there is an observable difference. Access to a stack variable is offset from re

Re: [PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Levend Sayar
Accessing a stack variable is faster. So copying to given stats pointer will be done at once. But of course, given stats pointer can also be used. > On 10 Feb 2023, at 19:34, Stephen Hemminger > wrote: > > On Fri, 10 Feb 2023 16:06:06 +0300 > Levend Sayar wrote: > >> +gve_stats_get(struct rt

Re: [PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Stephen Hemminger
On Fri, 10 Feb 2023 16:06:06 +0300 Levend Sayar wrote: > +gve_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > +{ > + uint16_t i; > + struct rte_eth_stats tmp; > + > + memset(&tmp, 0, sizeof(tmp)) Why do you need tmp? The stats pointer passed in is already available

[PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Levend Sayar
Google Virtual NIC PMD is enriched with statistics info. Signed-off-by: Levend Sayar --- drivers/net/gve/gve_ethdev.c | 147 ++- drivers/net/gve/gve_ethdev.h | 11 +++ drivers/net/gve/gve_rx.c | 18 - drivers/net/gve/gve_tx.c | 6 ++ 4 files change