On Thu, Apr 18, 2024 at 2:31 AM Juraj Linkeš wrote:
>
>
> Ok this makes sense now. Let's definitely drop the last prompt, there
> aren't any upsides (that I can see) and this sort of downside may
> occur elsewhere.
+1
On Wed, Apr 17, 2024 at 4:17 PM Luca Vizzarro wrote:
>
> On 17/04/2024 14:06, Juraj Linkeš wrote:
> > Actually, filtering out the last prompt is fine. I got this mixed up
> > with processing the last prompt. We must process the last prompt, but
> > we don't need to print it (and there's not much r
On 17/04/2024 14:06, Juraj Linkeš wrote:
Actually, filtering out the last prompt is fine. I got this mixed up
with processing the last prompt. We must process the last prompt, but
we don't need to print it (and there's not much reason to do so).
Yeah, my confusion was about displaying the last
On Tue, Apr 16, 2024 at 2:12 PM Luca Vizzarro wrote:
>
> Thank you for your review Juraj!
>
> On 16/04/2024 09:40, Juraj Linkeš wrote:
>
> >> When sending a command using an instance of InteractiveShell the output
> >> is meant to filter out the leading shell prompt. The filtering logic is
> >> pr
Thank you for your review Juraj!
On 16/04/2024 09:40, Juraj Linkeš wrote:
When sending a command using an instance of InteractiveShell the output
is meant to filter out the leading shell prompt. The filtering logic is
present but the line is appended anyways.
I don't think that's what's happ
On Fri, Apr 12, 2024 at 1:11 PM Luca Vizzarro wrote:
>
> When sending a command using an instance of InteractiveShell the output
> is meant to filter out the leading shell prompt. The filtering logic is
> present but the line is appended anyways.
>
I don't think that's what's happening here. The
When sending a command using an instance of InteractiveShell the output
is meant to filter out the leading shell prompt. The filtering logic is
present but the line is appended anyways.
Bugzilla ID: 1411
Fixes: 88489c0501af ("dts: add smoke tests")
Signed-off-by: Luca Vizzarro
Reviewed-by: Paul
7 matches
Mail list logo
