Re: [PATCH 1/3] ethdev: fix missing cast for C++ compatibility

2022-02-16 Thread Bruce Richardson
On Wed, Feb 16, 2022 at 10:32:43AM +, Ferruh Yigit wrote: > On 2/15/2022 5:30 PM, Bruce Richardson wrote: > > C++ does not allow implicit conversion to/from void*, so we need an > > explicit cast to allow the driver sdk header to be included from C++ > > code. > > > > I remember patches remov

Re: [PATCH 1/3] ethdev: fix missing cast for C++ compatibility

2022-02-16 Thread Ferruh Yigit
On 2/15/2022 5:30 PM, Bruce Richardson wrote: C++ does not allow implicit conversion to/from void*, so we need an explicit cast to allow the driver sdk header to be included from C++ code. I remember patches removing explicit "void *" cast, in the past, to document, is the rule as following:

[PATCH 1/3] ethdev: fix missing cast for C++ compatibility

2022-02-15 Thread Bruce Richardson
C++ does not allow implicit conversion to/from void*, so we need an explicit cast to allow the driver sdk header to be included from C++ code. Signed-off-by: Bruce Richardson --- lib/ethdev/ethdev_pci.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/ethdev/ethdev_pc