Re: [PATCH 1/1] common/sfc_efx/base: remove unreachable code

2024-12-21 Thread Ariel Otilibili-Anieli
On Saturday, December 21, 2024 18:42 CET, Andrew Rybchenko wrote: > NACK > > it is the base driver and corresponding code is unreachable with current > build options only. Hello Andrew, Thanks for having looked into this. It looks indeed like a false positive: ``` $ awk 'NR>67 && NR<88 {prin

Re: [PATCH 1/1] common/sfc_efx/base: remove unreachable code

2024-12-21 Thread Andrew Rybchenko
NACK it is the base driver and corresponding code is unreachable with current build options only. On 12/21/24 16:27, Ariel Otilibili wrote: The default switch case ends with a goto; meaning these instructions are never reached. Coverity issue: 121742 Fixes: 19b64c6ac3 ("net/sfc/base: import li

[PATCH 1/1] common/sfc_efx/base: remove unreachable code

2024-12-21 Thread Ariel Otilibili
The default switch case ends with a goto; meaning these instructions are never reached. Coverity issue: 121742 Fixes: 19b64c6ac3 ("net/sfc/base: import libefx base") Signed-off-by: Ariel Otilibili -- Cc: sta...@dpdk.org Cc: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_mon.c | 3 --- 1 f