Re: [PATCH 03/14] bus/pci: find PCI capability

2023-08-03 Thread David Marchand
On Thu, Aug 3, 2023 at 11:53 AM Bruce Richardson wrote: > > On Thu, Aug 03, 2023 at 10:49:54AM +0100, Bruce Richardson wrote: > > On Thu, Aug 03, 2023 at 09:50:26AM +0200, David Marchand wrote: > > > Introduce two helpers so that drivers stop reinventing the wheel. > > > Use it in existing drivers

Re: [PATCH 03/14] bus/pci: find PCI capability

2023-08-03 Thread Bruce Richardson
On Thu, Aug 03, 2023 at 10:49:54AM +0100, Bruce Richardson wrote: > On Thu, Aug 03, 2023 at 09:50:26AM +0200, David Marchand wrote: > > Introduce two helpers so that drivers stop reinventing the wheel. > > Use it in existing drivers. > > > > Can you give a little more context on the new helpers a

Re: [PATCH 03/14] bus/pci: find PCI capability

2023-08-03 Thread Bruce Richardson
On Thu, Aug 03, 2023 at 09:50:26AM +0200, David Marchand wrote: > Introduce two helpers so that drivers stop reinventing the wheel. > Use it in existing drivers. > Can you give a little more context on the new helpers and the changes in the patch? A lot of the changes are not that self-explanator

[PATCH 03/14] bus/pci: find PCI capability

2023-08-03 Thread David Marchand
Introduce two helpers so that drivers stop reinventing the wheel. Use it in existing drivers. Note: - base/ drivers code is left untouched, only some wrappers in cxgbe are touched, - bnx2x maintained a per device cache of capabilities, this code has been reworked to only cache the capabilities