Re: [PATCH] vdpa/sfc: fix null pointer dereference

2022-02-10 Thread Maxime Coquelin
On 1/29/22 18:30, Weiguo Li wrote: When sva is null, sfc_vdpa_info(sva, ...) will cause a null dereference. Use SFC_VDPA_GENERIC_LOG() to avoid that. See macros sfc_vdpa_info and SFC_VDPA_GENERIC_LOG defined in drivers/vdpa/sfc/sfc_vdpa_log.h for detail. Fixes: 5e7596ba7cb3 ("vdpa/sfc: introd

Re: [PATCH] vdpa/sfc: fix null pointer dereference

2022-02-10 Thread Maxime Coquelin
On 1/29/22 18:30, Weiguo Li wrote: When sva is null, sfc_vdpa_info(sva, ...) will cause a null dereference. Use SFC_VDPA_GENERIC_LOG() to avoid that. See macros sfc_vdpa_info and SFC_VDPA_GENERIC_LOG defined in drivers/vdpa/sfc/sfc_vdpa_log.h for detail. Fixes: 5e7596ba7cb3 ("vdpa/sfc: introd

Re: [PATCH] vdpa/sfc: fix null pointer dereference

2022-02-10 Thread Maxime Coquelin
Hi, On 2/4/22 12:56, Weiguo Li wrote: The macro sfc_vdpa_info(sva, ...) will invoke sva->logtype_main, It'll trigger a NULL dereference when sva is NULL. This patch fix it. BTW this patch is not superseded by another one: [v2] vdpa/sfc: fix null dereference (http://dpdk.org/patch/106720)

RE:[PATCH] vdpa/sfc: fix null pointer dereference

2022-02-04 Thread Weiguo Li
The macro sfc_vdpa_info(sva, ...) will invoke sva->logtype_main, It'll trigger a NULL dereference when sva is NULL. This patch fix it. BTW this patch is not superseded by another one: [v2] vdpa/sfc: fix null dereference (http://dpdk.org/patch/106720) They looks alike in title, but deal with d

[PATCH] vdpa/sfc: fix null pointer dereference

2022-01-29 Thread Weiguo Li
When sva is null, sfc_vdpa_info(sva, ...) will cause a null dereference. Use SFC_VDPA_GENERIC_LOG() to avoid that. See macros sfc_vdpa_info and SFC_VDPA_GENERIC_LOG defined in drivers/vdpa/sfc/sfc_vdpa_log.h for detail. Fixes: 5e7596ba7cb3 ("vdpa/sfc: introduce Xilinx vDPA driver") Signed-off-by: