Re: [PATCH] net/txgbe: fix a bit with boolean operator

2022-03-03 Thread Stephen Hemminger
On Thu, 3 Mar 2022 21:31:00 +0800 Weiguo Li wrote: > On March 2, 2022, 5:23 p.m Ferruh Yigit wrote: > > On 3/2/2022 8:02 AM, Jiawen Wu wrote: > > > On March 1, 2022 2:09 PM, Weiguo Li wrote: > > >> Since boolean value is in 0 and 1, it's strange to combines a boolean > > > value with > >

Re: [PATCH] net/txgbe: fix a bit with boolean operator

2022-03-03 Thread Ferruh Yigit
On 3/3/2022 1:31 PM, Weiguo Li wrote: On March 2, 2022, 5:23 p.m Ferruh Yigit wrote: On 3/2/2022 8:02 AM, Jiawen Wu wrote: On March 1, 2022 2:09 PM, Weiguo Li wrote: Since boolean value is in 0 and 1, it's strange to combines a boolean value with a bit operator. Thus it's highly possible a

Re: [PATCH] net/txgbe: fix a bit with boolean operator

2022-03-03 Thread Weiguo Li
On March 2, 2022, 5:23 p.m Ferruh Yigit wrote: > On 3/2/2022 8:02 AM, Jiawen Wu wrote: > > On March 1, 2022 2:09 PM, Weiguo Li wrote: > >> Since boolean value is in 0 and 1, it's strange to combines a boolean > > value with > >> a bit operator. > >> > >> Thus it's highly possible a typo error with

Re: [PATCH] net/txgbe: fix a bit with boolean operator

2022-03-02 Thread Ferruh Yigit
On 3/2/2022 8:02 AM, Jiawen Wu wrote: On March 1, 2022 2:09 PM, Weiguo Li wrote: Since boolean value is in 0 and 1, it's strange to combines a boolean value with a bit operator. Thus it's highly possible a typo error with "if (A & !B)", and more probably to use "if (A & ~B)" instead. Fixes

Re: [PATCH] net/txgbe: fix a bit with boolean operator

2022-03-02 Thread Ferruh Yigit
On 3/2/2022 8:02 AM, Jiawen Wu wrote: On March 1, 2022 2:09 PM, Weiguo Li wrote: Since boolean value is in 0 and 1, it's strange to combines a boolean value with a bit operator. Thus it's highly possible a typo error with "if (A & !B)", and more probably to use "if (A & ~B)" instead. Fixes

RE: [PATCH] net/txgbe: fix a bit with boolean operator

2022-03-02 Thread Jiawen Wu
On March 1, 2022 2:09 PM, Weiguo Li wrote: > Since boolean value is in 0 and 1, it's strange to combines a boolean value with > a bit operator. > > Thus it's highly possible a typo error with "if (A & !B)", and more probably to > use "if (A & ~B)" instead. > > Fixes: c1d4e9d37abdc6 ("net/txgbe: a

[PATCH] net/txgbe: fix a bit with boolean operator

2022-02-28 Thread Weiguo Li
Since boolean value is in 0 and 1, it's strange to combines a boolean value with a bit operator. Thus it's highly possible a typo error with "if (A & !B)", and more probably to use "if (A & ~B)" instead. Fixes: c1d4e9d37abdc6 ("net/txgbe: add queue stats mapping") Signed-off-by: Weiguo Li ---