Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-24 Thread Ferruh Yigit
On 1/21/2022 4:29 AM, Kumara Parameshwaran wrote: From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-24 Thread Ferruh Yigit
On 1/20/2022 11:12 AM, Kumara Parameshwaran wrote: From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the pro

[PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-20 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-20 Thread Stephen Hemminger
On Thu, 20 Jan 2022 16:42:15 +0530 Kumara Parameshwaran wrote: > +/** > +* Get rte_eth_dev from device name. The device name should be specified > +* as below: > +* - PCIe address (Domain:Bus:Device.Function), for example- :2:00.0 > +* - SoC device name, for example- fsl-gmac0 > +* - vdev dpd

[PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-20 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

[PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-20 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

[PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-20 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread Stephen Hemminger
On Wed, 19 Jan 2022 10:03:49 +0530 kumaraparameshwaran rathinavel wrote: > > > Why is this necessary? dev->data is already in memory shared between > > primary > > > and secondary process. > > > > > The question is about the two assignments that happen in secondary proces > > > that chan

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread kumaraparameshwaran rathinavel
:46 > > To: Kumara Parameshwaran > > Cc: keith.wi...@intel.com ; dev@dpdk.org < > dev@dpdk.org>; Kumara Parameshwaran > > Subject: Re: [PATCH] net/tap: Bug fix to populate fds in secondary > process > > > > On Fri, 26 Nov 2021 09:45:15 +0530 > > Kuma

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread Stephen Hemminger
during hotplug of the tap device. > > Thanks, > Param. > > From: Stephen Hemminger > Sent: 18 January 2022 03:46 > To: Kumara Parameshwaran > Cc: keith.wi...@intel.com ; dev@dpdk.org > ; Kumara Parameshwaran > Subject: Re: [PATCH] net

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread Thomas Monjalon
18/01/2022 13:12, Ferruh Yigit: > On 1/18/2022 11:21 AM, kumaraparameshwaran rathinavel wrote: > > Comment moved down. > > Please don't top post, it makes very hard to follow the discussion and bad > for archives to visit discussion later. > > > > > On Tue, Jan 18, 2022 at 3:17 PM Ferruh Yigit

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread Ferruh Yigit
On 1/18/2022 10:52 AM, kumaraparameshwaran rathinavel wrote: Comment moved down, please avoid top posting. On Tue, Jan 18, 2022 at 2:40 PM Ferruh Yigit mailto:ferruh.yi...@intel.com>> wrote: On 1/18/2022 4:39 AM, Kumara Parameshwaran wrote: >>   static int >>   tap_dev_start(str

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread Ferruh Yigit
On 1/18/2022 11:21 AM, kumaraparameshwaran rathinavel wrote: Comment moved down. Please don't top post, it makes very hard to follow the discussion and bad for archives to visit discussion later. On Tue, Jan 18, 2022 at 3:17 PM Ferruh Yigit mailto:ferruh.yi...@intel.com>> wrote: On 1/17/

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread kumaraparameshwaran rathinavel
Just wanted to bring it to your attention, In Mellanox driver there is a requirement to exchange fds between primary and secondary and similar usage is seen, the primary sends the port_id and the secondary refers to the rte_eth_devices in the driver, The functions are - mlx5_mp_secondar

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread kumaraparameshwaran rathinavel
Yes, even I was confused if it had been the tap_intr_handle_set function. In general the tap_dev_start should not be invoked by the secondary and only primary should do it. I referred it to a couple of PMDs and that was the case. Please let me know if I am missing something in my understanding.

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread Ferruh Yigit
On 1/17/2022 6:33 PM, Thomas Monjalon wrote: 17/01/2022 19:28, Ferruh Yigit: + ret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id); + if (ret) { + TAP_LOG(ERR, "Failed to get port id for %s", + request_param->port_name); +

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread Ferruh Yigit
On 1/18/2022 4:39 AM, Kumara Parameshwaran wrote:    static int    tap_dev_start(struct rte_eth_dev *dev)    {     int err, i; + tap_mp_req_on_rxtx(dev); + As for as I understand your logic is primary sends the message to the secondar(y|ies), so what happens first secondary is star

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread Kumara Parameshwaran
inger Sent: 18 January 2022 03:46 To: Kumara Parameshwaran Cc: keith.wi...@intel.com ; dev@dpdk.org ; Kumara Parameshwaran Subject: Re: [PATCH] net/tap: Bug fix to populate fds in secondary process On Fri, 26 Nov 2021 09:45:15 +0530 Kumara Parameshwaran wrote: > + ret = rte_eth_dev_ge

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-18 Thread Kumara Parameshwaran
From: Ferruh Yigit Sent: 17 January 2022 23:52 To: Kumara Parameshwaran ; keith.wi...@intel.com Cc: dev@dpdk.org ; Kumara Parameshwaran ; Raslan Darawsheh Subject: Re: [PATCH] net/tap: Bug fix to populate fds in secondary process On 11/26/2021 4:15 AM

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Stephen Hemminger
On Fri, 26 Nov 2021 09:45:15 +0530 Kumara Parameshwaran wrote: > + ret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id); > + if (ret) { > + TAP_LOG(ERR, "Failed to get port id for %s", > + request_param->port_name); > + return

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Thomas Monjalon
17/01/2022 19:28, Ferruh Yigit: > > + ret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id); > > + if (ret) { > > + TAP_LOG(ERR, "Failed to get port id for %s", > > + request_param->port_name); > > + return -1; > > + } > > + dev = &rte_

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Ferruh Yigit
On 11/26/2021 4:15 AM, Kumara Parameshwaran wrote: From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the pro

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Ferruh Yigit
On 11/26/2021 4:15 AM, Kumara Parameshwaran wrote: From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the pro

[PATCH] net/tap: Bug fix to populate fds in secondary process

2021-11-25 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

[PATCH] net/tap: Bug fix to populate fds in secondary process

2021-11-25 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

[PATCH] net/tap: Bug fix to populate fds in secondary process

2021-11-25 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

[PATCH] net/tap: Bug fix to populate fds in secondary process

2021-11-25 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are are not populated in the primary during the probe they are populated during the queue_setup, add