RE: [PATCH] net/pcap: support MTU set

2023-07-11 Thread Ido Goshen
uh Yigit > Sent: Monday, 10 July 2023 20:47 > To: Stephen Hemminger ; Ido Goshen > > Cc: Ferruh Yigit ; dev@dpdk.org > Subject: Re: [PATCH] net/pcap: support MTU set > > On 7/10/2023 5:45 PM, Stephen Hemminger wrote: > > On Thu, 17 Mar 2022 19:43:47 +0200 > > ido g wr

Re: [PATCH] net/pcap: support MTU set

2023-07-10 Thread Ferruh Yigit
On 7/10/2023 5:45 PM, Stephen Hemminger wrote: > On Thu, 17 Mar 2022 19:43:47 +0200 > ido g wrote: > >> Support rte_eth_dev_set_mtu by pcap vdevs >> Enforce mtu on rx/tx >> For more details see https://bugs.dpdk.org/show_bug.cgi?id=961 >> >> Signed-off-by: ido g > > Feeling less convinced that

RE: [PATCH] net/pcap: support MTU set

2022-05-23 Thread Ido Goshen
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, 27 April 2022 22:15 > To: Ido Goshen > Cc: Ferruh Yigit ; dev@dpdk.org; Danny Raveh > > Subject: Re: [PATCH] net/pcap: support MTU set > > > > > [idog] > > The main use case

Re: [PATCH] net/pcap: support MTU set

2022-04-27 Thread Stephen Hemminger
On Wed, 27 Apr 2022 18:21:37 + Ido Goshen wrote: > > From: Ferruh Yigit > > Sent: Tuesday, 26 April 2022 20:04 > > > > On 3/22/2022 1:02 PM, Ido Goshen wrote: > > > This test > > > https://doc.dpdk.org/dts/test_plans/jumboframes_test_plan.html#test-ca > > > se-jumbo-frames-with-no-jumbo-f

RE: [PATCH] net/pcap: support MTU set

2022-04-27 Thread Ido Goshen
tpmd> start > > ... > > testpmd> show port stats 0 > > > > NIC statistics for port 0 > > >RX-packets: 1 RX-missed: 0 RX-bytes: 8996 > >RX-errors: 0 > > RX-nombuf: 0 > > TX-packets: 1 TX-errors: 0 TX-bytes: 8996 > > >

Re: [PATCH] net/pcap: support MTU set

2022-04-26 Thread Ferruh Yigit
ased) don't allow oversized, tests details can be seen in https://bugs.dpdk.org/show_bug.cgi?id=961 -Original Message- From: Stephen Hemminger Sent: Thursday, 17 March 2022 20:21 To: Ido Goshen Cc: Ferruh Yigit ; dev@dpdk.org Subject: Re: [PATCH] net/pcap: support MTU set On Thu, 17

RE: [PATCH] net/pcap: support MTU set

2022-03-22 Thread Ido Goshen
### > -Original Message- > From: Ido Goshen > Sent: Thursday, 17 March 2022 21:12 > To: Stephen Hemminger > Cc: Ferruh Yigit ; dev@dpdk.org > Subject: RE: [PATCH] net/pcap: support MTU set > > As far as I can see the initial device MTU is derived from po

RE: [PATCH] net/pcap: support MTU set

2022-03-17 Thread Ido Goshen
s.dpdk.org/show_bug.cgi?id=961 > -Original Message- > From: Stephen Hemminger > Sent: Thursday, 17 March 2022 20:21 > To: Ido Goshen > Cc: Ferruh Yigit ; dev@dpdk.org > Subject: Re: [PATCH] net/pcap: support MTU set > > On Thu, 17 Mar 2022 19:43:47 +0200 >

Re: [PATCH] net/pcap: support MTU set

2022-03-17 Thread Stephen Hemminger
On Thu, 17 Mar 2022 19:43:47 +0200 ido g wrote: > + if (unlikely(header.caplen > dev->data->mtu)) { > + pcap_q->rx_stat.err_pkts++; > + rte_pktmbuf_free(mbuf); > + break; > + } MTU should only be enforced on tran

[PATCH] net/pcap: support MTU set

2022-03-17 Thread ido g
Support rte_eth_dev_set_mtu by pcap vdevs Enforce mtu on rx/tx For more details see https://bugs.dpdk.org/show_bug.cgi?id=961 Signed-off-by: ido g --- drivers/net/pcap/pcap_ethdev.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/ne