Re: [PATCH] net/nfp: fix MTU configuration order

2023-03-08 Thread Ferruh Yigit
On 3/8/2023 2:33 AM, Chaoyong He wrote: > From: Peng Zhang > > If rte_eth_dev_set_mtu() is called before rte_eth_rx_queue_setup() the > NFP driver setup fails. This is because the default values evaluated > when setting the MTU are initialized in the rte_eth_rx_queue_setup() > code path. Fix this

Re: [PATCH] net/nfp: fix MTU configuration order

2023-03-08 Thread Niklas Söderlund
Hi Stephen, Thanks for your feedback. On 2023-03-07 18:44:09 -0800, Stephen Hemminger wrote: > On Wed, 8 Mar 2023 10:33:18 +0800 > Chaoyong He wrote: > > > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > > index 5922bfea8e..5d92b476e2 100644 > > --- a/drivers/net/nfp

Re: [PATCH] net/nfp: fix MTU configuration order

2023-03-07 Thread Stephen Hemminger
On Wed, 8 Mar 2023 10:33:18 +0800 Chaoyong He wrote: > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > index 5922bfea8e..5d92b476e2 100644 > --- a/drivers/net/nfp/nfp_common.c > +++ b/drivers/net/nfp/nfp_common.c > @@ -1126,9 +1126,9 @@ nfp_net_dev_mtu_set(struct rte_e

[PATCH] net/nfp: fix MTU configuration order

2023-03-07 Thread Chaoyong He
From: Peng Zhang If rte_eth_dev_set_mtu() is called before rte_eth_rx_queue_setup() the NFP driver setup fails. This is because the default values evaluated when setting the MTU are initialized in the rte_eth_rx_queue_setup() code path. Fix this by instead initializing the MTU default values in t