RE: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-25 Thread Morten Brørup
Forwarding to the now official maintainers for review. :-) Thank you for updating the MAINTAINERS file, Bruce. PS: Please correct "fix"->"support" in the subject when merging, it was a typo. > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Thursday, 24 October 2024 13.18 > > Re

Re: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Bruce Richardson
On Thu, Oct 24, 2024 at 06:28:27PM +0200, Morten Brørup wrote: > > > > - for (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) { > > > > + for (i = 0; i < RTE_MIN(IXGBE_QUEUE_STAT_COUNTERS, > > > > + > > > > (typeof(IXGBE_QUEUE_STAT_COUNTERS))RTE_ETHDEV_QUEUE_STAT_CNTRS); > > > > i++)

RE: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Morten Brørup
Forgot the --in-reply-to, so here's the link to the V2 patch: https://inbox.dpdk.org/dev/20241024185352.987356-1...@smartsharesystems.com/

Re: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2024 11:17:57 + Morten Brørup wrote: > Remove the requirement that the configured number of queues to provide > statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the > driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS). > > Signed-off-by: Mort

RE: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Morten Brørup
> > > - for (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) { > > > + for (i = 0; i < RTE_MIN(IXGBE_QUEUE_STAT_COUNTERS, > > > + > > > (typeof(IXGBE_QUEUE_STAT_COUNTERS))RTE_ETHDEV_QUEUE_STAT_CNTRS); > > > i++) { > > The big cast using "typeof" is awkward-looking but is probably the best > way > to

Re: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Bruce Richardson
On Thu, Oct 24, 2024 at 05:15:10PM +0200, Morten Brørup wrote: > Forwarding to the now official maintainers for review. :-) > > Thank you for updating the MAINTAINERS file, Bruce. > > PS: Please correct "fix"->"support" in the subject when merging, it was a > typo. > > > From: Morten Brørup [ma

[PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Morten Brørup
Remove the requirement that the configured number of queues to provide statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS). Signed-off-by: Morten Brørup --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- 1 file cha