Re: [PATCH] net/ixgbe: fix inverted test and set conditional

2023-06-19 Thread Tyler Retzlaff
On Mon, Jun 19, 2023 at 10:19:00AM +0200, Morten Brørup wrote: > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Monday, 19 June 2023 09.54 > > > > On Thu, Jun 15, 2023 at 9:30 PM Tyler Retzlaff > > wrote: > > > > > > Correct a mistake when converting ixgbe to use __atomic_tes

RE: [PATCH] net/ixgbe: fix inverted test and set conditional

2023-06-19 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, 19 June 2023 09.54 > > On Thu, Jun 15, 2023 at 9:30 PM Tyler Retzlaff > wrote: > > > > Correct a mistake when converting ixgbe to use __atomic_test_and_set > > instead of rte_atomic32_test_and_set. The return value from > >

Re: [PATCH] net/ixgbe: fix inverted test and set conditional

2023-06-19 Thread David Marchand
On Thu, Jun 15, 2023 at 9:30 PM Tyler Retzlaff wrote: > > Correct a mistake when converting ixgbe to use __atomic_test_and_set > instead of rte_atomic32_test_and_set. The return value from > __atomic_test_and_set is inverted relative to rte_atomic32_test_and_set. > > Fixes: e90baf6b82f6 ("net/ixgb

RE: [PATCH] net/ixgbe: fix inverted test and set conditional

2023-06-15 Thread Chen, LingliX
> -Original Message- > From: Tyler Retzlaff > Sent: Friday, June 16, 2023 3:30 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Wu, Wenjun1 > ; m...@smartsharesystems.com; Tyler Retzlaff > ; david.march...@redhat.com > Subject: [PATCH] net/ixgbe: fix inverted

[PATCH] net/ixgbe: fix inverted test and set conditional

2023-06-15 Thread Tyler Retzlaff
Correct a mistake when converting ixgbe to use __atomic_test_and_set instead of rte_atomic32_test_and_set. The return value from __atomic_test_and_set is inverted relative to rte_atomic32_test_and_set. Fixes: e90baf6b82f6 ("net/ixgbe: replace legacy atomics with GCC builtin atomics") Cc: roret...

[PATCH] net/ixgbe: fix inverted test and set conditional

2023-06-15 Thread Tyler Retzlaff
net/ixgbe: fix inverted test and set conditional I either dropped `!` in the offending series or just failed to notice that the return value for __atomic_test_and_set is inverted relative to rte_atomic32_test_and_set. Tyler Retzlaff (1): net/ixgbe: fix inverted test and set conditional driver