Re: [PATCH] net/gve: Change ERR to DEBUG to prevent flooding of logs for Tx-Dqo.

2024-02-20 Thread Rushil Gupta
These are very useful insights Ferruh. I think RTE_LOG_DP() is something that would have been more suitable here. Also, the DEBUG statement combined with a statistic will be more useful than ERR from developer perspective if they see a potential memory leak in their program. On Mon, Feb 19, 2024,

Re: [PATCH] net/gve: Change ERR to DEBUG to prevent flooding of logs for Tx-Dqo.

2024-02-19 Thread Rushil Gupta
I agree. This bug has manifested for a while before I fixed it partially in "[PATCH] net/gve: fix dqo bug for chained descriptors" However, for higher queue counts (> 13); we still see this behavior. I'll add a statistic. On Mon, Feb 19, 2024, 10:56 PM Stephen Hemminger wrote: > On Mon, 19 Feb 2

Re: [PATCH] net/gve: Change ERR to DEBUG to prevent flooding of logs for Tx-Dqo.

2024-02-19 Thread Stephen Hemminger
On Mon, 19 Feb 2024 02:44:35 + Rushil Gupta wrote: > This was causing failure for testpmd runs (for queues >=15) > presumably due to flooding of logs due to descriptor ring being > overwritten. > > Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors") > Cc: sta...@dpdk.org > > Sign

Re: [PATCH] net/gve: Change ERR to DEBUG to prevent flooding of logs for Tx-Dqo.

2024-02-19 Thread Ferruh Yigit
On 2/19/2024 2:44 AM, Rushil Gupta wrote: > This was causing failure for testpmd runs (for queues >=15) > presumably due to flooding of logs due to descriptor ring being > overwritten. > > Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors") > Cc: sta...@dpdk.org > > Signed-off-by: Rush

Re: [PATCH] net/gve: Change ERR to DEBUG to prevent flooding of logs for Tx-Dqo.

2024-02-19 Thread Ferruh Yigit
On 2/19/2024 2:44 AM, Rushil Gupta wrote: > This was causing failure for testpmd runs (for queues >=15) > presumably due to flooding of logs due to descriptor ring being > overwritten. > > Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors") > Cc: sta...@dpdk.org > > Signed-off-by: Rush

[PATCH] net/gve: Change ERR to DEBUG to prevent flooding of logs for Tx-Dqo.

2024-02-18 Thread Rushil Gupta
This was causing failure for testpmd runs (for queues >=15) presumably due to flooding of logs due to descriptor ring being overwritten. Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors") Cc: sta...@dpdk.org Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net