Re: [EXTERNAL] [PATCH] graph: avoid accessing graph list when getting stats

2024-03-29 Thread Robin Jarry
Kiran Kumar Kokkilagadda, Mar 29, 2024 at 08:44: > +167,16 @@ stats_mem_init(struct cluster *cluster, > > /* Fix up callback */ >fn = prm->fn; > - if (fn == NULL) > - fn = graph_cluster_stats_cb; > + if (fn == NULL) { > + for (int i = 0; i < cluster->nb_graphs; i++) {

RE: [EXTERNAL] [PATCH] graph: avoid accessing graph list when getting stats

2024-03-29 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Robin Jarry > Sent: Monday, March 25, 2024 9:23 PM > To: dev@dpdk.org; Jerin Jacob ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilpuram > ; Zhirun Yan > Subject: [EXTERNAL] [PATCH] graph: avoid accessing graph list when getting &g

[PATCH] graph: avoid accessing graph list when getting stats

2024-03-25 Thread Robin Jarry
In rte_graph_cluster_stats_get, the walk model of the first graph is checked to determine if multi-core dispatch specific counters should be updated or not. This global list is accessed without any locks. If the global list is modified by another thread while rte_graph_cluster_stats_get is called,