Re: [PATCH] eventdev: fix symbol export for port maintenance

2023-10-12 Thread Jerin Jacob
> > > > > > I can't say I know why it's needed, but the change seems consistent with > > > other Eventdev trace points. > > > > The trace point framework in DPDK relies on a per trace point global > > variable (whose name is __): > > > > #define __RTE_TRACE_POINT(_mode, _tp, _args, ...) \ > > exter

Re: [PATCH] eventdev: fix symbol export for port maintenance

2023-10-11 Thread David Marchand
On Wed, Oct 11, 2023 at 8:51 AM Jerin Jacob wrote: > On Tue, Oct 10, 2023 at 7:30 PM David Marchand > wrote: > > > > Trying to call rte_event_maintain out of the eventdev library triggers > > a link failure, as the tracepoint symbol associated to this inline > > helper was not exported. > > > > F

Re: [PATCH] eventdev: fix symbol export for port maintenance

2023-10-11 Thread David Marchand
Jerin, On Wed, Oct 11, 2023 at 9:03 AM David Marchand wrote: > > On Wed, Oct 11, 2023 at 8:47 AM Mattias Rönnblom > wrote: > > > > On 2023-10-10 16:00, David Marchand wrote: > > > Trying to call rte_event_maintain out of the eventdev library triggers > > > a link failure, as the tracepoint symb

Re: [PATCH] eventdev: fix symbol export for port maintenance

2023-10-11 Thread David Marchand
Hello Jerin, On Wed, Oct 11, 2023 at 8:51 AM Jerin Jacob wrote: > > On Tue, Oct 10, 2023 at 7:30 PM David Marchand > wrote: > > > > Trying to call rte_event_maintain out of the eventdev library triggers > > a link failure, as the tracepoint symbol associated to this inline > > helper was not exp

Re: [PATCH] eventdev: fix symbol export for port maintenance

2023-10-11 Thread David Marchand
On Wed, Oct 11, 2023 at 8:47 AM Mattias Rönnblom wrote: > > On 2023-10-10 16:00, David Marchand wrote: > > Trying to call rte_event_maintain out of the eventdev library triggers > > a link failure, as the tracepoint symbol associated to this inline > > helper was not exported. > > > > Fixes: 54f17

Re: [PATCH] eventdev: fix symbol export for port maintenance

2023-10-10 Thread Jerin Jacob
On Tue, Oct 10, 2023 at 7:30 PM David Marchand wrote: > > Trying to call rte_event_maintain out of the eventdev library triggers > a link failure, as the tracepoint symbol associated to this inline > helper was not exported. > > Fixes: 54f17843a887 ("eventdev: add port maintenance API") > Cc: sta.

Re: [PATCH] eventdev: fix symbol export for port maintenance

2023-10-10 Thread Mattias Rönnblom
On 2023-10-10 16:00, David Marchand wrote: Trying to call rte_event_maintain out of the eventdev library triggers a link failure, as the tracepoint symbol associated to this inline helper was not exported. Fixes: 54f17843a887 ("eventdev: add port maintenance API") Cc: sta...@dpdk.org Signed-off

[PATCH] eventdev: fix symbol export for port maintenance

2023-10-10 Thread David Marchand
Trying to call rte_event_maintain out of the eventdev library triggers a link failure, as the tracepoint symbol associated to this inline helper was not exported. Fixes: 54f17843a887 ("eventdev: add port maintenance API") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- Caught by the CI whe