RE: [PATCH] ethdev: remove callback checks from fast path

2025-04-30 Thread Morten Brørup
> From: Sunil Kumar Kori > Sent: Tuesday, 29 April 2025 20.12 > > rte_eth_fp_ops contains ops for fast path APIs. Each API > validates availability of callback and then invoke it. > > Removing these NULL checks instead using dummy callbacks. The description should mention the motivation for thi

Re: [PATCH] ethdev: remove callback checks from fast path

2025-04-29 Thread Stephen Hemminger
On Tue, 29 Apr 2025 23:41:30 +0530 wrote: > > +static inline void > +rte_eth_set_dummy_fops(struct rte_eth_dev *eth_dev) Not fastpath, do not add inline here > +{ > + eth_dev->rx_pkt_burst = rte_eth_pkt_burst_dummy; > + eth_dev->tx_pkt_burst = rte_eth_pkt_burst_dummy; > + eth_dev-

Re: [PATCH] ethdev: remove callback checks from fast path

2025-04-29 Thread Stephen Hemminger
On Tue, 29 Apr 2025 23:41:30 +0530 wrote: > @@ -7131,14 +7118,11 @@ rte_eth_tx_queue_count(uint16_t port_id, uint16_t > queue_id) > goto out; > } > #endif > - if (fops->tx_queue_count == NULL) { > - rc = -ENOTSUP; > - goto out; > - } > - >

[PATCH] ethdev: remove callback checks from fast path

2025-04-29 Thread skori
From: Sunil Kumar Kori rte_eth_fp_ops contains ops for fast path APIs. Each API validates availability of callback and then invoke it. Removing these NULL checks instead using dummy callbacks. Signed-off-by: Sunil Kumar Kori --- lib/ethdev/ethdev_driver.c | 47 ++ lib/ethd