Re: [PATCH] eal: support including mapped memory in core dump

2024-10-25 Thread Stephen Hemminger
On Thu, 24 Oct 2024 02:18:59 +0300 Dmitry Kozlyuk wrote: > +static int > +enable_shared_hugepage_coredump(void) > +{ > + const char *path = "/proc/self/coredump_filter"; > + const unsigned long shared_hugepage_flag = RTE_BIT64(6); > + > + FILE *f; > + uint64_t coredump_filter; > +

Re: [PATCH] eal: support including mapped memory in core dump

2024-10-25 Thread Dmitry Kozlyuk
2024-10-24 09:38 (UTC-0700), Stephen Hemminger: > Having a process set a system global value like coredump_filter via an > internal > call seems like a potential problem. What about other processes on the system? > It may not even be allowed if using a hardened kernel. > > I would prefer that mad

Re: [PATCH] eal: support including mapped memory in core dump

2024-10-24 Thread Dmitry Kozlyuk
2024-10-24 23:54 (UTC+0300), Dmitry Kozlyuk: > 2024-10-24 09:38 (UTC-0700), Stephen Hemminger: > > Having a process set a system global value like coredump_filter via an > > internal > > call seems like a potential problem. What about other processes on the > > system? > > It may not even be allo

Re: [PATCH] eal: support including mapped memory in core dump

2024-10-24 Thread Lewis Donzis
- On Oct 23, 2024, at 6:18 PM, Dmitry Kozlyuk dmitry.kozl...@gmail.com wrote: > Lewis, testing on FreeBSD would be appreciated. Well, unfortunately, it's not working very well... The contigmem memory was not included in the core dump. I added logging just before the madvise() call to pr

Re: [PATCH] eal: support including mapped memory in core dump

2024-10-24 Thread Dmitry Kozlyuk
2024-10-24 09:22 (UTC+0200), Morten Brørup: > > From: Dmitry Kozlyuk [mailto:dmitry.kozl...@gmail.com] > > Sent: Thursday, 24 October 2024 01.19 [...] > > Add `--huge-dump` EAL command-line option to include in core dump > > all mapped hugepages and also non-hugepage memory > > allocated with `--no

RE: [PATCH] eal: support including mapped memory in core dump

2024-10-24 Thread Morten Brørup
> From: Dmitry Kozlyuk [mailto:dmitry.kozl...@gmail.com] > Sent: Thursday, 24 October 2024 01.19 > > Commit d72e4042c5eb ("mem: exclude unused memory from core dump") > unconditionally excluded all hugepage memory managed by DPDK. > The rationale was to avoid overly large core dumps > generated fr

RE: [PATCH] eal: support including mapped memory in core dump

2024-10-24 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 24 October 2024 04.31 > > On Thu, 24 Oct 2024 02:18:59 +0300 > Dmitry Kozlyuk wrote: > > > --- a/lib/eal/common/eal_internal_cfg.h > > +++ b/lib/eal/common/eal_internal_cfg.h > > @@ -103,6 +103,8 @@ struct internal_c

Re: [PATCH] eal: support including mapped memory in core dump

2024-10-23 Thread Stephen Hemminger
On Thu, 24 Oct 2024 02:18:59 +0300 Dmitry Kozlyuk wrote: > --- a/lib/eal/common/eal_internal_cfg.h > +++ b/lib/eal/common/eal_internal_cfg.h > @@ -103,6 +103,8 @@ struct internal_config { > struct simd_bitwidth max_simd_bitwidth; > /**< max simd bitwidth path to use */ > size_t

Re: [PATCH] eal: support including mapped memory in core dump

2024-10-23 Thread Stephen Hemminger
On Thu, 24 Oct 2024 02:18:59 +0300 Dmitry Kozlyuk wrote: > From: Dmitry Kozlyuk > > Commit d72e4042c5eb ("mem: exclude unused memory from core dump") > unconditionally excluded all hugepage memory managed by DPDK. > The rationale was to avoid overly large core dumps > generated from reserved (P

[PATCH] eal: support including mapped memory in core dump

2024-10-23 Thread Dmitry Kozlyuk
From: Dmitry Kozlyuk Commit d72e4042c5eb ("mem: exclude unused memory from core dump") unconditionally excluded all hugepage memory managed by DPDK. The rationale was to avoid overly large core dumps generated from reserved (PROT_NONE) but not mapped memory. Mapped hugepages, however, may hold da