Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
25/10/2023 17:18, Thomas Monjalon: > 25/10/2023 17:14, Bruce Richardson: > > On Wed, Oct 25, 2023 at 08:08:52AM -0700, Stephen Hemminger wrote: > > > On Wed, 25 Oct 2023 15:44:25 +0200 > > > Thomas Monjalon wrote: > > > > > > > > > > > > > > > I'll try to pass the test by adding a sleep in the t

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
25/10/2023 17:14, Bruce Richardson: > On Wed, Oct 25, 2023 at 08:08:52AM -0700, Stephen Hemminger wrote: > > On Wed, 25 Oct 2023 15:44:25 +0200 > > Thomas Monjalon wrote: > > > > > > > > > > > > I'll try to pass the test by adding a sleep in the test thread. > > > > > > > > > > > > > "sched_

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Bruce Richardson
On Wed, Oct 25, 2023 at 08:08:52AM -0700, Stephen Hemminger wrote: > On Wed, 25 Oct 2023 15:44:25 +0200 > Thomas Monjalon wrote: > > > > > > > > > I'll try to pass the test by adding a sleep in the test thread. > > > > > > > > > > "sched_yield()" rather than sleep perhaps? Might better conve

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Stephen Hemminger
On Wed, 25 Oct 2023 15:44:25 +0200 Thomas Monjalon wrote: > > > > > > I'll try to pass the test by adding a sleep in the test thread. > > > > > > > "sched_yield()" rather than sleep perhaps? Might better convey the > > intention of the call. > > Do we have sched_yield on Windows? Windows

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
25/10/2023 15:34, Bruce Richardson: > On Wed, Oct 25, 2023 at 03:15:49PM +0200, Thomas Monjalon wrote: > > 24/10/2023 18:04, Stephen Hemminger: > > > On Tue, 24 Oct 2023 15:55:13 +0200 > > > Morten Brørup wrote: > > > > > > > > > > > > >4. It MAY be used by preemptible multi-producer and/or

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Bruce Richardson
On Wed, Oct 25, 2023 at 03:15:49PM +0200, Thomas Monjalon wrote: > 24/10/2023 18:04, Stephen Hemminger: > > On Tue, 24 Oct 2023 15:55:13 +0200 > > Morten Brørup wrote: > > > > > > > > > >4. It MAY be used by preemptible multi-producer and/or preemptible > > > > multi- > > > > consumer pthre

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
24/10/2023 18:04, Stephen Hemminger: > On Tue, 24 Oct 2023 15:55:13 +0200 > Morten Brørup wrote: > > > > > > >4. It MAY be used by preemptible multi-producer and/or preemptible > > > multi- > > > consumer pthreads whose scheduling policy are all SCHED_OTHER(cfs), > > > SCHED_IDLE > > > or

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-24 Thread Stephen Hemminger
On Tue, 24 Oct 2023 15:55:13 +0200 Morten Brørup wrote: > > > >4. It MAY be used by preemptible multi-producer and/or preemptible multi- > > consumer pthreads whose scheduling policy are all SCHED_OTHER(cfs), > > SCHED_IDLE > > or SCHED_BATCH. User SHOULD be aware of the performance penalty

RE: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-24 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, 24 October 2023 14.54 > > When adding an API for creating threads, > the real-time priority has been forbidden on Unix. > > There is a known issue with ring behaviour, > but it should not be completely forbidden. > > Fixes: ca

[PATCH] eal/unix: allow creating thread with real-time priority

2023-10-24 Thread Thomas Monjalon
When adding an API for creating threads, the real-time priority has been forbidden on Unix. There is a known issue with ring behaviour, but it should not be completely forbidden. Fixes: ca04c78b6262 ("eal: get/set thread priority per thread identifier") Fixes: ce6e911d20f6 ("eal: add thread lifet