Re: [PATCH] common/mlx5: fix the sysfs port name translation

2022-11-11 Thread Stephen Hemminger
rg; Raslan Darawsheh > > ; sta...@dpdk.org > > Subject: Re: [PATCH] common/mlx5: fix the sysfs port name > > translation > > > > External email: Use caution opening links or attachments > > > > > > On Thu, 10 Nov 2022 17:57:26 +0200 > > Bing Zhao

RE: [PATCH] common/mlx5: fix the sysfs port name translation

2022-11-10 Thread Bing Zhao
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Friday, November 11, 2022 12:22 AM > To: Bing Zhao > Cc: Slava Ovsiienko ; Matan Azrad > ; dev@dpdk.org; Raslan Darawsheh > ; sta...@dpdk.org > Subject: Re: [PATCH] common/mlx5: fix the sysfs

Re: [PATCH] common/mlx5: fix the sysfs port name translation

2022-11-10 Thread Stephen Hemminger
On Thu, 10 Nov 2022 17:57:26 +0200 Bing Zhao wrote: > With some OFED or upstream kernel of mlx5, the port name fetched from > "/sys/class/net/[DEV]/phys_port_name" may have a tailing "\n" as the > EOL. The sscanf() will return the scanned items number with this EOL. Why not fix the DPDK driver t

[PATCH] common/mlx5: fix the sysfs port name translation

2022-11-10 Thread Bing Zhao
With some OFED or upstream kernel of mlx5, the port name fetched from "/sys/class/net/[DEV]/phys_port_name" may have a tailing "\n" as the EOL. The sscanf() will return the scanned items number with this EOL. In such case, the "equal to" condition is considered as false and the function mlx5_trans