Re: [PATCH] bus/vdev: vdev_cleanup checks dev->device.driver

2022-10-19 Thread Zhangfei Gao
On Wed, 19 Oct 2022 at 19:39, David Marchand wrote: > > On Wed, Oct 19, 2022 at 12:55 PM Zhangfei Gao wrote: > > > > The vdev_probe calls driver->probe, which may fail > > and dev->device.driver will still be NULL. > > > > In vdev_cleanup, drv = container_of(dev->device.driver) returns !NULL, > >

Re: [PATCH] bus/vdev: vdev_cleanup checks dev->device.driver

2022-10-19 Thread Zhangfei Gao
Hi, David On Wed, 19 Oct 2022 at 19:39, David Marchand wrote: > > On Wed, Oct 19, 2022 at 12:55 PM Zhangfei Gao wrote: > > > > The vdev_probe calls driver->probe, which may fail > > and dev->device.driver will still be NULL. > > > > In vdev_cleanup, drv = container_of(dev->device.driver) returns

Re: [PATCH] bus/vdev: vdev_cleanup checks dev->device.driver

2022-10-19 Thread David Marchand
On Wed, Oct 19, 2022 at 12:55 PM Zhangfei Gao wrote: > > The vdev_probe calls driver->probe, which may fail > and dev->device.driver will still be NULL. > > In vdev_cleanup, drv = container_of(dev->device.driver) returns !NULL, > then drv->remove will trigger Segmentation fault. > Fix it by checki

[PATCH] bus/vdev: vdev_cleanup checks dev->device.driver

2022-10-19 Thread Zhangfei Gao
The vdev_probe calls driver->probe, which may fail and dev->device.driver will still be NULL. In vdev_cleanup, drv = container_of(dev->device.driver) returns !NULL, then drv->remove will trigger Segmentation fault. Fix it by checking dev->device.driver first. Log: Thread 1 "dpdk-test" received si