Re: [PATCH] app/testpmd: fix lcore ID restriction

2024-04-15 Thread Stephen Hemminger
On Mon, 15 Apr 2024 19:46:31 + Sivaprasad Tummala wrote: > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -84,7 +84,7 @@ extern volatile uint8_t f_quit; > /* Maximum number of pools supported per Rx queue */ > #define MAX_MEMPOOL 8 > > -typedef uint8_t lcoreid_t; > +typ

Re: [PATCH] app/testpmd: fix lcore ID restriction

2024-04-15 Thread Stephen Hemminger
On Mon, 15 Apr 2024 19:46:31 + Sivaprasad Tummala wrote: > + nb_fwd_lcores = (lcoreid_t) n; This should really be using strtoul() not atoi() because it offers more error checking.

[PATCH] app/testpmd: fix lcore ID restriction

2024-04-15 Thread Sivaprasad Tummala
With modern CPUs, it is possible to have higher CPU count thus we can have higher RTE_MAX_LCORES. In testpmd application, the current config forwarding cores option "--nb-cores" is hard limited to 255. The patch fixes this constraint and also adjusts the lcore data structure to 32-bit to align wit