Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-08 Thread Patrick Robb
Thomas - thanks for the response. We will proceed with making the necessary changes for using v22.11.1. On Thu, Dec 8, 2022 at 8:22 AM Thomas Monjalon wrote: > I'm sorry Patrick that it gives you more work. > Your proposals below don't look possible because a tag is something fixed > forever. >

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-08 Thread Thomas Monjalon
I'm sorry Patrick that it gives you more work. Your proposals below don't look possible because a tag is something fixed forever. We had an ABI issue in the initial tag so we cannot use the tag v22.11 as planned. I don't see how we can better plan except having more tests on release candidates.

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-07 Thread Patrick Robb
Hello, Community Lab team members are wondering whether it is possible to bump v22.11 to include at least this patch. We have an existing codebase which relies on a vXX.XX scheme for producing ABI references. We parse that out at different places in our code, so fixing this to handle vXX.XX.X will

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-06 Thread Ferruh Yigit
On 12/6/2022 10:18 AM, David Marchand wrote: > On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit wrote: >> On 12/5/2022 3:37 PM, Thomas Monjalon wrote: >>> 05/12/2022 14:47, Akhil Goyal: But adding a tag on same repo is more convenient from developer point of view. However, it is my per

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-06 Thread David Marchand
On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit wrote: > On 12/5/2022 3:37 PM, Thomas Monjalon wrote: > > 05/12/2022 14:47, Akhil Goyal: > >> But adding a tag on same repo is more convenient from developer point of > >> view. > >> However, it is my personal view, others may differ. > > > > From deve

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-06 Thread Ferruh Yigit
On 12/5/2022 3:37 PM, Thomas Monjalon wrote: > 05/12/2022 14:47, Akhil Goyal: >>> On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: > Please, maintainers and CI teams, when you enable ABI checks in the > main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 > tag as a r

RE: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread Akhil Goyal
> 05/12/2022 14:47, Akhil Goyal: > > > On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: > > > > > Please, maintainers and CI teams, when you enable ABI checks in the > > > > > main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 > > > > > tag as a reference. > > > > > Thanks. > >

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread Thomas Monjalon
05/12/2022 14:47, Akhil Goyal: > > On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: > > > > Please, maintainers and CI teams, when you enable ABI checks in the > > > > main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 > > > > tag as a reference. > > > > Thanks. > > > > > > Sho

RE: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread Akhil Goyal
> On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: > > > Please, maintainers and CI teams, when you enable ABI checks in the > > > main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 > > > tag as a reference. > > > Thanks. > > > > Should we also add a tag on main repo, as new de

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread David Marchand
On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: > > Please, maintainers and CI teams, when you enable ABI checks in the > > main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 > > tag as a reference. > > Thanks. > > Should we also add a tag on main repo, as new development does

RE: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-05 Thread Akhil Goyal
> On Fri, Dec 2, 2022 at 2:39 PM Aaron Conole wrote: > > > > David Marchand writes: > > > > > ld exports any global symbol by default if no version script is passed. > > > As a consequence, the incriminated change let any public symbol leak > > > out of the driver shared libraries. > > > > > > Hi