[dpdk-dev] [PATCH 2/2] arch/ppc: fix file descriptors leakage when getting CPU features

2016-11-04 Thread vikto...@rehivetech.com
Please, add the Fixes tag. On Fri, 4 Nov 2016 11:59:09 +0530 Jianbo Liu wrote: > Signed-off-by: Jianbo Liu Acked-by: Jan Viktorin

[dpdk-dev] [PATCH 1/2] arch/arm: fix file descriptors leakage when getting CPU features

2016-11-04 Thread vikto...@rehivetech.com
Hello Jianbo Liu, thank you, a good catch! Can you please git blame for the commit introducing the issue and add the "Fixes:" tag as described in [1]? Same for ppc. Regards Jan [1] http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body On Fri, 4 Nov 2016 11:59:08 +0530 Jia

[dpdk-dev] [dpdk-dev, 1/2] app/test: rework command registration

2016-07-14 Thread vikto...@rehivetech.com
On Wed, 13 Jul 2016 23:24:09 +0200 Thomas Monjalon wrote: > The tests are registered with their command name by adding a structure > to a list. The structure of each test was declared in each test file > and passed to the register macro. > This rework generate the structure inside the register ma

[dpdk-dev] [PATCH v6 02/17] crypto: no need for a crypto pmd type

2016-07-14 Thread vikto...@rehivetech.com
On Tue, 12 Jul 2016 11:31:07 +0530 Shreyansh Jain wrote: > This information is not used and just adds noise. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v6 04/17] eal: remove duplicate function declaration

2016-07-14 Thread vikto...@rehivetech.com
On Tue, 12 Jul 2016 11:31:09 +0530 Shreyansh Jain wrote: > rte_eal_dev_init is declared in both eal_private.h and rte_dev.h since its > introduction. > This function has been exported in ABI, so remove it from eal_private.h > > Fixes: e57f20e05177 ("eal: make vdev init path generic for both virt

[dpdk-dev] [PATCH v6 03/17] drivers: align pci driver definitions

2016-07-14 Thread vikto...@rehivetech.com
On Tue, 12 Jul 2016 11:31:08 +0530 Shreyansh Jain wrote: > Pure coding style, but it might make it easier later if we want to move > fields in rte_cryptodev_driver and eth_driver structures. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v6 01/17] pci: no need for dynamic tailq init

2016-07-14 Thread vikto...@rehivetech.com
On Tue, 12 Jul 2016 11:31:06 +0530 Shreyansh Jain wrote: > These lists can be initialized once and for all at build time. > With this, those lists are only manipulated in a common place > (and we could even make them private). > > A nice side effect is that pci drivers can now register in constr

[dpdk-dev] [PATCH v6 09/17] crypto: get rid of crypto driver register callback

2016-07-14 Thread vikto...@rehivetech.com
On Tue, 12 Jul 2016 11:31:14 +0530 Shreyansh Jain wrote: > Now that all pdev are pci drivers, we don't need to register crypto drivers > through a dedicated channel. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v6 10/17] ethdev: get rid of eth driver register callback

2016-07-14 Thread vikto...@rehivetech.com
On Tue, 12 Jul 2016 11:31:15 +0530 Shreyansh Jain wrote: > Now that all pdev are pci drivers, we don't need to register ethdev drivers > through a dedicated channel. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain > --- Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v6 11/17] eal/linux: move back interrupt thread init before setting affinity

2016-07-14 Thread vikto...@rehivetech.com
On Tue, 12 Jul 2016 11:31:16 +0530 Shreyansh Jain wrote: > Now that virtio pci driver is initialized in a constructor, iopl() stuff > happens early enough so that interrupt thread can be created right after > plugin loading. > This way, chelsio driver should be happy again [1]. > > [1] http://dp

[dpdk-dev] [PATCH v6 07/17] ethdev: export init/uninit common wrappers for pci drivers

2016-07-14 Thread vikto...@rehivetech.com
On Tue, 12 Jul 2016 11:31:12 +0530 Shreyansh Jain wrote: > Preparing for getting rid of eth_drv, here are two wrappers that can be > used by pci drivers that assume a 1 to 1 association between pci resource and > upper interface. > > Signed-off-by: David Marchand > Signed-off-by: Shreyansh Jain

[dpdk-dev] [PATCH v6 06/17] crypto: export init/uninit common wrappers for pci drivers

2016-07-14 Thread vikto...@rehivetech.com
On Tue, 12 Jul 2016 11:31:11 +0530 Shreyansh Jain wrote: > Preparing for getting rid of rte_cryptodev_driver, here are two wrappers > that can be used by pci drivers that assume a 1 to 1 association between > pci resource and upper interface. > > Signed-off-by: David Marchand > Signed-off-by: S

[dpdk-dev] net/virtio-user: Fix missing brackets in if condition

2016-07-14 Thread vikto...@rehivetech.com
On Tue, 12 Jul 2016 11:30:25 +0200 Maxime Coquelin wrote: > The error is reported using test build script: I recommend to note that the error is reported only by GCC 6+. > > $ scripts/test-build.sh x86_64-native-linuxapp-gcc > ... > drivers/net/virtio/virtio_user_ethdev.c: In function > ?virt

[dpdk-dev] [PATCH 1/9] pci: no need for dynamic tailq init

2016-02-08 Thread vikto...@rehivetech.com
On Fri, 29 Jan 2016 15:08:28 +0100 David Marchand wrote: > These lists can be initialized once and for all at build time. > With this, those lists are only manipulated in a common place > (and we could even make them private). > > A nice side effect is that pci drivers can now register in constr