[dpdk-dev] [PATCH] Fix linuxapp/kni Makefile

2014-12-12 Thread r k
Subject: [PATCH] Fix linuxapp/kni Makefile When "make clean" is performed following message is seen tr: missing operand after '.-' Two strings must be given when translating. Try 'tr --help' for more information due to 'comma' not defined. Include appropriate .mk file. Signed-off-by: Ravi Kerur

[dpdk-dev] [PATCH] Minor fixes in rte_common.h file.

2014-12-12 Thread r k
Subject: [PATCH] Minor fixes in rte_common.h file. Fix rte_is_power_of_2 since 0 is not. Avoid branching instructions in RTE_MAX and RTE_MIN. Signed-off-by: Ravi Kerur --- lib/librte_eal/common/include/rte_common.h | 6 +++--- lib/librte_pmd_e1000/igb_pf.c | 4 ++-- lib/librte_pmd_

[dpdk-dev] [PATCH] Minor fixes in rte_common.h file.

2014-12-12 Thread r k
Ravi Kerur (1): Minor fixes in rte_common.h file. lib/librte_eal/common/include/rte_common.h | 6 +++--- lib/librte_pmd_e1000/igb_pf.c | 4 ++-- lib/librte_pmd_ixgbe/ixgbe_pf.c| 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) -- 1.9.1

[dpdk-dev] [PATCH] Fix linuxapp/kni makefile

2014-12-12 Thread r k
Re-sending as per guidelines. Subject: [PATCH] Fix linuxapp/kni makefile *** BLURB HERE *** Ravi Kerur (1): Fix linuxapp/kni Makefile lib/librte_eal/linuxapp/kni/Makefile | 1 + 1 file changed, 1 insertion(+) -- 1.9.1

[dpdk-dev] [PATCH v3] test-pmd: Fix pointer aliasing error

2014-12-11 Thread r k
Thomas, Michael, Wouldn't it cause unaligned memory access (new changes as well as the previous code)? Wondering if get_unaligned/put_unaligned macros similar to the ones used in kernel be ported to user-space? Thanks, Ravi On Wed, Dec 10, 2014 at 4:54 PM, Thomas Monjalon wrote: > > > > app/tes

[dpdk-dev] [PATCH] When "make clean" is executed following error msg is thrown == Clean lib/librte_eal/linuxapp/kni tr: missing operand after '.-' Two strings must be given when translating.

2014-12-10 Thread r k
Subject: [PATCH] When "make clean" is executed following error msg is thrown == Clean lib/librte_eal/linuxapp/kni tr: missing operand after '.-' Two strings must be given when translating. due to missing "comma" definition in Makefile. Signed-off-by: Ravi Kerur --- lib/librte_eal/linuxapp/kni/M

[dpdk-dev] [PATCH] Fix top level 'make clean'

2014-12-10 Thread r k
When 'make clean' is executed, following message is thrown on console due to missing 'comma' definition. tr: missing operand after '.-' Two strings must be given when translating. Ravi Kerur (1): When "make clean" is executed following msg is thrown ==Clean lib/librte_eal/linuxapp/kni tr: m

[dpdk-dev] [PATCH] Fix power_of_2 macro. Avoid branching when calculating RTE_MIN and RTE_MAX.

2014-12-10 Thread r k
Just sent another patch explaining the fix and signed-off. Thanks, Ravi On Wed, Dec 10, 2014 at 4:58 AM, Thomas Monjalon wrote: > 2014-12-09 13:05, r k: >> Subject: [PATCH] Fix power_of_2 macro. Avoid branching when >> calculating RTE_MIN and RTE_MAX. > > Please could you

[dpdk-dev] [PATCH] Fix rte_is_power_of_2() function since it returns true for zero and zero is not a power of 2. Avoid branching in RTE_MIN and RTE_MAX when calculating minimum and maximum of two numb

2014-12-10 Thread r k
Subject: [PATCH] Fix rte_is_power_of_2() function since it returns true for zero and zero is not a power of 2. Avoid branching in RTE_MIN and RTE_MAX when calculating minimum and maximum of two numbers. Signed-off-by: Ravi Kerur --- lib/librte_eal/common/include/rte_common.h | 6 +++--- lib/libr

[dpdk-dev] [PATCH] Simple fix in rte_is_power_of_2 and RTE_MIN/RTE_MAX

2014-12-10 Thread r k
Subject: [PATCH] Simple fix in rte_is_power_of_2 and RTE_MIN/RTE_MAX Number 0 is not a power_of_2, fix it in rte_is_power_of_2 function. Avoid code which generates branching when calculating min and max. Ravi Kerur (1): Fix rte_is_power_of_2() function since it returns true for zero and ze

[dpdk-dev] [PATCH] Fix power_of_2 macro. Avoid branching when calculating RTE_MIN and RTE_MAX.

2014-12-09 Thread r k
Subject: [PATCH] Fix power_of_2 macro. Avoid branching when calculating RTE_MIN and RTE_MAX. --- lib/librte_eal/common/include/rte_common.h | 6 +++--- lib/librte_pmd_e1000/igb_pf.c | 4 ++-- lib/librte_pmd_ixgbe/ixgbe_pf.c| 4 ++-- 3 files changed, 7 insertions(+), 7 del

[dpdk-dev] [PATCH] Small fixes in rte_common.h

2014-12-09 Thread r k
Subject: [PATCH] Small fixes in rte_common.h Fix a bug in power_of_2 since zero is not. Avoid branching in RTE_MIN and RTE_MAX macros. Ravi Kerur (1): Fix power_of_2 macro. Avoid branching when calculating RTE_MIN and RTE_MAX. lib/librte_eal/common/include/rte_common.h | 6 +++--- lib/librt

[dpdk-dev] Q on consolidating linuxapp/bsdapp in eal

2014-11-21 Thread r k
Sure will wait for your patchset. If there is anything other than cleanup that needs to be looked at please let me know. I can start on that. Thanks, Ravi On Fri, Nov 21, 2014 at 10:23 AM, Thomas Monjalon wrote: > 2014-11-21 10:13, r k: >> Thanks to Thomas for providing some input

[dpdk-dev] Q on consolidating linuxapp/bsdapp in eal

2014-11-21 Thread r k
Hi, Thanks to Thomas for providing some inputs on this. I am looking at consolidating common code in linuxapp/bsdapp in librte_eal. I have started with header files and had some questions related to it. 1. For some header files for e.g. eal_internal_cfg.h, there are very minor differences betwee

[dpdk-dev] Q on contribution to DPDK

2014-11-04 Thread r k
: inline replies are preferred in general > > -- > Thomas > > > 2014-10-31 15:53, r k: >> Hi Jim, >> >> Thanks for your response. I did check DPDK roadmap and it wasn't clear >> to me what's available to be implemented. In addition, roadmap lists >&g

[dpdk-dev] Q on contribution to DPDK

2014-10-31 Thread r k
ge on the site for guidance: > http://dpdk.org/dev > > If you have particular areas of interest or expertise just share that with > the list. > > I look forward to your contributions. > > Jim > > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] O

[dpdk-dev] Q on code contribution to DPDK

2014-10-31 Thread r k
Hello DPDK development team, This is the 3rd email i am sending but it never shows up. I am subscribed to the list though. I am interested in contributing to DPDK and wanted to know a way of contributing to it. Some questions 1. Will DPDK accept patches from community? I will be individual contr

[dpdk-dev] Q on contribution to DPDK

2014-10-31 Thread r k
Hello DPDK development team, I am interested in contributing to DPDK and wanted to know a way of contributing to it. Some questions 1. Will DPDK accept patches from community? I will be individual contributor with no affiliation to any company. 2. If answer is "Yes" to previous question, should