Re: [dpdk-dev] [PATCH] Remove printf from signal handler.

2020-12-11 Thread prateekag
er do we really have to try to 'fix' that? I don't remember anyone complained about such problem in 10 years DPDK exists. Konstantin Maybe other people have better ideas? BRs Xiaoyun > -Original Message- > From: prateekag > Sent: Thursday, December 10, 202

Re: [dpdk-dev] [PATCH] Remove printf from signal handler.

2020-12-10 Thread prateekag
Hi Agree. What is the way out? The printfs you mentioned look like important messages and may have been called outside signal handler routines. Shall they be removed as well or converted to "write" function call? Or we live with the possiblity of deadlock howsoever unlikely. Regards Prateek Aga

Re: [dpdk-dev] Printfs in Signal Handler

2020-12-04 Thread prateekag
de. strcpy is asyc-safe afaik. The strings in which signal number is not required to printed can be directly converted to write call. Prateek Agarwal On 2020-12-03 02:11, Thomas Monjalon wrote: 01/12/2020 10:24, Thomas Monjalon: 01/12/2020 04:39, prateekag: > printf is not signal safe an

Re: [dpdk-dev] Printfs in Signal Handler

2020-12-04 Thread prateekag
Ok. On 2020-12-03 02:11, Thomas Monjalon wrote: 01/12/2020 10:24, Thomas Monjalon: 01/12/2020 04:39, prateekag: > printf is not signal safe and may lead to deadlock if kept in signal handler > and > signal comes in two quick succession. It will not lead to incorrect behavior >

[dpdk-dev] Printfs in Signal Handler

2020-12-02 Thread prateekag
printf is not signal safe and may lead to deadlock if kept in signal handler and signal comes in two quick succession. It will not lead to incorrect behavior and it is a highly unlikely event. And an expert may understand why this issue happened. Is it worthwhile to change these printfs to un

[dpdk-dev] [PATCH] Documentation errata:RCU_lib.rst and Ring fig 6.10 corrected

2020-02-03 Thread prateekag
From: prateekagarwal88 Signed-off-by: prateekagarwal88 --- .../prog_guide/img/ring-mp-enqueue3.svg | 194 +- doc/guides/prog_guide/rcu_lib.rst | 2 +- 2 files changed, 101 insertions(+), 95 deletions(-) diff --git a/doc/guides/prog_guide/img/ring-mp-enqueue3

[dpdk-dev] [PATCH 2/2] 6.10 png replaced with svg

2020-01-29 Thread prateekag
From: prateekagarwal88 --- .../prog_guide/img/ring-mp-enqueue3.png | Bin 52346 -> 0 bytes .../prog_guide/img/ring-mp-enqueue3.svg | 791 ++ 2 files changed, 791 insertions(+) delete mode 100644 doc/guides/prog_guide/img/ring-mp-enqueue3.png create mode 100644 doc/g

[dpdk-dev] [PATCH 1/2] Documentation errata:RCU_lib.rst and Ring fig 6.10 corrected

2020-01-29 Thread prateekag
From: PRATEEK AGARWAL --- .../prog_guide/img/ring-mp-enqueue3.png | Bin 0 -> 52346 bytes .../prog_guide/img/ring-mp-enqueue3.svg | 785 -- doc/guides/prog_guide/rcu_lib.rst | 2 +- 3 files changed, 1 insertion(+), 786 deletions(-) create mode 100644 do

[dpdk-dev] [PATCH] Documentation errata:RCU_lib.rst and Ring fig 6.10 corrected

2020-01-28 Thread prateekag
From: PRATEEK AGARWAL --- .../prog_guide/img/ring-mp-enqueue3.png | Bin 0 -> 52346 bytes .../prog_guide/img/ring-mp-enqueue3.svg | 785 -- doc/guides/prog_guide/rcu_lib.rst | 2 +- 3 files changed, 1 insertion(+), 786 deletions(-) create mode 100644 do