Re: [dpdk-dev] [PATCH] memzone: Check socket_id value when creating memzone.

If that patch is ok, will we apply it to master? Thanks. Nick > On May 12, 2017, at 4:42 PM, Bruce Richardson > wrote: > > On Thu, May 11, 2017 at 11:03:43PM -0700, Tonghao Zhang wrote: >> If the socket_id is invalid (e.g. -2, -3), the >> memzone_reserve_aligned_thread_unsafe should return the

Re: [dpdk-dev] [PATCH v3] eal: Set numa node value for system which not support it.

Did you think this patch is necessary. I submitted v4. v4: http://dpdk.org/dev/patchwork/patch/24212/ <http://dpdk.org/dev/patchwork/patch/24212/> Thanks. Nick > On May 10, 2017, at 10:20 PM, nickcooper-zhangtonghao > wrote: > > Thanks for your review. > >>

Re: [dpdk-dev] [PATCH] memzone: Check socket_id value when creating memzone.

> On May 12, 2017, at 4:42 PM, Bruce Richardson > wrote: > > On Thu, May 11, 2017 at 11:03:43PM -0700, Tonghao Zhang wrote: >> If the socket_id is invalid (e.g. -2, -3), the >> memzone_reserve_aligned_thread_unsafe should return the >> EINVAL and not ENOMEM. To avoid it, we should check the >>

Re: [dpdk-dev] [PATCH v3] eal: Set numa node value for system which not support it.

Thanks for your review. > On May 10, 2017, at 8:45 PM, Thomas Monjalon wrote: > >> The NUMA node information for PCI devices provided through >> sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx >> on Red Hat Enterprise Linux 6, and VMs on some hypervisors. > > Sorry I don't understa

Re: [dpdk-dev] [PATCH v3 1/4] vmxnet3: Avoid memory leak in vmxnet3_dev_rx_queue_setup.

> On Jan 18, 2017, at 10:05 AM, Yong Wang wrote: > > Any downside with free/reallocation now that memzone can be freed? > Allocation with max ring size should work but is kind of wasteful in terms of > memory usage and I assume this type of ring size change should not be a > frequent operat

Re: [dpdk-dev] [PATCH v3 1/4] vmxnet3: Avoid memory leak in vmxnet3_dev_rx_queue_setup.

> On Jan 18, 2017, at 4:15 AM, Yong Wang wrote: > >> -Original Message- >> From: Nick Zhang [mailto:n...@opencloud.tech ] >> Sent: Sunday, January 8, 2017 7:00 PM >> To: Yong Wang mailto:yongw...@vmware.com>> >> Cc: ferruh.yi...@intel.com

Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA.

I submitted the patches for first time. The first one is an individual patch for eal, others is for vmxnet3 interdependently. Thanks. Nick > On Jan 5, 2017, at 10:23 PM, Ferruh Yigit wrote: > > Hi nickcooper-zhangtonghao, > > The patches in the patchset are individual pat

Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA.

Thanks for your reply. The patch you submitted is better. Thanks for your improvement. My legal name is “Nick Zhang”. So, Signed-off-by: Nick Zhang Thanks. Nick > On Jan 6, 2017, at 12:26 AM, Stephen Hemminger > wrote: > > It is good to see more checking for valid values. I suspect that

Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA.

> On Jan 6, 2017, at 8:01 AM, Yong Wang wrote: > > Can you add the exact steps to reproduce the vmxnet3 issues to help the > review and the verification. My guess is that you have stopped the device, > changed some ring parameters (to something larger than the previous settings) > and restart

[dpdk-dev] [PATCH v2 3/5] vmxnet3: Avoid segfault caused by vmxnet3_dev_rx_queue_setup.

We should allocate RX ring for max possible number of hardware descriptors. If we config RX queue with 2048 RX queue size, and 4096 soon, there will be segment fault when calling other ethernet API (e.g. rte_eth_dev_start). Signed-off-by: nickcooper-zhangtonghao --- drivers/net/vmxnet3

[dpdk-dev] [PATCH v2 4/5] vmxnet3: Avoid memory leak in vmxnet3_dev_tx_queue_setup.

This patch will check the "nb_desc" parameter for tx queue, release the txq and re-allocation it soon. Signed-off-by: nickcooper-zhangtonghao --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v2 5/5] vmxnet3: Avoid segfault caused by vmxnet3_dev_tx_queue_setup.

We should allocate Tx ring for max possible mumber of hardware descriptors. If we config Tx queue with 2048 Tx queue size, and 4096 soon, there will be segment fault. Signed-off-by: nickcooper-zhangtonghao --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 7 --- 1 file changed, 4 insertions(+), 3

[dpdk-dev] [PATCH v2 2/5] vmxnet3: Avoid memory leak in vmxnet3_dev_rx_queue_setup.

This patch will check the "nb_desc" parameter for rx queue, release the rxq and re-allocation it soon. Signed-off-by: nickcooper-zhangtonghao --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA.

The NUMA node information for PCI devices provided through sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx on Red Hat Enterprise Linux 6, and VMs on some hypervisors. Signed-off-by: nickcooper-zhangtonghao --- lib/librte_eal/linuxapp/eal/eal_pci.c | 8 +++- 1 file changed, 7

[dpdk-dev] [PATCH 4/5] vmxnet3: Avoid memory leak in vmxnet3_dev_tx_queue_setup.

This patch will check the "nb_desc" parameter for tx queue, release the txq and re-allocation it soon. Signed-off-by: nickcooper-zhangtonghao --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/d

[dpdk-dev] [PATCH 1/5] NUMA: Set numa node value for system which not support NUMA.

The NUMA node information for PCI devices provided through sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx on Red Hat Enterprise Linux 6, and VMs on some hypervisors. Signed-off-by: nickcooper-zhangtonghao --- lib/librte_eal/linuxapp/eal/eal_pci.c | 8 +++- 1 file changed, 7

[dpdk-dev] [PATCH 3/5] vmxnet3: Avoid segfault caused by vmxnet3_dev_rx_queue_setup.

We should allocate RX ring for max possible mumber of hardware descriptors. If we config RX queue with 2048 RX queue size, and 4096 soon, there will be segment fault when calling other ethernet API (e.g. rte_eth_dev_start). Signed-off-by: nickcooper-zhangtonghao --- drivers/net/vmxnet3

[dpdk-dev] [PATCH 5/5] vmxnet3: Avoid segfault caused by vmxnet3_dev_tx_queue_setup.

We should allocate Tx ring for max possible mumber of hardware descriptors. If we config Tx queue with 2048 Tx queue size, and 4096 soon, there will be segment fault. Signed-off-by: nickcooper-zhangtonghao --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 7 --- 1 file changed, 4 insertions(+), 3

[dpdk-dev] [PATCH 2/5] vmxnet3: Avoid memory leak in vmxnet3_dev_rx_queue_setup.

This patch will check the "nb_desc" parameter for rx queue, release the rxq and re-allocation it soon. Signed-off-by: nickcooper-zhangtonghao --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/d