[dpdk-dev] [PATCH] crypto/mvsam: remove crypto end enumerators

2020-09-30 Thread michaelsh
From: Michael Shamis Remove enumerators RTE_CRYPTO_CIPHER_LIST_END, RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent some problems that may arise when adding new crypto algorithms. Signed-off-by: Michael Shamis --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 6 +++--- 1 file changed, 3

[dpdk-dev] [PATCH v3 2/3] examples/fips_validation: add AES ECB support

2019-10-01 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- .../fips_validation/fips_validation_aes.c | 1 + examples/fips_validation/main.c | 96 +-- 2 files changed, 91 insertions(+), 6 deletions(-) diff --git a/examples/fips_validation/fips_validation_aes.c b/

[dpdk-dev] [PATCH v3 3/3] examples/fips_validation: separate ECB and CBC

2019-10-01 Thread michaelsh
From: Michael Shamis Separate initialization of IV, PT and CT according to TDES ECB and CBC crypto modes Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 66 + 1 file changed, 50 insertions(+), 16 deletions(-) diff --git a/examples/fips_valid

[dpdk-dev] [PATCH v3 1/3] examples/fips_validation: add TDES ECB support

2019-10-01 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c| 1 + examples/fips_validation/fips_validation.h| 7 + .../fips_validation/fips_validation_tdes.c| 7 + examples/fips_validation/main.c | 27 ---

[dpdk-dev] [PATCH v3 0/3] support ECB for AES and TDES

2019-10-01 Thread michaelsh
From: Michael Shamis v3: Changed patch names to comply DPDK contributing requirements v2: fips_validation-separation-between-HMAC-SHA.patch has been moved to fix patch Michael Shamis (3): examples/fips_validation: add TDES ECB support examples/fips_validation: add AES ECB support examples

[dpdk-dev] [PATCH v3 3/3] examples/fips_validation: separate ECB and CBC

2019-10-01 Thread michaelsh
From: Michael Shamis Separate initialization of IV, PT and CT according to TDES ECB and CBC crypto modes Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 66 + 1 file changed, 50 insertions(+), 16 deletions(-) diff --git a/examples/fips_valid

[dpdk-dev] [PATCH v3 2/3] examples/fips_validation: add AES ECB support

2019-10-01 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- .../fips_validation/fips_validation_aes.c | 1 + examples/fips_validation/main.c | 96 +-- 2 files changed, 91 insertions(+), 6 deletions(-) diff --git a/examples/fips_validation/fips_validation_aes.c b/

[dpdk-dev] [PATCH v3 1/3] examples/fips_validation: add TDES ECB support

2019-10-01 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c| 1 + examples/fips_validation/fips_validation.h| 7 + .../fips_validation/fips_validation_tdes.c| 7 + examples/fips_validation/main.c | 27 ---

[dpdk-dev] [PATCH v3 0/3] support ECB for AES and TDES

2019-10-01 Thread michaelsh
From: Michael Shamis Michael Shamis (3): examples/fips_validation: add TDES ECB support examples/fips_validation: add AES ECB support examples/fips_validation: separate ECB and CBC examples/fips_validation/fips_validation.c| 1 + examples/fips_validation/fips_validation.h| 7 +

[dpdk-dev] [PATCH v2 2/3] examples/fips_validation: added support AES ECB

2019-09-19 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- .../fips_validation/fips_validation_aes.c | 1 + examples/fips_validation/main.c | 96 +-- 2 files changed, 91 insertions(+), 6 deletions(-) diff --git a/examples/fips_validation/fips_validation_aes.c b/

[dpdk-dev] [PATCH v2 0/3] Support ECB for AES and TDES

2019-09-19 Thread michaelsh
From: Michael Shamis Michael Shamis (3): examples/fips_validation: added support for TDES ECB examples/fips_validation: added support AES ECB examples/fips_validation: separated init for TDES ECB and CBC examples/fips_validation/fips_validation.c| 1 + examples/fips_validation/fips_

[dpdk-dev] [PATCH v2 1/3] examples/fips_validation: added support for TDES ECB

2019-09-19 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c| 1 + examples/fips_validation/fips_validation.h| 7 + .../fips_validation/fips_validation_tdes.c| 7 + examples/fips_validation/main.c | 27 ---

[dpdk-dev] [PATCH v2 3/3] examples/fips_validation: separated init for TDES ECB and CBC

2019-09-19 Thread michaelsh
From: Michael Shamis TDES: IV, PT and CT are initiated according to ECB or CBC cipher mode now Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 66 + 1 file changed, 50 insertions(+), 16 deletions(-) diff --git a/examples/fips_validation/main

[dpdk-dev] [PATCH 6/8] examples/fips_validation: fix overwrite of KEY line in TDES

2019-09-19 Thread michaelsh
From: Michael Shamis Fix for TCBCMonte2, TCBCMonte3 and TECBMonte2: application overwrites key1 line in output file so comparision with sample files failed Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 20 1 file changed, 20 insertions(+)

[dpdk-dev] [PATCH 7/8] examples/fips_validation: improve algo parsing logic

2019-09-19 Thread michaelsh
From: Michael Shamis The fix allows to find algorithm by folder name if the algorithm was not found from the test file header. In order to find algorithm used the folder name if it is not defined within the file. Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 4

[dpdk-dev] [PATCH 5/8] examples/fips_validation: fix AES-GCM decryption vector

2019-09-19 Thread michaelsh
From: Michael Shamis AES-GCM CAVS vectors for decryption set PTlen (plain text length) but provide crypto text and application expected CTlen to be not null. Now we assign PTlen to CTlen in decryption scenario and it allows to application to handle AES-GCM decryption vectors. Signed-off-by: Mich

[dpdk-dev] [PATCH 4/8] examples/fips_validation: move digest after cipher text

2019-09-19 Thread michaelsh
From: Michael Shamis Fix of GCM FIPS bug: ICV was not copied after the crypto text in decryption operation so driver failed to check authentication in GCM mode. Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 4 1 file changed, 4 insertions(+) diff --git a/examples/fi

[dpdk-dev] [PATCH 3/8] examples/fips_validation: initialize IV for AES-GCM

2019-09-19 Thread michaelsh
From: Michael Shamis Configurated AES-GCM IV may include only salt value which length is 12B. In this case driver should set second part of IV to initial value = 0x1. Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletion

[dpdk-dev] [PATCH 8/8] examples/fips_validation: fix plain text overwrite

2019-09-19 Thread michaelsh
From: Michael Shamis fix erroneous overwrite of PLAINTEXT-line after [DECRYPT] tag Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/examples/fips_validation/fips_validation.c b/examples

[dpdk-dev] [PATCH 0/8] Fips validation fixes

2019-09-19 Thread michaelsh
From: Michael Shamis Include fixes related to SHA, TDES and GCM. Michael Shamis (8): examples/fips_validation: separation between HMAC-SHA and SHA examples/fips_validation: fix structs used for AES-GCM examples/fips_validation: initialize IV for AES-GCM examples/fips_validation: move dig

[dpdk-dev] [PATCH 2/8] examples/fips_validation: fix structs used for AES-GCM

2019-09-19 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation_gcm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c index 0509b

[dpdk-dev] [PATCH 1/8] examples/fips_validation: separation between HMAC-SHA and SHA

2019-09-19 Thread michaelsh
From: Michael Shamis Fix: SHA initialization will not be called in case of HAMC-SHA Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/fips_validation/fips_validation.c b/exampl

[dpdk-dev] [PATCH 12/12] examples/fips: erroneous overwrite of PLAINTEXT after DECRYPT

2019-08-26 Thread michaelsh
From: Michael Shamis fix erroneous overwrite of PLAINTEXT-line after [DECRYPT] tag Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/examples/fips_validation/fips_validation.c b/examples

[dpdk-dev] [PATCH 11/12] examples/fips: algorithm definition by folder if it's not in file

2019-08-26 Thread michaelsh
From: Michael Shamis In order to find algorithm used the folder name if it is not defined within the file. Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/examples/fips_validation/fips_vali

[dpdk-dev] [PATCH 10/12] examples/fips: supported IV, PT and CT init for TDES ECB mode

2019-08-26 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 66 + 1 file changed, 50 insertions(+), 16 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 1d621f60a..3eda0f554 100644 ---

[dpdk-dev] [PATCH 09/12] examples/fips: fix KEY and PT output prints for TDES mode

2019-08-26 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 20 1 file changed, 20 insertions(+) diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c index 91e6d48e7..ba513672e 100644

[dpdk-dev] [PATCH 06/12] examples/fips: set initial IV in AES-GCM if configured only salt value

2019-08-26 Thread michaelsh
From: Michael Shamis Configurated AES-GCM IV may include only salt value which length is 12B. In this case driver should set second part of IV to initial value = 0x1. Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletion

[dpdk-dev] [PATCH 04/12] examples/fips: fix bad return code in fips_test_parse_header()

2019-08-26 Thread michaelsh
From: Michael Shamis Returning correct error value by fips_test_parse_header() allows graceful exit of fips application. Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/fips_validati

[dpdk-dev] [PATCH 07/12] examples/fips: keep digest after crypto text

2019-08-26 Thread michaelsh
From: Michael Shamis Fix of GCM FIPS bug: ICV was not copied after the crypto text in decryption operation so SAM failed to check authentication in GCM mode. Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_

[dpdk-dev] [PATCH 05/12] examples/fips: AES-GCM vectors will use aead structure

2019-08-26 Thread michaelsh
From: Michael Shamis Before the fix AES-GCM vectores were defined by cipher_auth structure but handled by aead structure and that leads to FIPS test failure. Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation_gcm.c | 16 1 file changed, 8 insertions(+),

[dpdk-dev] [PATCH 08/12] examples/fips: AES-GCM decryption vectors fix

2019-08-26 Thread michaelsh
From: Michael Shamis AES-GCM CAVS vectors for decryption set PTlen (plain text length) but provide crypto text and application expected CTlen to be not null. Now we assign PTlen to CTlen in decryption scenario and it allows to application to handle AES-GCM decryption vectors. Signed-off-by: Mich

[dpdk-dev] [PATCH 03/12] examples/fips: added support AES ECB mode in FIPS tests

2019-08-26 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- .../fips_validation/fips_validation_aes.c | 1 + examples/fips_validation/main.c | 96 +-- 2 files changed, 91 insertions(+), 6 deletions(-) diff --git a/examples/fips_validation/fips_validation_aes.c b/

[dpdk-dev] [PATCH 01/12] examples/fips: added support for SHA algorithm in FIPS tests

2019-08-26 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c index 8d43b267e..80fd482a1

[dpdk-dev] [PATCH 02/12] examples/fips: added support for TDES ECB mode in FIPS tests

2019-08-26 Thread michaelsh
From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c| 1 + examples/fips_validation/fips_validation.h| 7 + .../fips_validation/fips_validation_tdes.c| 7 + examples/fips_validation/main.c | 27 ---

[dpdk-dev] [PATCH 00/12] FIPS improvements

2019-08-26 Thread michaelsh
From: Michael Shamis Added support for ECB mode in TDES and AES. Fixed some bugs in TDES and AES-GCM. Michael Shamis (12): examples/fips: added support for SHA algorithm in FIPS tests examples/fips: added support for TDES ECB mode in FIPS tests examples/fips: added support AES ECB mode in

[dpdk-dev] [PATCH] examples/ipsec-secgw: add offload error handling

2019-08-25 Thread michaelsh
From: Michael Shamis Added error handler for offload mode. Signed-off-by: Michael Shamis --- examples/ipsec-secgw/ipsec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index dc85adfe5..583c91658 100644 --- a/examples/ipsec

[dpdk-dev] [PATCH] examples/ipsec-secgw: add offload error handling

2019-08-20 Thread michaelsh
From: Michael Shamis Added error handler for offload mode. Signed-off-by: Michael Shamis --- examples/ipsec-secgw/ipsec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index dc85adfe5..583c91658 100644 --- a/examples/ipsec