RE: [PATCH] test/crypto: check for RSA capability

2025-01-08 Thread Akhil Goyal
> > Subject: [PATCH] test/crypto: check for RSA capability > > > > In RSA crypto tests, check if it is supported by PMD before > > executing it. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > --- > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [PATCH] crypto/virtio: fix dataqueues iteration

2025-01-08 Thread Akhil Goyal
; > Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Gowrishankar Muthukrishnan > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks

RE: [EXTERNAL] [PATCH v2] cryptodev: not close device when secondary exit

2025-01-08 Thread Akhil Goyal
> The secordary process should not close the crypto device when > it exits because the primary process still manage the device. > There is no reason with occurring error log below when > secordary process exits without any operation on the crypto > device while primary process starts the device. >

RE: [EXTERNAL] Re: [PATCH v2] cryptodev: fix C++ include

2025-01-08 Thread Akhil Goyal
> On 2024-12-19 14:30, Thomas Monjalon wrote: > > Some cryptodev functions were not included in an extern "C" block. > > > > There are 2 blocks, the second one being fast path inline functions, > > preceded with an include of the required rte_cryptodev_core.h file. > > > > Fixes: 719834a6849e ("use

RE: [PATCH] crypto/openssl: fix CMAC auth context update

2025-01-08 Thread Akhil Goyal
> > This patch removes an unnecessary cleanup of the shared CMAC context at > > the end of the CMAC authentication function, which causes subsequent calls > > to it to fail. > > > > Fixes: 17d5bc6135af ("crypto/openssl: make per-QP auth context clones") > > Cc: sta...@dpdk.org > > > > Signed-off-by

RE: [EXTERNAL] [PATCH 1/2] lib/cryptodev: avoid implicit conversion to 64 bit number

2025-01-08 Thread Akhil Goyal
with. > That eliminates the need for a conversion to 64 bits later. > > Signed-off-by: Andre Muezerie Acked-by: Akhil Goyal 1/2 patch Applied to dpdk-next-crypto 2/2 patch will be taken via main tree. Thanks.

RE: [PATCH] test/crypto: return proper codes in create session

2025-01-08 Thread Akhil Goyal
> Subject: [PATCH] test/crypto: return proper codes in create session > > Return proper error codes in create_auth_session() to avoid > segfaults as a result of this. > > Signed-off-by: Rajesh Mudimadugula Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [PATCH v2] crypto/virtio: remove redundant crypto queue free

2025-01-08 Thread Akhil Goyal
MD ops") Cc: sta...@dpdk.org > > Signed-off-by: Rajesh Mudimadugula Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [EXTERNAL] [PATCH] cryptodev: allow use of global variables from C++

2025-01-08 Thread Akhil Goyal
> Avoid C++ name mangling of the two global variables being exported > from . > > Suggested-by: David Marchand > Signed-off-by: Mattias Rönnblom > --- > lib/cryptodev/rte_crypto_asym.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/crypto

RE: [PATCH] test/crypto: check for RSA capability

2025-01-07 Thread Akhil Goyal
> Subject: [PATCH] test/crypto: check for RSA capability > > In RSA crypto tests, check if it is supported by PMD before > executing it. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Acked-by: Akhil Goyal

RE: [PATCH] crypto/virtio: fix dataqueues iteration

2025-01-07 Thread Akhil Goyal
/virtio: support basic PMD ops") > Cc: sta...@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal

RE: [EXTERNAL] [PATCH v22 13/13] compress/zsda: add zsda compressdev capabilities

2025-01-07 Thread Akhil Goyal
> Add zsda compressdev capabilities. > > Signed-off-by: Hanxiao Li > --- > doc/guides/compressdevs/features/zsda.ini | 9 + > doc/guides/compressdevs/zsda.rst | 23 +++ > doc/guides/rel_notes/release_24_11.rst| 7 +++ > drivers/compress/zsda/zsda_co

RE: [EXTERNAL] [PATCH v22 10/13] compress/zsda: add zsda compressdev qp ops

2025-01-07 Thread Akhil Goyal
> diff --git a/drivers/common/zsda/zsda_device.c > b/drivers/common/zsda/zsda_device.c > index 5c835651ea..5297c80ef9 100644 > --- a/drivers/common/zsda/zsda_device.c > +++ b/drivers/common/zsda/zsda_device.c > @@ -11,7 +11,6 @@ > #include "zsda_device.h" > #include "zsda_logs.h" > #include "zsd

RE: [EXTERNAL] [PATCH v22 07/13] compress/zsda: add zsda compressdev dev ops

2025-01-07 Thread Akhil Goyal
> add zsda compressdev dev interface implementation. > > Signed-off-by: Hanxiao Li > --- > drivers/common/zsda/meson.build | 1 + > drivers/common/zsda/zsda_qp_common.c | 57 ++ > drivers/common/zsda/zsda_qp_common.h | 36 +++ > drivers/compress/zsda/zsda_comp_pmd.c | 144

RE: [EXTERNAL] [PATCH v22 06/13] compress/zsda: add zsda compressdev driver skeleton

2025-01-07 Thread Akhil Goyal
Hi Hanxiao, Please see comments inline. > Add zsda compressdev driver interface skeleton > > Signed-off-by: Hanxiao Li > --- > MAINTAINERS | 3 + > doc/guides/compressdevs/features/zsda.ini | 6 + > doc/guides/compressdevs/index.rst | 1 + > doc/guid

RE: [EXTERNAL] [PATCH] cryptodev: fix C++ include

2024-12-19 Thread Akhil Goyal
> Some cryptodev functions were not included in the extern "C" block, > so it is moved to start before. > > An include is also moved to avoid being part of this block. > > Fixes: 719834a6849e ("use C linkage where appropriate in headers") > Cc: sta...@dpdk.org > > Reported-by: Zhigang Hu > Sign

RE: [EXTERNAL] Re: [v22,13/13] compress/zsda: add zsda compressdev capabilities

2024-12-05 Thread Akhil Goyal
Hi Hanxiao, > > 2.Should I submit patches based on the latest version as soon as > > possible, or > wait for your comments before submitting? I can review probably next week. You can wait until then. > > > > 3.I think I need to add something to the release_25_03.rst. But I did > > not

RE: [PATCH v2] vhost: include AKCIPHER algorithms in crypto_config

2024-11-19 Thread Akhil Goyal
> Subject: [PATCH v2] vhost: include AKCIPHER algorithms in crypto_config > > Update virtio_crypto_config structure to include AKCIPHER algorithms, > as per VirtIO standard. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Acked-by: Akhil Goyal

RE: [EXTERNAL] [PATCH] crypto/openssl: remove unneccessary null free checks

2024-11-19 Thread Akhil Goyal
> The function EVP_PKEY_CTX_free allows NULL parameter > (similar to free()). > > Signed-off-by: Stephen Hemminger > --- Applied to dpdk-next-crypto Thanks.

RE: [PATCH v1] examples/fips_validation: fix EdDSA signature size

2024-11-19 Thread Akhil Goyal
> > Subject: [PATCH v1] examples/fips_validation: fix EdDSA signature size > > > > Fix EdDSA signature size. > > > > Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA") > > > > Signed-off-by: Gowrishankar Muthukrishnan Applied to dpdk-next-crypto Thanks.

RE: [PATCH v1] examples/fips_validation: prehash input for RSA

2024-11-19 Thread Akhil Goyal
> > Subject: [PATCH v1] examples/fips_validation: prehash input for RSA > > > > Plain text needs to be prehashed for RSA as well in asymmetric crypto > > validation. > > > > Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA") > > > > Signed-off-by: Gowrishankar Muthukrishnan > Acked-by

RE: [EXTERNAL] [PATCH v3] crypto/qat: fix ecdsa session handling

2024-11-06 Thread Akhil Goyal
> Fixed a problem with setting the key in the session in the ECDSA > algorithm. Since the key is being initialized in the session for EC, > it should be reflected in the PMD session initialization function. > > Fixes: badc0c6f6d6a ("cryptodev: set private and public keys in EC session") > Cc: sta.

RE: [EXTERNAL] [PATCH v1] test/crypto: fix synchronous API call

2024-11-06 Thread Akhil Goyal
> For the synchronous API the enqueue/dequeue burst functions are not > called. Skip these tests when calling the synchronous API. > > Fixes: 4ad17a1c8fb3 ("test/crypto: fix enqueue/dequeue callback case") > Cc: sta...@dpdk.org > > Signed-off-by: Brian Dooley Applied to dpdk-next-crypto Thanks.

RE: [PATCH] crypto/scheduler: fix incorrect variable usage

2024-11-06 Thread Akhil Goyal
Hi Kai, Any update on this patch? > > I'm not see any issue with original code, can you give more details about > > crash > so > > I can try to reproduce at my end. > > cc kirill.rybalche...@intel.com for review > > The details are there in Bugzilla > https://bugs.dpdk.org/show_bug.cgi?id=1537

RE: [EXTERNAL] [PATCH 1/4] crypto/dpaa_sec: enhance IPsec extended sequence number

2024-11-06 Thread Akhil Goyal
> From: Gagandeep Singh > > Setting ESN seq number initialization. > Initialize the sequence number of ESP to 1. > > Signed-off-by: Gagandeep Singh > Signed-off-by: Barry Cao > --- Series applied to dpdk-next-crypto Thanks.

RE: [EXTERNAL] [PATCH v2] crypto/qat: fix ecdsa session handling

2024-11-06 Thread Akhil Goyal
> Fixed a problem with setting the key in the session > in the ECDSA alghorithm. Please elaborate what is the problem and what is being done in the patch. > > Fixes: badc0c6f6d6a ("cryptodev: set private and public keys in EC session") > Cc: sta...@dpdk.org > > Signed-off-by: Arkadiusz Kusztal

RE: [EXTERNAL] [PATCH v8 2/3] crypto/qat: add sm2 encryption/decryption function

2024-11-06 Thread Akhil Goyal
> This commit adds SM2 elliptic curve based asymmetric > encryption and decryption to the Intel QuickAssist > Technology PMD. > > Depends-on: patch-147900 ("[v2] crypto/qat: fix ecdsa session handling") > > Signed-off-by: Arkadiusz Kusztal Update qat.ini file also. > --- > doc/guides/rel_note

RE: [EXTERNAL] [PATCH v8 1/3] cryptodev: add ec points to sm2 op

2024-11-06 Thread Akhil Goyal
> In the case when PMD cannot support the full process of the SM2, > but elliptic curve computation only, additional fields > are needed to handle such a case. > > Points C1, kP therefore were added to the SM2 crypto operation struct. > > Signed-off-by: Arkadiusz Kusztal > --- Please rebase. CI

RE: [EXTERNAL] [PATCH] crypto/qat: fix an unset length of modexp/inv

2024-11-06 Thread Akhil Goyal
> This commit fixes an unset length in modular algorithms > in QAT asymmetric crypto PMD. > > Fixes: 3b78aa7b2317 ("crypto/qat: refactor asymmetric crypto functions") > Cc: sta...@dpdk.org > > Signed-off-by: Arkadiusz Kusztal > --- Applied to dpdk-next-crypto Thanks.

RE: [PATCH v3] crypto/ipsec_mb: bump minimum IPsec MB version

2024-11-06 Thread Akhil Goyal
> > > Subject: [PATCH v3] crypto/ipsec_mb: bump minimum IPsec MB version > > > > AESNI_MB SW PMDs increment Intel IPsec MB version to 1.4. > > A minimum IPsec Multi-buffer version of 1.4 or greater is now required for > > the > > 24.11 LTS release. > > > > Signed-off-by: Brian Dooley > > Acked-b

RE: [EXTERNAL] [PATCH] crypto/openssl: fix potential string overflow

2024-11-06 Thread Akhil Goyal
> The algorithm name is a string and should be copied with strlcpy() > rather than rte_memcpy(). This fixes a warning detected with > clang and ASAN. > > Bugzilla ID: 1565 > Fixes: 2b9c693f6ef5 ("crypto/openssl: support AES-CMAC operations") > Cc: asek...@marvell.com > > Signed-off-by: Stephen H

RE: [EXTERNAL] [v3] crypto/dpaa2_sec: rework debug code

2024-11-06 Thread Akhil Goyal
> Move the duplicate code in a common function and > remove un-necessary newline characters from the logs. > > Signed-off-by: Jun Yang > Signed-off-by: Gagandeep Singh > --- Applied to dpdk-next-crypto Thanks.

RE: [EXTERNAL] [PATCH v18 11/15] crypto/zsda: initialize cryptodev of zsda

2024-11-06 Thread Akhil Goyal
> Initialize cryptodev of zsda and add capabilities. > > Signed-off-by: Hanxiao Li > --- > MAINTAINERS | 1 + > doc/guides/cryptodevs/features/zsda.ini | 44 ++ > doc/guides/cryptodevs/zsda.rst | 22 + > doc/guides/rel_notes/release_24_11.rst

[PATCH v6 6/9] raw/cnxk_rvu_lf: support mailbox processing

2024-10-28 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_msg_process() to process mailbox messages between rvu_lf devices. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 8 ++ doc/guides/rel_notes/release_24_11.rst | 5 + drivers/common/cnxk/roc_dev.c| 118

[PATCH v6 9/9] raw/cnxk_rvu_lf: add selftest

2024-10-28 Thread Akhil Goyal
Added raw device selftest for cnxk_rvu_lf to verify various PMD APIs. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 20 +++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c | 2 +- drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.h | 2 + .../raw/cnxk_rvu_lf

[PATCH v6 8/9] raw/cnxk_rvu_lf: support getting BAR addresses

2024-10-28 Thread Akhil Goyal
Added rte_pmd_rvu_lf_bar_get() API to get BAR address for out of tree drivers to configure hardware. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 8 +++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c| 24 drivers/raw/cnxk_rvu_lf

[PATCH v6 7/9] raw/cnxk_rvu_lf: support device pffunc get

2024-10-28 Thread Akhil Goyal
Added ``rte_pmd_rvu_lf_pf_func_get`` API to get RVU LF device pffunc for the application use. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 6 ++ drivers/common/cnxk/roc_rvu_lf.c | 2 +- drivers/common/cnxk/roc_rvu_lf.h | 2

[PATCH v6 5/9] raw/cnxk_rvu_lf: support to set message ID range

2024-10-28 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_msg_id_range_set() to set RVU mailbox message id range from out of tree driver to communicate. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 4 +++ drivers/common/cnxk/roc_mbox.h | 1 + drivers/common/cnxk/roc_rvu_lf.c

[PATCH v6 1/9] drivers/raw: introduce cnxk RVU LF device driver

2024-10-28 Thread Akhil Goyal
mailboxes to each other. Signed-off-by: Akhil Goyal --- MAINTAINERS | 6 ++ doc/guides/platform/cnxk.rst | 5 ++ doc/guides/rawdevs/cnxk_rvu_lf.rst| 30 +++ doc/guides/rawdevs/index.rst | 1 + drivers/common/cnxk/meson.build | 1

[PATCH v6 4/9] raw/cnxk_rvu_lf: support msg handler registration

2024-10-28 Thread Akhil Goyal
Added APIs rte_pmd_rvu_lf_msg_handler_register() and rte_pmd_rvu_lf_msg_handler_unregister() to register/unregister mailbox message handlers. These handlers are needed to fill response at the other side for the request sent from one side. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs

[PATCH v6 3/9] raw/cnxk_rvu_lf: support interrupt callback registration

2024-10-28 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_irq_register() and rte_pmd_rvu_lf_irq_unregister() to register/unregister interrupt handlers for rvu lf raw device. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 9 drivers/common/cnxk/roc_rvu_lf.c | 26

[PATCH v6 0/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-28 Thread Akhil Goyal
v3: - fix internal/external header files. Changes in v2: - removed library patch from series - removed PMD logs from external PMD header. - updated doc/api/doxy-api-index.md - Added release notes Akhil Goyal (9): drivers/raw: introduce cnxk rvu lf device driver raw/cnxk_rvu_lf: support NPA/SSO

[PATCH v6 2/9] raw/cnxk_rvu_lf: support NPA/SSO pffunc get

2024-10-28 Thread Akhil Goyal
Added rte_pmd_rvu_lf_npa_pf_func_get and rte_pmd_rvu_lf_sso_pf_func_get APIs to get NPA and SSO pffunc for the application/external driver use. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 14 ++ drivers/common/cnxk/roc_npa.c| 6 +++ drivers

RE: [EXTERNAL] Re: [PATCH v5 2/9] raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc

2024-10-25 Thread Akhil Goyal
Hi Stephen, > On Thu, 24 Oct 2024 18:47:52 +0530 > Akhil Goyal wrote: > > > +/** > > + * @file cnxk_rvu_lf_driver.h > > + * > > + * Marvell RVU LF raw PMD specific structures and interface > > + * > > + * This API allows external driver/application

RE: [EXTERNAL] [PATCH v15 21/21] crypto/zsda: add functions of cryptodev create and destroy

2024-10-25 Thread Akhil Goyal
> Add functions of cryptodev create and destroy. > > Signed-off-by: Hanxiao Li This patch should be your first crypto driver patch as it does the device initialization. Please update the list that I commented earlier. > --- > drivers/crypto/zsda/zsda_sym_pmd.c | 129 +

RE: [EXTERNAL] [PATCH v15 14/21] crypto/zsda: introduce key expansion code

2024-10-25 Thread Akhil Goyal
> Introduce key expansion code for zsda sym drivers. > > Signed-off-by: Hanxiao Li > --- > drivers/common/zsda/meson.build| 15 +- > drivers/crypto/zsda/zsda_sym_session.c | 281 + > drivers/crypto/zsda/zsda_sym_session.h | 9 + > 3 files changed, 304 insertion

RE: [EXTERNAL] [PATCH v15 01/21] zsda: add zsdadev driver documents

2024-10-25 Thread Akhil Goyal
> Introduce ZTE Storage Data Accelerator(ZSDA) drivers > which can help accelerate storage data process. > > The official product documenttation web page is: > https://enterprise.zte.com.cn/products.html?id=101 > > It is recommended to update MAINTAINERS in the > first patch in the new PMD guidel

RE: [EXTERNAL] [PATCH v15 03/21] common/zsda: add logging macros

2024-10-25 Thread Akhil Goyal
> Add logging macros and functions for zsda drivers > > Signed-off-by: Hanxiao Li > --- > drivers/common/zsda/meson.build | 13 + > drivers/common/zsda/zsda_logs.c | 19 +++ > drivers/common/zsda/zsda_logs.h | 27 +++ > drivers/meson.build

[PATCH v5 4/9] raw/cnxk_rvu_lf: register/unregister msg handler

2024-10-25 Thread Akhil Goyal
Added APIs rte_pmd_rvu_lf_msg_handler_register() and rte_pmd_rvu_lf_msg_handler_unregister() to register/unregister mailbox message handlers. These handlers are needed to fill response at the other side for the request sent from one side. Signed-off-by: Akhil Goyal --- drivers/common/cnxk

[PATCH v5 2/9] raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc

2024-10-25 Thread Akhil Goyal
Added rte_pmd_rvu_lf_npa_pf_func_get and rte_pmd_rvu_lf_sso_pf_func_get APIs to get NPA and SSO pffunc for the application/external driver use. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 7 +++ drivers/common/cnxk/roc_npa.c| 6 +++ drivers

[PATCH v4 7/9] raw/cnxk_rvu_lf: add API to get device pffunc

2024-10-25 Thread Akhil Goyal
Added ``rte_pmd_rvu_lf_pf_func_get`` API to get RVU LF device pffunc for the application use. Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_rvu_lf.c | 2 +- drivers/common/cnxk/roc_rvu_lf.h | 2 ++ drivers/common/cnxk/version.map | 1 + drivers

[PATCH v4 6/9] raw/cnxk_rvu_lf: process mailbox message

2024-10-25 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_msg_process() to process mailbox messages between rvu_lf devices. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 8 ++ doc/guides/rel_notes/release_24_11.rst | 5 + drivers/common/cnxk/roc_dev.c| 118

[PATCH v4 0/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-25 Thread Akhil Goyal
- removed PMD logs from external PMD header. - updated doc/api/doxy-api-index.md - Added release notes Akhil Goyal (9): drivers/raw: introduce cnxk rvu lf device driver raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc raw/cnxk_rvu_lf: register/unregister interrupt handler raw/cnxk_rvu_lf: register

RE: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-25 Thread Akhil Goyal
> 23/10/2024 21:14, Akhil Goyal: > > > 22/10/2024 14:06, Akhil Goyal: > > > > > On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal > wrote: > > > > > > > The rational to NOT pull "Hardware abstraction library using the > > > > > >

[PATCH v4 4/9] raw/cnxk_rvu_lf: register/unregister msg handler

2024-10-25 Thread Akhil Goyal
Added APIs rte_pmd_rvu_lf_msg_handler_register() and rte_pmd_rvu_lf_msg_handler_unregister() to register/unregister mailbox message handlers. These handlers are needed to fill response at the other side for the request sent from one side. Signed-off-by: Akhil Goyal --- drivers/common/cnxk

[PATCH v5 7/9] raw/cnxk_rvu_lf: add API to get device pffunc

2024-10-24 Thread Akhil Goyal
Added ``rte_pmd_rvu_lf_pf_func_get`` API to get RVU LF device pffunc for the application use. Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_rvu_lf.c | 2 +- drivers/common/cnxk/roc_rvu_lf.h | 2 ++ drivers/common/cnxk/version.map | 1 + drivers

[PATCH v5 0/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-24 Thread Akhil Goyal
: - removed library patch from series - removed PMD logs from external PMD header. - updated doc/api/doxy-api-index.md - Added release notes Akhil Goyal (9): drivers/raw: introduce cnxk rvu lf device driver raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc raw/cnxk_rvu_lf: register/unregister interrupt

[PATCH v5 9/9] raw/cnxk_rvu_lf: add selftest

2024-10-24 Thread Akhil Goyal
Added raw device selftest for cnxk_rvu_lf to verify various PMD APIs. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 18 ++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c | 4 +- drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.h | 2 + .../raw/cnxk_rvu_lf

[PATCH v5 1/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-24 Thread Akhil Goyal
mailboxes to each other. Signed-off-by: Akhil Goyal --- MAINTAINERS | 6 ++ doc/guides/rawdevs/cnxk_rvu_lf.rst| 40 + doc/guides/rawdevs/index.rst | 1 + drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3

[PATCH v4 1/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-24 Thread Akhil Goyal
mailboxes to each other. Signed-off-by: Akhil Goyal --- MAINTAINERS | 6 ++ doc/guides/rawdevs/cnxk_rvu_lf.rst| 40 + doc/guides/rawdevs/index.rst | 1 + drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3

[PATCH v5 8/9] raw/cnxk_rvu_lf: add API to get BAR addresses

2024-10-24 Thread Akhil Goyal
Added rte_pmd_rvu_lf_bar_get() API to get BAR address for application to configure hardware. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 7 ++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c| 24 drivers/raw/cnxk_rvu_lf

[PATCH v5 6/9] raw/cnxk_rvu_lf: process mailbox message

2024-10-24 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_msg_process() to process mailbox messages between rvu_lf devices. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 8 ++ doc/guides/rel_notes/release_24_11.rst | 5 + drivers/common/cnxk/roc_dev.c| 118

[PATCH v5 3/9] raw/cnxk_rvu_lf: register/unregister interrupt handler

2024-10-24 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_irq_register() and rte_pmd_rvu_lf_irq_unregister() to register/unregister interrupt handlers for rvu lf raw device. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 8 drivers/common/cnxk/roc_rvu_lf.c | 26

[PATCH v5 5/9] raw/cnxk_rvu_lf: set message ID range

2024-10-24 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_msg_id_range_set() to set RVU mailbox message id range. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 12 drivers/common/cnxk/roc_mbox.h | 1 + drivers/common/cnxk/roc_rvu_lf.c | 30

[PATCH v4 8/9] raw/cnxk_rvu_lf: add API to get BAR addresses

2024-10-24 Thread Akhil Goyal
Added rte_pmd_rvu_lf_bar_get() API to get BAR address for application to configure hardware. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 7 ++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c| 24 drivers/raw/cnxk_rvu_lf

[PATCH v4 9/9] raw/cnxk_rvu_lf: add selftest

2024-10-24 Thread Akhil Goyal
Added raw device selftest for cnxk_rvu_lf to verify various PMD APIs. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 18 ++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c | 4 +- drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.h | 2 + .../raw/cnxk_rvu_lf

[PATCH v4 5/9] raw/cnxk_rvu_lf: set message ID range

2024-10-24 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_msg_id_range_set() to set RVU mailbox message id range. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 12 drivers/common/cnxk/roc_mbox.h | 1 + drivers/common/cnxk/roc_rvu_lf.c | 30

[PATCH v4 3/9] raw/cnxk_rvu_lf: register/unregister interrupt handler

2024-10-24 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_irq_register() and rte_pmd_rvu_lf_irq_unregister() to register/unregister interrupt handlers for rvu lf raw device. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 8 drivers/common/cnxk/roc_rvu_lf.c | 26

[PATCH v4 2/9] raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc

2024-10-24 Thread Akhil Goyal
Added rte_pmd_rvu_lf_npa_pf_func_get and rte_pmd_rvu_lf_sso_pf_func_get APIs to get NPA and SSO pffunc for the application/external driver use. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 7 +++ drivers/common/cnxk/roc_npa.c| 6 +++ drivers

RE: [EXTERNAL] [PATCH v7 2/3] crypto/qat: add sm2 encryption/decryption function

2024-10-24 Thread Akhil Goyal
> This commit adds SM2 elliptic curve based asymmetric > encryption and decryption to the Intel QuickAssist > Technology PMD. > > Signed-off-by: Arkadiusz Kusztal > --- You are again not using that capability flag RTE_CRYPTO_SM2_PARTIAL I thought you would add that by RC2. Also check asymmetric

RE: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-23 Thread Akhil Goyal
> 22/10/2024 14:06, Akhil Goyal: > > > On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > > > > The rational to NOT pull "Hardware abstraction library using the BAR > > > > > address" to DPDK are > > > > > -Yet another 200

RE: [EXTERNAL] [PATCH v6 2/3] crypto/qat: add sm2 encryption/decryption function

2024-10-23 Thread Akhil Goyal
> This commit adds SM2 elliptic curve based asymmetric > encryption and decryption to the Intel QuickAssist > Technology PMD. > > Signed-off-by: Arkadiusz Kusztal > --- > doc/guides/cryptodevs/features/qat.ini| 1 + > doc/guides/rel_notes/release_24_11.rst| 4 + > .../common/

RE: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-22 Thread Akhil Goyal
> On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > > The rational to NOT pull "Hardware abstraction library using the BAR > > > address" to DPDK are > > > -Yet another 200K of driver C++ code which does not make sense to keep > > > in

RE: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-21 Thread Akhil Goyal
> On Tue, Oct 22, 2024 at 3:00 AM Thomas Monjalon > wrote: > > > > 08/10/2024 20:49, Akhil Goyal: > > > Added rte_pmd_rvu_lf_bar_get() API to get BAR address > > > for application to configure hardware. > > > > In my opinion, we should not return PC

RE: [EXTERNAL] Re: [PATCH v2] rawdev: add API to get device from index

2024-10-21 Thread Akhil Goyal
> Subject: RE: [EXTERNAL] Re: [PATCH v2] rawdev: add API to get device from > index > > > > > diff --git a/lib/rawdev/rte_rawdev_pmd.h b/lib/rawdev/rte_rawdev_pmd.h > > > > index 22b406444d..8339122348 100644 > > > > --- a/lib/rawdev/rte_rawdev_pmd.h > > > > +++ b/lib/rawdev/rte_rawdev_pmd.h > >

RE: [EXTERNAL] [PATCH v5 2/4] cryptodev: add ec points to sm2 op

2024-10-18 Thread Akhil Goyal
> > > > -Original Message- > > From: Akhil Goyal > > Sent: Friday, October 11, 2024 2:18 PM > > To: Kusztal, ArkadiuszX ; dev@dpdk.org > > Cc: Dooley, Brian > > Subject: RE: [EXTERNAL] [PATCH v5 2/4] cryptodev: add ec points to sm2 op > &g

RE: [EXTERNAL] [PATCH v1 0/2] cryptodev: add SM4-XTS algo and test cases

2024-10-11 Thread Akhil Goyal
> v1: > - add SM4-XTS algo and test cases. > > Signed-off-by: Hanxiao Li > > --- > Hanxiao Li (2): > cryptodev: add SM4-XTS > app/test: add SM4-XTS test cases > > app/test/test_cryptodev_blockcipher.c | 3 +- > app/test/test_cryptodev_sm4_test_vectors.h | 58 ++ >

RE: [EXTERNAL] [PATCH v1 1/2] cryptodev: add SM4-XTS

2024-10-11 Thread Akhil Goyal
| 3 ++- > 4 files changed, 10 insertions(+), 2 deletions(-) Acked-by: Akhil Goyal

RE: [EXTERNAL] [PATCH v5 2/4] cryptodev: add ec points to sm2 op

2024-10-11 Thread Akhil Goyal
> In the case when PMD cannot support the full process of the SM2, > but elliptic curve computation only, additional fields > are needed to handle such a case. > > Points C1, kP therefore were added to the SM2 crypto operation struct. > > Signed-off-by: Arkadiusz Kusztal > --- > lib/cryptodev/r

RE: [EXTERNAL] [PATCH v5 4/4] app/test: add test sm2 C1/Kp test cases

2024-10-11 Thread Akhil Goyal
> This commit adds tests cases to be used when C1 or kP elliptic > curve points need to be computed. > > Signed-off-by: Arkadiusz Kusztal > --- > app/test/test_cryptodev_asym.c | 138 > - > app/test/test_cryptodev_sm2_test_vectors.h | 112 +

RE: [EXTERNAL] Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-10-09 Thread Akhil Goyal
> >>> Now added inline APIs for getting the list end which need to be updated > >>> for each new entry to the enum. This shall help in avoiding ABI break > >>> for adding new algo. > >>> > >> > >> Hi Akhil, > >> > >> *I think* this hides the problem instead of fixing it, and this may be > >> partia

RE: [EXTERNAL] Re: [PATCH v2] rawdev: add API to get device from index

2024-10-09 Thread Akhil Goyal
> > > diff --git a/lib/rawdev/rte_rawdev_pmd.h b/lib/rawdev/rte_rawdev_pmd.h > > > index 22b406444d..8339122348 100644 > > > --- a/lib/rawdev/rte_rawdev_pmd.h > > > +++ b/lib/rawdev/rte_rawdev_pmd.h > > > @@ -102,6 +102,30 @@ rte_rawdev_pmd_get_named_dev(const char > *name) > > > return NUL

RE: [EXTERNAL] [PATCH v8 6/8] lib/cryptodev: add sm4 xts for crypto

2024-10-09 Thread Akhil Goyal
> Title should be cryptodev: add SM4-XTS > > > add support of sm4 xts . > > > > Signed-off-by: Hanxiao Li > > Send this patch (along with test cases) as a separate patchset "not included > in this > series." > > Update documentation doc/guides/cryptodevs/features/defaults.ini > Update release

RE: [EXTERNAL] [PATCH v5 1/4] cryptodev: reorder structures in asym crypto header

2024-10-09 Thread Akhil Goyal
ned-off-by: Arkadiusz Kusztal > --- Acked-by: Akhil Goyal This patch is applied to dpdk-next-crypto Please send the next version for rest of the patches in the series.

RE: [EXTERNAL] [v2] crypto/dpaa2_sec: rework debug code

2024-10-09 Thread Akhil Goyal
Hi Gagan, > Output debug information according to various modes. > > Signed-off-by: Jun Yang > Signed-off-by: Gagandeep Singh It seems the base patch was merged in main branch. Can you rebase this patch on current top of tree? > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 72

RE: [EXTERNAL] [PATCH v5 2/4] cryptodev: add ec points to sm2 op

2024-10-09 Thread Akhil Goyal
> In the case when PMD cannot support the full process of the SM2, > but elliptic curve computation only, additional fields > are needed to handle such a case. > > Points C1, kP therefore were added to the SM2 crypto operation struct. > > Signed-off-by: Arkadiusz Kusztal > --- > lib/cryptodev/r

RE: [EXTERNAL] [PATCH v5 3/4] crypto/qat: add sm2 encryption/decryption function

2024-10-09 Thread Akhil Goyal
> This commit adds SM2 elliptic curve based asymmetric > encryption and decryption to the Intel QuickAssist > Technology PMD. > > Signed-off-by: Arkadiusz Kusztal > --- > doc/guides/cryptodevs/features/qat.ini | 1 + > doc/guides/rel_notes/release_24_11.rst | 4 + > drivers

RE: [PATCH] cryptodev: remove unnecessary list end

2024-10-09 Thread Akhil Goyal
> > From: Akhil Goyal [mailto:gak...@marvell.com] > > Sent: Wednesday, 9 October 2024 13.25 > > > > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END and > > RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END are not used anywhere and > > mostly it do not fulfil any objective. > >

RE: [PATCH v3 1/3] cryptodev: add asymmetric operational capability

2024-10-09 Thread Akhil Goyal
ukrishnan > --- > v3: > - Removed unused rte_crypto_sm2_op_capa enum value > RTE_CRYPTO_SM2_PKE_KDF. >HW that needs it can add this enum. > - Test and driver changes split from it and follows within same series. Series acked-by: Akhil Goyal Arek's ack taken from v2. Updat

RE: [PATCH v4 1/2] ipsec: allow stateless IPsec processing

2024-10-09 Thread Akhil Goyal
_outb.c | 101 + > > lib/ipsec/rte_ipsec.h | 84 > > lib/ipsec/sa.c | 4 +- > > lib/ipsec/sa.h | 8 ++ > > 6 files changed, 176 insertions(+), 33 deletions

RE: [EXTERNAL] Re: [PATCH v1] Revert "doc: extension of crypto event callback announced"

2024-10-09 Thread Akhil Goyal
Signed-off-by: Srujana Challa > > Acked-by: Stephen Hemminger Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [PATCH v2 2/2] cryptodev: move RSA padding information into xform

2024-10-09 Thread Akhil Goyal
> Acked-by: Arek Kusztal > Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto Updated release notes and removed associated deprecation notices. Thanks.

RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-10-09 Thread Akhil Goyal
> > Subject: RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm > > > > > Acked-by: Arkadiusz Kusztal Series Applied to dpdk-next-crypto Thanks. Updated release notes and removed deprecation notices for EDDSA.

RE: [EXTERNAL] Re: [PATCH v3 1/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-09 Thread Akhil Goyal
> On Wed, 9 Oct 2024 00:19:07 +0530 > Akhil Goyal wrote: > > > CNXK product families can have a use case to allow PF and VF > > applications to communicate using mailboxes and also get notified > > of any interrupt that may occur on the device. > > Hence, a n

RE: [PATCH v4 1/2] ipsec: allow stateless IPsec processing

2024-10-09 Thread Akhil Goyal
Hi Konstantin, Can you ack this patch if everything is fine? > Subject: [PATCH v4 1/2] ipsec: allow stateless IPsec processing > > Introduce stateless packet preparation API for IPsec > processing. The new API would allow preparation of IPsec > packets without altering the internal state of an I

RE: [PATCH v2 2/2] cryptodev: move RSA padding information into xform

2024-10-09 Thread Akhil Goyal
Hi Arek Any objections on this patch? > Subject: [PATCH v2 2/2] cryptodev: move RSA padding information into xform > > RSA padding information could be a xform entity rather than part of > crypto op, as it seems associated with hashing algorithm used for > the entire crypto session, where this al

RE: [PATCH v3 1/3] crypto/ipsec_mb: add SM3 algorithm support

2024-10-09 Thread Akhil Goyal
> > -Original Message- > > From: Dooley, Brian > > Sent: Thursday, October 3, 2024 6:05 PM > > To: Ji, Kai ; De Lara Guarch, Pablo > > > > Cc: dev@dpdk.org; gak...@marvell.com; Dooley, Brian > > > > Subject: [PATCH v3 1/3] crypto/ipsec_mb: add SM3 algorithm support > > > > This patch int

RE: [PATCH] test/security: skip IPsec post process for negative tests

2024-10-09 Thread Akhil Goyal
> Subject: [PATCH] test/security: skip IPsec post process for negative tests > > Skips calling test_ipsec_post_process for negative inline IPsec tests > as received packet might not be valid for a negative case. > > Signed-off-by: Srujana Challa Acked-by: Akhil Goyal Ap

RE: [PATCH] examples/l2fwd-macsec: enable extended packet number

2024-10-09 Thread Akhil Goyal
> -Original Message- > From: Akhil Goyal > Sent: Monday, September 16, 2024 4:57 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; Vamsi Krishna > Attunuru ; Akhil Goyal > Subject: [PATCH] examples/l2fwd-macsec: enable extended packet nu

RE: [PATCH v2] examples/ipsec-secgw: fix dequeue count from cryptodev

2024-10-09 Thread Akhil Goyal
; vectors") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Tejasree Kondoj > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

  1   2   3   4   5   6   7   8   9   10   >