[PATCH v2 2/2] net/bonding: fix slaves initializing on mtu setting

2022-02-15 Thread Wan Junjie
the slave device "Port 0 must be configured before MTU set" Test can be reproduced with ovs. Fixes: b26bee1 ("ethdev: forbid MTU set before device configure") Signed-off-by: Wan Junjie --- v2: fix typo in commit add reproduce procedure --- app/test/test_link_bonding.

[PATCH v2 1/2] net/bonding: add error hint for invalid args

2022-02-15 Thread Wan Junjie
When invalid args exist, application exits with no error hint. Adding a log message here will help users to know the reason. Signed-off-by: Wan Junjie --- v2: fix typo in commit msg --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

Re: [External] Re: [PATCH 2/2] net/bonding: fix slaves initilizing on mtu setting

2022-02-15 Thread Wan Junjie
slave device, that "Port 0 must be configured before MTU set" Will add it to commit msg in v2 Regards, Wan Junjie > Thanks. > > 在 2022/2/14 16:13, Wan Junjie 写道: > > When initializing a bonding device with all slaves in vdev string, > > which means bonding device init

Re: [External] Re: [PATCH 1/2] net/bonding: add error hint for invald args

2022-02-15 Thread Wan Junjie
Hi Min Hu, Thanks for the reply Will fix it in v2. Regards, Wan Junjie On Tue, Feb 15, 2022 at 5:12 PM Min Hu (Connor) wrote: > > Hi, wan, > The headline has spelling errors. > > 在 2022/2/14 16:13, Wan Junjie 写道: > > When invalid args exsit, application exi

[PATCH 2/2] net/bonding: fix slaves initilizing on mtu setting

2022-02-14 Thread Wan Junjie
evice configure") Signed-off-by: Wan Junjie --- app/test/test_link_bonding.c | 4 +++ app/test/test_link_bonding_rssconf.c | 4 +++ drivers/net/bonding/eth_bond_private.h | 4 +++ drivers/net/bonding/rte_eth_bond_api.c | 6 drivers/net/bonding/rte_eth_bond_

[PATCH 1/2] net/bonding: add error hint for invald args

2022-02-14 Thread Wan Junjie
When invalid args exsit, application exits with no error hint. Adding a log message here will help users to know the reson. Signed-off-by: Wan Junjie --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding

Re: [dpdk-dev] [External] RE: [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled

2021-05-13 Thread Wan Junjie
On Thu, May 13, 2021 at 6:24 PM Xia, Chenbo wrote: > > > -Original Message- > > From: David Marchand > > Sent: Thursday, May 13, 2021 4:39 PM > > To: Xia, Chenbo ; Maxime Coquelin > > > > Cc: Wan Junjie ; dev@dpdk.org; Peng He > > ; Zhihon

[dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled

2021-02-02 Thread Wan Junjie
If vhost device's IOMMU feature is disabled, iotlb mempool allocation is unnecessary. Reported-by: Peng He Signed-off-by: Wan Junjie Reviewed-by: Zhihong Wang --- lib/librte_vhost/vhost.c | 4 ++-- lib/librte_vhost/vhost_user.c | 6 +- 2 files changed, 7 insertions(+), 3 dele

[dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled

2021-02-02 Thread Wan Junjie
If vhost device's IOMMU feature is disabled, iotlb mempool allocation is unnecessary. Reported-by: Peng He Signed-off-by: Wan Junjie Reviewed-by: Zhihong Wang --- lib/librte_vhost/vhost.c | 4 ++-- lib/librte_vhost/vhost_user.c | 6 +- 2 files changed, 7 insertions(+), 3 dele

[dpdk-dev] [PATCH] vhost: avoid iotlb mempool allocation while IOMMU disabled

2021-01-29 Thread Wan Junjie
If vhost device's IOMMU feature is disabled, iotlb mempool allocation is unnecessary. Reported-by: Peng He Signed-off-by: Wan Junjie Reviewed-by: Zhihong Wang --- lib/librte_vhost/vhost.c | 6 -- lib/librte_vhost/vhost_user.c | 2 +- 2 files changed, 5 insertions(+), 3 dele

Re: [dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

2019-02-28 Thread Wan Junjie
Bitratestats test fails even without my patch. The reason is that metrics lib has no de-init process. Harman Kalra has submited a patch for this. Check https://patches.dpdk.org/patch/50451 As for metrics lib, the array block of metadata may be better on cache side. Since rte_metrics_update_va