On Tue, Feb 25, 2020 at 12:44:48PM -0800, Yifeng Sun wrote:
> >
> > +int rte_vhost_get_kickfd(int vid, uint16_t queue_id)
Introducing rte_vhost_get_kickfd() may not help much, we already
have rte_vhost_get_vhost_vring() to do that.
https://github.com/DPDK/dpdk/blob/d7142fbae16f/drivers/net/vhost/
On Tue, Feb 25, 2020 at 06:51:52PM +0100, Maxime Coquelin wrote:
> On 2/21/20 2:28 PM, Tiwei Bie wrote:
> > I'm leaving Intel, and I'm not sure when I could dedicate enough
> > time to DPDK in the future. So I'm removing my name from the
> > MAINTAINERS fil
On Fri, Feb 21, 2020 at 07:29:13PM +0100, Thomas Monjalon wrote:
> 20/02/2020 03:52, Tiwei Bie:
> > On Wed, Feb 19, 2020 at 11:39:22AM +0100, Thomas Monjalon wrote:
> > > The macros RTE_MIN and RTE_MAX can be used in DPDK applications.
>
> Only RTE_MIN is used in this patc
> Subject: [PATCH] maintainers: resign from virtio and vhost
> >
> > I'm leaving Intel, and I'm not sure when I could dedicate enough
> > time to DPDK in the future. So I'm removing my name from the
> > MAINTAINERS file.
> >
> > Signed-off
n virtio and
vhost with your expertise and passion.
Acked-by: Tiwei Bie
Thanks,
Tiwei
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9c22c3eb4..8e5d18235 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -855,6 +855,7 @@ F: doc/guides/nics/features/vmxnet3.ini
>
On Fri, Feb 21, 2020 at 02:34:42PM +0100, Thomas Monjalon wrote:
> 21/02/2020 14:28, Tiwei Bie:
> > I'm leaving Intel, and I'm not sure when I could dedicate enough
> > time to DPDK in the future. So I'm removing my name from the
> > MAINTAINERS fil
I'm leaving Intel, and I'm not sure when I could dedicate enough
time to DPDK in the future. So I'm removing my name from the
MAINTAINERS file.
Signed-off-by: Tiwei Bie
---
Xiaolong has been an active and experienced -next tree maintainer
for a long time. He also knows and loves
> examples/vhost_blk/blk.c | 4 ++--
> examples/vhost_blk/vhost_blk.h| 2 --
> examples/vhost_blk/vhost_blk_compat.c | 2 +-
> 3 files changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Tiwei Bie
Thanks,
Tiwei
ady been done. */
> + list = find_internal_resource(internal->iface_name);
> + if (list)
> + return 0;
> +
> list = rte_zmalloc_socket(name, sizeof(*list), 0, numa_node);
> if (list == NULL)
> return -1;
> --
> 2.24.1
Thanks
ned-off-by: Maxime Coquelin
> Reviewed-by: David Marchand
> ---
> drivers/net/vhost/rte_eth_vhost.c | 21 ++---
> 1 file changed, 14 insertions(+), 7 deletions(-)
Reviewed-by: Tiwei Bie
Thanks,
Tiwei
On Wed, Feb 12, 2020 at 11:40:40AM +0100, Maxime Coquelin wrote:
> On 2/12/20 11:35 AM, Tiwei Bie wrote:
> > On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote:
> >> Some applications like pktgen use link_speed to calculate
> >> transmit rate. It limits outco
On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote:
> Some applications like pktgen use link_speed to calculate
> transmit rate. It limits outcome traffic to hardcoded 10G.
>
> This patch adds link_speed devarg which allows to configure
> link_speed of virtio device.
>
> Signed-off-by: I
t/vhost_user.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Tiwei Bie
Thanks!
Tiwei
cvmsg() so that
> misleading error message is not printed when the code is 0.
Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Cc: sta...@dpdk.org
>
> Signed-off-by: Vitaliy Mysak
> ---
> lib/librte_vhost/socket.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Tiwei Bie
Thanks,
Tiwei
setup for packed queues")
> Cc: y...@fridaylinux.org
> Cc: sta...@dpdk.org
>
> Signed-off-by: Adrian Moreno
> ---
> lib/librte_vhost/vhost_user.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Tiwei Bie
Thanks,
Tiwei
Add missing braces to avoid resetting virtqueues unconditionally
during reconnection.
Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
Signed-off-by: Tiwei Bie
---
Cc: Xuan Ding
drivers/net/virtio/virtio_user_ethdev.c | 3 ++-
1 file changed, 2 insertions(+),
On Thu, Jan 16, 2020 at 11:44:44AM +0100, Maxime Coquelin wrote:
> This patch adds a check to ensure the read size of
> the Vhost-user message header is not smaller than
> the expected size.
>
> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> Cc: sta...@dpdk.org
>
> Reported-by: Ilja Van Spru
"or alignment (0x%" PRIx64 ") is
> invalid\n",
> + reg->size + mmap_offset, alignment);
> + goto err_mmap;
> + }
>
> populate = (dev->dequeue_zero_copy) ? MAP_POPULATE : 0;
> mmap_addr = mmap(NULL, mmap_size, PROT_READ | PROT_WRITE,
> --
> 2.21.0
Reviewed-by: Tiwei Bie
+++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
Reviewed-by: Tiwei Bie
5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Tiwei Bie
On Wed, Dec 25, 2019 at 10:24:45PM +0800, Jin Yu wrote:
> Add VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD check in
> getting inflight ring functions.
>
> Fixes: 4d891f77ddfa ("vhost: add APIs to get inflight ring")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jin Yu
> ---
> lib/librte_vhost/vhost.c | 8 ++
On Thu, Jan 09, 2020 at 08:18:24PM +0800, Yunjian Wang wrote:
> The function vhost_kernel_tap_set_offload() could return errors,
> the return value need to be checked. And there is no need to fail
> when error is -ENOTSUP.
>
> Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before
On Wed, Jan 08, 2020 at 10:42:48AM +, Matan Azrad wrote:
> Hi all
>
> Thanks very much for the review.
> Please see below.
>
> From: Andrew Rybchenko
> > On 1/8/20 8:28 AM, Tiwei Bie wrote:
> > > On Tue, Jan 07, 2020 at 06:39:36PM +0100, Maxime Coquelin
On Tue, Jan 07, 2020 at 06:39:36PM +0100, Maxime Coquelin wrote:
> On 12/25/19 4:19 PM, Matan Azrad wrote:
> > Add vDPA devices features table and explanation.
> >
> > Any vDPA driver can add its own supported features by ading a new ini
> > file to the features directory in doc/guides/vdpadevs/fe
ff-by: Yunjian Wang
> ---
> v3:
> * Add newline at the end of the error message
> v2:
> * Change function eth_dev_vhost_create return 0 on success
> ---
> drivers/net/vhost/rte_eth_vhost.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Tiwei Bie
->device.numa_node, flags, disable_flags);
> + if (ret == -1)
> + VHOST_LOG(ERR, "Failed to create %s", name);
A newline is needed at the end of the error message.
Other than that,
Reviewed-by: Tiwei Bie
dk.org
>
> Signed-off-by: Xiao Wang
> ---
> lib/librte_vhost/socket.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Tiwei Bie
")
> Cc: jianfeng@intel.com
> Cc: sta...@dpdk.org
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Tiwei Bie
On Fri, Dec 20, 2019 at 11:09:50AM +0800, Gavin Hu wrote:
> Other than real PCI reads and writes to the device memory requiring
> the io barriers, virtual pci memories are normal memory in the smp
> configuration, which requires the smp barriers.
>
> Since the smp barriers and io barriers are iden
On Thu, Dec 19, 2019 at 04:54:06PM +0800, Li Feng wrote:
> This msg is used to notify qemu that should get the config of backend.
>
> For example, vhost-user-blk uses this msg to notify guest os the
> capacity of backend has changed.
>
> The need_reply flag is not mandatory because it will block
On Mon, Dec 16, 2019 at 06:38:28AM +, wangyunjian wrote:
> > -Original Message-
> > From: Tiwei Bie [mailto:tiwei@intel.com]
> > Sent: Monday, December 16, 2019 1:33 PM
> > To: wangyunjian
> > Cc: dev@dpdk.org; maxime.coque...@redhat.com; zhihong.w...
On Fri, Dec 13, 2019 at 08:39:11PM +0300, Ivan Dyukov wrote:
> Hi Maxime,
> Thank you for comments.
>
>
> 13.12.2019 17:59, Maxime Coquelin пишет:
> > Hi Ivan,
> >
> > On 12/13/19 3:44 PM, Ivan Dyukov wrote:
> >> Some applications like pktgen use link_speed to calculate transmit
> >> rate. It lim
) will be compiled out.
>
> Signed-off-by: Adrian Moreno
Acked-by: Tiwei Bie
On Mon, Dec 16, 2019 at 09:03:15AM +0800, Yunjian Wang wrote:
> The function vhost_kernel_tap_set_offload() could return errors,
> the return value need to be checked.
>
> Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Yunjia
On Mon, Dec 16, 2019 at 09:05:59AM +0800, Yunjian Wang wrote:
> The function eth_dev_vhost_create() could return errors,
> the return value need to be checked.
>
> Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Yunjian Wang
> ---
> drive
On Thu, Dec 05, 2019 at 01:38:33PM +0800, Li Feng wrote:
> This msg is used to notify qemu that should get the config of backend.
>
> For example, vhost-user-blk uses this msg to notify guest os the
> compacity of backend has changed.
capacity?
>
> Signed-off-by: Li Feng
> ---
> v3:
> * Move t
On Tue, Dec 10, 2019 at 09:00:33AM +0100, Thomas Monjalon wrote:
> 10/12/2019 03:41, Tiwei Bie:
> > On Mon, Dec 09, 2019 at 02:22:27PM +0300, Andrew Rybchenko wrote:
> > > On 12/9/19 1:41 PM, Ori Kam wrote:
> > > > From: Andrew Rybchenko
> > > &g
On Mon, Dec 09, 2019 at 02:22:27PM +0300, Andrew Rybchenko wrote:
> On 12/9/19 1:41 PM, Ori Kam wrote:
> > Hi
> >
> >> -Original Message-
> >> From: dev On Behalf Of Andrew Rybchenko
> >> Sent: Monday, December 9, 2019 9:44 AM
> >> To: Matan Azrad ; Liang, Cunming
> >> ; Bie, Tiwei
> >>
On Fri, Dec 06, 2019 at 11:04:43AM +0100, Maxime Coquelin wrote:
> On 12/6/19 10:05 AM, Andrew Rybchenko wrote:
> > On 12/6/19 8:32 AM, Liang, Cunming wrote:
> >>> -Original Message-
> >>> From: Bie, Tiwei
> >>> Sent: Friday, December 6, 2019 12:28 PM
> >>> To: Matan Azrad
> >>> Cc: Wang,
On Thu, Dec 05, 2019 at 01:26:36PM +, Matan Azrad wrote:
> Hi all
>
> As described in RFC “[RFC] net: new vdpa PMD for Mellanox devices”, a new vdpa
> drivers is going to be added for Mellanox devices – mlx5_vdpa
>
> The only vdpa driver now is the IFC driver that is located in net directory.
On Thu, Dec 05, 2019 at 12:01:55PM +0800, Li Feng wrote:
> Tiwei Bie 于2019年12月5日周四 上午10:06写道：
> > On Wed, Dec 04, 2019 at 05:43:50PM +0800, Li Feng wrote:
> > > Hi Tiwei,
> > > Thanks for your reply.
> > > Yes, this new API currently is for vhost-user-bl
ich is an internal header. And the symbol
should be added to rte_vhost_version.map as well.
>
> There is a patch in SPDK to use this API.
Could you share the link to the SPDK patch?
Thanks,
Tiwei
>
> Thanks,
>
> Feng Li
>
> Tiwei Bie 于2019年12月4日周三 下午5:30写道：
> >
>
On Wed, Dec 04, 2019 at 01:13:20PM +0800, Li Feng wrote:
> This msg is used to notify qemu that should get the config of backend.
>
> For example, vhost-user-blk uses this msg to notify guest os the
> compacity of backend has changed.
>
> Signed-off-by: Li Feng
> ---
> v2:
> * Fix a little log t
| 1 +
> .../virtio_paths_selection_and_usage.rst | 126 ++
> 2 files changed, 127 insertions(+)
> create mode 100644 doc/guides/howto/virtio_paths_selection_and_usage.rst
Acked-by: Tiwei Bie
On Tue, Nov 26, 2019 at 11:08:14AM -0500, Yinan wrote:
> From: Wang Yinan
>
> add virtio paths selection and usage introduction for better
s/add/Add/
> virtio usability.
>
> Signed-off-by: Wang Yinan
> ---
> doc/guides/howto/index.rst| 1 +
> .../virtio_paths_selection_
Hi Yinan,
Thanks for the work! Will take a closer look ASAP.
Please see some quick comments inline.
On Tue, Nov 26, 2019 at 05:42:38AM -0500, Yinan wrote:
> From: Wang Yinan
>
> add virtio paths selection and usage introduction for better
> virtio usability.
>
> Signed-off-by: Wang Yinan
>
Do not close the tap fds when disabling queue pairs, instead,
we just need to unbind the backend. Otherwise, tap port can be
destroyed unexpectedly.
Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
Cc: sta...@dpdk.org
Reported-by: Stephen Hemminger
Signed-off-by: Tiwei B
On Tue, Nov 19, 2019 at 08:36:38AM -0800, Stephen Hemminger wrote:
> On Tue, 19 Nov 2019 14:29:48 +0800
> Tiwei Bie wrote:
>
> > -static int
> > +int
> > +vhost_kernel_tap_attach_queue(int fd)
> > +{
> > + struct ifreq ifr;
> > +
> > +
backs for external memory")
Cc: sta...@dpdk.org
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c
b/drivers/net/virtio/virtio_user/vir
Do not close the tap fds when disabling queue pairs, instead,
we just need to unbind the backend. Otherwise, tap port can be
destroyed unexpectedly.
Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
Cc: sta...@dpdk.org
Reported-by: Stephen Hemminger
Signed-off-by:
g FDs")
> > Signed-off-by: Zhike Wang
> > ---
> > lib/librte_vhost/vhost_user.c | 13 ++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
> >
>
> otherwise:
>
> Reviewed-by: Maxime Coquelin
>
> The title can be changed while applying if you agree with it, no need to
> send v3.
>
> I'll take care of the different backports.
>
Reviewed-by: Tiwei Bie
Thanks!
Tiwei
On Tue, Nov 12, 2019 at 09:23:31AM -0800, Stephen Hemminger wrote:
> Since Linux kernel is going to drop support for iopl real soon now.
> Is there any ongoing effort to either drop Legacy virtio support,
I think it's not a good idea to drop the legacy virtio
support at present.
> or replace iop
On Fri, Nov 08, 2019 at 03:44:07PM -0800, Stephen Hemminger wrote:
> When I create a virtio-user device with rte_hotplug it creates a kernel
> device (ie vtap0).
> This is normal an the device has ifindex N.
>
> But later when device is configured an started the original vtap0 device is
> delete
> Cc: sta...@dpdk.org
>
> Signed-off-by: Marvin Liu
> ---
> lib/librte_vhost/vhost_user.c | 14 +-
> 1 file changed, 13 insertions(+), 1 deletion(-)
Reviewed-by: Tiwei Bie
> Cc: sta...@dpdk.org
>
> Signed-off-by: Marvin Liu
> ---
> drivers/net/virtio/virtio_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Tiwei Bie
to: add public function implementation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jin Yu
> ---
> V2 - add the librte_crytodev
> ---
> lib/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Tiwei Bie
On Wed, Oct 30, 2019 at 10:56:02PM +0800, Marvin Liu wrote:
> Log feature is disabled in vhost user, so that log address was invalid
> when checking. Check whether log address is valid can workaround it.
> Also log address should be translated in packed ring virtqueue.
>
> Fixes: 04cfc7fdbfca ("vh
On Wed, Oct 30, 2019 at 07:07:23PM +0800, Marvin Liu wrote:
> Log feature is disabled in vhost user, so that log address was invalid
> when checking. Check whether log address is valid can workaround it.
> Also log address should be translated in packed ring virtqueue.
>
> Fixes: 04cfc7fdbfca ("vh
On Fri, Oct 18, 2019 at 10:26:39AM +0200, Adrian Moreno wrote:
> Currently there are a couple of limitations on the logging system: Most
> of the logs are compiled out and both datapath and controlpath logs
> share the same loglevel.
>
> This patch tries to help fix that situation by:
> - Splittin
On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Cc: sta...@dpdk.org
Fixes: 939066d96563 ("vhost/crypto: add publ
On Mon, Oct 28, 2019 at 10:18:11PM +0800, Marvin Liu wrote:
> Virtio spec only set rule that packed ring maximum size is up to 2^15
> entries. Do not limit packed ring size to power of two.
Please add a "Fixes:" line.
>
> Signed-off-by: Marvin Liu
> ---
> lib/librte_vhost/vhost_user.c | 15 +++
On Tue, Oct 29, 2019 at 12:42:20AM +0800, Marvin Liu wrote:
> As doc mentioned, promisc and multicast are by-default supported in
> virtio pmd. Mac/vlan filter are supported by best effort. These control
> messages should return pass.
>
> Fixes: f9b9d1a55775 ("net/virtio-user: add multiple queues
o
> ---
> drivers/net/virtio/virtio_rxtx.c | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
Reviewed-by: Tiwei Bie
Thanks,
Tiwei
reg_struct.range.len - 1);
> #else
> goto err_mmap;
> #endif
> --
> 1.8.3.1
>
Cc: sta...@dpdk.org
Reviewed-by: Tiwei Bie
Thanks,
Tiwei
On Thu, Oct 24, 2019 at 09:27:38PM +0200, David Marchand wrote:
> On Mon, Aug 19, 2019 at 1:41 PM Maxime Coquelin
> wrote:
> > On 8/19/19 10:40 AM, David Marchand wrote:
> > > On Thu, Aug 15, 2019 at 6:16 PM David Christensen
> > > wrote:
> > >>
> > Use of %llx print formatting causes meson
bstracted in the ioport
> API, we can remove it on virtio side.
>
> We still need to call rte_eal_iopl_init() in the virtio constructor so
> that the interrupt thread inherits this permission in the case it could
> be used with UIO later.
>
> Signed-off-by: David Marchand
>
On Fri, Oct 18, 2019 at 10:33:47AM +0200, David Marchand wrote:
> On Fri, Oct 18, 2019 at 10:19 AM Tiwei Bie wrote:
> > On Thu, Oct 17, 2019 at 01:56:28PM +0200, David Marchand wrote:
> > > On x86, iopl permissions are only needed when the virtio devices are
> > > b
On Thu, Oct 17, 2019 at 01:56:28PM +0200, David Marchand wrote:
> On x86, iopl permissions are only needed when the virtio devices are
> bound to a uio kernel module.
>
> When running a dpdk application as non root, the virtio driver was
> refusing to register because of this check while it could
ts
> ---
> lib/librte_vhost/virtio_net.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Tiwei Bie
Thanks,
Tiwei
nd packet length mismatch")
For the rest,
Reviewed-by: Tiwei Bie
On Mon, Oct 14, 2019 at 06:15:42PM +0300, Andrew Rybchenko wrote:
> > diff --git a/drivers/net/virtio/virtio_rxtx.c
> > b/drivers/net/virtio/virtio_rxtx.c
> > index 27ead19fb..822cce06d 100644
> > --- a/drivers/net/virtio/virtio_rxtx.c
> > +++ b/drivers/net/virtio/virtio_rxtx.c
> > @@ -597,9 +597,
On Fri, Oct 11, 2019 at 02:09:47PM -0300, Flavio Leitner wrote:
> The rte_vhost_dequeue_burst supports two ways of dequeuing data.
> If the data fits into a buffer, then all data is copied and a
> single linear buffer is returned. Otherwise it allocates
> additional mbufs and chains them together t
Rybchenko:
> > > > > On 10/9/19 1:41 PM, Tiwei Bie wrote:
> > > > > > My understanding is that, setting mq_mode to ETH_MQ_RX_NONE means
> > > > > > no method is enforced on how to route packets to MQs.
> > > > > I'm not sure. I
[PATCH v2] vhost: add support for large buffers.
There is a warning reported by devtools/check-git-log.sh
The '.' at the end of the title should be dropped.
On Fri, Oct 04, 2019 at 05:10:08PM -0300, Flavio Leitner wrote:
> The rte_vhost_dequeue_burst supports two ways of dequeuing data.
> If th
On Wed, Oct 09, 2019 at 12:00:28PM +0300, Andrew Rybchenko wrote:
> On 10/9/19 11:43 AM, Tiwei Bie wrote:
> > On Wed, Oct 09, 2019 at 11:04:38AM +0300, Andrew Rybchenko wrote:
> > > On 10/8/19 8:46 AM, Tiwei Bie wrote:
> > > > On Tue, Oct 01, 2019 at 04:44:31PM
On Wed, Oct 09, 2019 at 11:04:38AM +0300, Andrew Rybchenko wrote:
> On 10/8/19 8:46 AM, Tiwei Bie wrote:
> > On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote:
> > > From: Dilshod Urazov
> > >
> > > This driver supports none of DCB, RSS or VM
On Tue, Oct 08, 2019 at 09:43:48AM +0200, Maxime Coquelin wrote:
> On 10/8/19 9:38 AM, Adrian Moreno wrote:
> > On 10/8/19 8:30 AM, Tiwei Bie wrote:
> >> On Fri, Sep 27, 2019 at 08:37:58PM +0200, Adrian Moreno wrote:
> >>> Note that the API facing rte_vhost_log_w
On Fri, Sep 27, 2019 at 08:37:58PM +0200, Adrian Moreno wrote:
> Note that the API facing rte_vhost_log_write is not modified.
> So, make explicit that it expects the address in GPA space.
>
> Fixes: 69c90e98f483 ("vhost: enable IOMMU support")
> Cc: maxime.coque...@redhat.com
> Cc: sta...@dpdk.or
++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Tiwei Bie
>
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index 274988c4d..534a7ffe3 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -871,6 +871,14 @@ rte_vhost_drive
On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote:
> From: Dilshod Urazov
>
> This driver supports none of DCB, RSS or VMDQ modes,
> therefore must check and return error if configured incorrectly.
>
> Fixes: c1f86306a026 ("virtio: add new driver")
> Cc: sta...@dpdk.org
>
> Signe
od Urazov
> Signed-off-by: Andrew Rybchenko
> ---
> drivers/net/virtio/virtio_rxtx.c | 5 +
> 1 file changed, 5 insertions(+)
Reviewed-by: Tiwei Bie
On Thu, Sep 26, 2019 at 11:06:22PM +0800, Yu, Jin wrote:
> > >
> > > +static int
> > > +mem_create(const char *name, unsigned int flags) { #ifdef
> > > +MEMFD_SUPPORTED
> > > + return memfd_create(name, flags);
> > > +#else
> > > + RTE_LOG(ERR, VHOST_CONFIG,
> > > + "doesn't support memfd--
On Thu, Sep 26, 2019 at 10:29:19PM +0800, Yu, Jin wrote:
> > -Original Message-
> > From: Bie, Tiwei
> > Sent: Wednesday, September 25, 2019 10:46 PM
> > To: Yu, Jin
> > Cc: dev@dpdk.org; Liu, Changpeng ;
> > maxime.coque...@redhat.com; Wang, Zhihong
> > Subject: Re: [PATCH v7 10/10] vhos
On Fri, Sep 20, 2019 at 08:00:57PM +0800, Jin Yu wrote:
> @@ -1458,6 +1472,188 @@ static int vhost_user_set_vring_err(struct virtio_net
> **pdev __rte_unused,
> return RTE_VHOST_MSG_RESULT_OK;
> }
>
> +static int
> +resubmit_desc_compare(const void *a, const void *b)
> +{
> + const st
On Fri, Sep 20, 2019 at 08:00:56PM +0800, Jin Yu wrote:
> This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD
> and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared
> buffer between qemu and backend.
>
> Signed-off-by: Lin Li
> Signed-off-by: Xun Ni
> Signed-off-by: Yu Z
On Thu, Sep 26, 2019 at 01:13:24AM +0800, Marvin Liu wrote:
> static __rte_noinline uint32_t
> virtio_dev_rx_packed(struct virtio_net *dev, struct vhost_virtqueue *vq,
> struct rte_mbuf **pkts, uint32_t count)
> {
> uint32_t pkt_idx = 0;
> - uint16_t num_buffers;
> - struct b
On Thu, Sep 26, 2019 at 01:13:16AM +0800, Marvin Liu wrote:
> Add macro for unifying Clang/ICC/GCC unroll pragma format. Batch
> functions were contained of several small loops which optimized by
> compiler’s loop unrolling pragma.
>
> Signed-off-by: Marvin Liu
>
> diff --git a/lib/librte_vhost/
On Thu, Sep 26, 2019 at 01:13:27AM +0800, Marvin Liu wrote:
> Cache address translation result and use it in next translation. Due
> to limited regions are supported, buffers are most likely in same
> region when doing data transmission.
>
> Signed-off-by: Marvin Liu
>
> diff --git a/lib/librte_
On Fri, Sep 20, 2019 at 08:01:02PM +0800, Jin Yu wrote:
> A vhost-user-blk example that support inflight feature. It uses the
> new APIs that introduced in the first patch, so It can show how there
s/It/it/
s/there/these/
> APIs work to support inflight feature.
>
> Signed-off-by: Jin Yu
> ---
> [PATCH v7 00/10] vhost: support inflight share memory protocol feature
This should be v8. Please increase the version number when
sending a new series.
Thanks,
Tiwei
On Fri, Sep 20, 2019 at 08:00:52PM +0800, Jin Yu wrote:
> This patches introduces two new messages VHOST_USER_GET_INFLIGHT_FD
On Mon, Sep 23, 2019 at 12:28:35PM +0200, Adrian Moreno wrote:
> On 9/23/19 9:25 AM, Tiwei Bie wrote:
> > On Tue, Sep 17, 2019 at 04:49:00PM +0200, Adrian Moreno wrote:
> >> When IOMMU is enabled the incoming log address is in IOVA space. In that
> >> case, look in IO
On Tue, Sep 17, 2019 at 05:09:47PM +0800, Andy Pei wrote:
> vDPA's set_vring_state callback would need to know the virtqueues'
> enable status to configure the hardware.
>
> Signed-off-by: Xiaolong Ye
> Signed-off-by: Andy Pei
> ---
> v2:
> add nr_active_vring as a parameter to ops function set
On Tue, Sep 17, 2019 at 04:49:00PM +0200, Adrian Moreno wrote:
> When IOMMU is enabled the incoming log address is in IOVA space. In that
> case, look in IOTLB table and translate the resulting HVA to GPA.
>
> If IOMMU is not enabled, the incoming log address is already a GPA so no
> transformatio
On Fri, Sep 20, 2019 at 12:36:33AM +0800, Marvin Liu wrote:
> Simplify flush shadow used ring function names as all shadow rings are
> reflect to used rings. No need to emphasize ring type.
I think the old name "flush_shadow_used_ring" is more readable
than the new name "flush_shadow". In the new
On Fri, Sep 20, 2019 at 12:36:30AM +0800, Marvin Liu wrote:
> Burst enqueue function will first check whether descriptors are cache
> aligned. It will also check prerequisites in the beginning. Burst
> enqueue function not support chained mbufs, single packet enqueue
> function will handle it.
>
>
On Fri, Sep 20, 2019 at 12:36:29AM +0800, Marvin Liu wrote:
> Add macro for unifying Clang/ICC/GCC unroll pragma format. Burst
> functions were contained of several small loops which optimized by
> compiler’s loop unrolling pragma.
>
> Signed-off-by: Marvin Liu
>
> diff --git a/lib/librte_vhost/
On Tue, Sep 17, 2019 at 10:52:33PM +0800, JinYu wrote:
> add all the added experimental APIs which are in
> the rte_vhost.h to the rte_vhost_version.map
Symbols should be added to the .map file in the same
patch which introduces them. Otherwise that patch will
break the build.
Thanks,
Tiwei
>
>
On Tue, Sep 17, 2019 at 10:52:31PM +0800, JinYu wrote:
> This patch fix two APIs so user can get the packed ring
> support.
>
> Fixes: fceec568 (vhost: add packed ring)
> Cc: sta...@dpdk.org
I changed my mind, as the packed ring related fields are just
added to rte_vhost_vring in this series, we
Explicitly document that the MAC/VLAN filtering in virtio
is best effort to help users understand why unwanted packets
could still arrive.
Signed-off-by: Tiwei Bie
---
doc/guides/nics/virtio.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/nics/virtio.rst b/doc
On Wed, Sep 18, 2019 at 11:19:03AM +0800, Liu, Yong wrote:
> > -Original Message-
> > From: Bie, Tiwei
> > Sent: Wednesday, September 18, 2019 10:35 AM
> > To: Liu, Yong
> > Cc: maxime.coque...@redhat.com; dev@dpdk.org
> > Subject: Re: [PATCH v2 1/2] net/virtio: update stats when in order
1 - 100 of 805 matches
Mail list logo
