Re: [PATCH] config/arm: update neoverse n3 SoC and add neoverse V3

2025-05-28 Thread Thomas Monjalon
16/05/2025 18:15, Doug Foster: > Arm Neoverse N3 build configuration is updated to include mcpu that > aligns with latest GCC. Also, add Arm Neoverse V3 build configuration. > > Signed-off-by: Doug Foster > Reviewed-by: Wathsala Vithanage > Reviewed-by: Dhruv Tripathi Split in 2 patches and pu

Re: [PATCH v2] fix eal/linux: unregister alarm callback before free

2025-05-27 Thread Thomas Monjalon
Hello, Did you see the comment from David about fixing for Windows and FreeBSD at the same time? I think you just need to apply the same logic in 3 different places. If you cannot test all, that's OK to submit the changes without full coverage testing. Thank you 22/05/2025 17:59, Rui Ferreira

Re: [EXTERNAL] [PATCH v1 4/7] event/dlb2: support managing history list resource

2025-05-27 Thread Thomas Monjalon
27/05/2025 07:57, Jerin Jacob: > From: Pravin Pathak > > --- a/drivers/event/dlb2/version.map > > +++ b/drivers/event/dlb2/version.map > > @@ -7,4 +7,5 @@ EXPERIMENTAL { > > > > # added in 20.11 > > rte_pmd_dlb2_set_token_pop_mode; > > Add added in 25.07 There is no .map file anymore.

Re: patch state

2025-05-27 Thread Thomas Monjalon
27/05/2025 10:07, Morten Brørup: > Hi Thomas, > > I have two patch series ready for RC1: > https://patchwork.dpdk.org/project/dpdk/list/?submitter=591 > > Do you want me to change their state from New to Awaiting Upstream? Awaiting Upstream is very special, it means you wait for something in ano

DPDK Summit CFP - September, California

2025-05-26 Thread Thomas Monjalon
Hello, Reminder about our next DPDK Summit which will happen in Intel headquarters at Santa Clara, California. Dates: September 17-18, 2025. To register: https://linuxfoundation.regfox.com/2025-bay-area-summit To submit a talk: https://sessionize.com/dpdk-bay-area-summit-2025 You can propose a

Re: [PATCH] eal: add getline() function for Windows

2025-05-21 Thread Thomas Monjalon
21/05/2025 02:35, Andre Muezerie: > On Tue, May 20, 2025 at 10:14:33AM -0700, Stephen Hemminger wrote: > > On Mon, 5 May 2025 13:40:07 -0700 > > Andre Muezerie wrote: > > > > > Existing DPDK code uses getline(), which is a POSIX function and is > > > not available in the Windows APIs. > > > > >

Re: [PATCH] regexdev: enable to be compiled on Windows

2025-05-16 Thread Thomas Monjalon
16/05/2025 14:50, Andre Muezerie: > On Fri, May 16, 2025 at 10:01:42AM +0200, David Marchand wrote: > > On Fri, May 9, 2025 at 11:52 PM Andre Muezerie > > wrote: > > > > > > Now that mbuf is compiling on Windows, this library can be enabled as > > > well. > > > > > > Signed-off-by: Andre Muezerie

Re: [PATCH] ethdev: support RSS based on RoCEv2 header

2025-04-22 Thread Thomas Monjalon
22/04/2025 07:14, kirankum...@marvell.com: > From: Kiran Kumar K > > On supporting hardware, RoCEv2 header can be used to > perform RSS in the ingress path. Do you mean IB BTH? It would be good to adopt a unique name between RSS and flow matching: RTE_FLOW_ITEM_TYPE_IB_BTH

Re: [PATCH v2] ethdev: add support for flow action pop E-tag

2025-04-22 Thread Thomas Monjalon
22/04/2025 07:53, kirankum...@marvell.com: > Add support for the following OpenFlow-defined action. > > RTE_FLOW_ACTION_TYPE_OF_POP_ETAG: Pop E-tag from the packet. I'm not sure about adding such action. There is a more generic which should cover it: RTE_FLOW_ACTION_TYPE_MODIFY_FIELD The

Re: Flow API Test Suite Inquiry

2025-04-16 Thread Thomas Monjalon
Hi, 15/04/2025 20:21, Dean Marx: > The flow API allows for an extremely broad set of rules to be created. > My understanding from my first pass at writing the test suite is that > there is a small subset of those rules that are “core functionality” > that the flow API aims to support, and there ar

[PATCH] doc: reduce index depth of most guides

2025-04-14 Thread Thomas Monjalon
The guides having a diverse list of multiple drivers or tools are easier to browse with an index limited to the first headings (depth 1). Signed-off-by: Thomas Monjalon --- doc/guides/bbdevs/index.rst| 2 +- doc/guides/compressdevs/index.rst | 2 +- doc/guides/cryptodevs/index.rst

[PATCH] common/mlx5: fix build on Linux in dlopen link mode

2025-04-08 Thread Thomas Monjalon
atal error: eal_export.h: No such file or directory Fixes: c7020bb20fc7 ("build: mark exported symbols") Reported-by: Ali Alnubani Signed-off-by: Thomas Monjalon --- drivers/common/mlx5/linux/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/ml

Re: [PATCH] common/mlx5: fix build on Linux in dlopen link mode

2025-04-08 Thread Thomas Monjalon
08/04/2025 09:57, David Marchand: > On Tue, Apr 8, 2025 at 9:47 AM Thomas Monjalon wrote: > > > > When using the Meson option "ibverbs_link=dlopen", > > a glue library is built. > > > > After the recent change requiring eal_export.h, > > t

Re: [PATCH] examples/flow_filtering: fix make clean

2025-04-05 Thread Thomas Monjalon
29/03/2025 20:53, Tanzeel Ahmed: > make clean is unable to delete build directory > because *.o files are not removed. > > The other way to fix this would be to add all the > c files into SRCS-y. How adding all C files into SRCS-y would help?

Re: [PATCH v1] net/ice: updated latest recommended matching list

2025-04-05 Thread Thomas Monjalon
21/03/2025 01:36, hailinx: > Signed-off-by: hailinx > --- > + |25.03 | 1.16.3| 1.3.39 | 1.3.53 |1.3.14 > |4.7| Applied, thanks.

Re: [PATCH v6 3/8] buildtools: display version when listing symbols

2025-04-05 Thread Thomas Monjalon
28/03/2025 11:52, David Marchand: > Display the version when a symbol was introduced. > This is needed for scripting the conversion from static to dynamically > generated version maps. > It is also useful when listing experimental symbols. I feel the title needs a bit more context, maybe adding "m

Re: [PATCH V1] doc: add tested Intel platforms with Intel NICs

2025-04-04 Thread Thomas Monjalon
21/03/2025 10:20, Mcnamara, John: > > Subject: [PATCH V1] doc: add tested Intel platforms with Intel NICs > > > > Add tested Intel platforms with Intel NICs to v25.03 release note. > > Acked-by: John McNamara Applied, thanks.

Re: DPDK for rust

2025-04-04 Thread Thomas Monjalon
27/03/2025 17:17, Bruce Richardson: > On Thu, Mar 27, 2025 at 11:00:40AM +0200, Etelson, Gregory wrote: > > Hello Morten, > > > > Thank you for raising these questions ! > > > > > > > > Do we want the DPDK project itself to support rust? > > > Or should parts of this be a DPDK hosted project, li

Re: [PATCH v6 8/8] eal: rework function versioning macros

2025-04-02 Thread Thomas Monjalon
28/03/2025 11:52, David Marchand: > --- a/lib/eal/common/eal_symbol_exports.h > +++ b/lib/eal/common/eal_symbol_exports.h > @@ -5,6 +5,8 @@ > #ifndef EAL_SYMBOL_EXPORTS_H > #define EAL_SYMBOL_EXPORTS_H > > +#include > + > /* Internal macros for exporting symbols, used by the build system. >

Re: [PATCH v6 5/8] build: mark exported symbols

2025-04-02 Thread Thomas Monjalon
28/03/2025 11:52, David Marchand: > --- /dev/null > +++ b/drivers/bus/dpaa/dpaa_bus_symbols.c This is a special case for base drivers, so we should mention "base" in the filename. > @@ -0,0 +1,99 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright (c) 2025 Red Hat, Inc. > + */ > + > +#

Re: [PATCH v6 4/8] build: generate symbol maps

2025-04-02 Thread Thomas Monjalon
02/04/2025 09:00, David Marchand: > On Tue, Apr 1, 2025 at 10:25 PM Thomas Monjalon wrote: > > > > 28/03/2025 11:52, David Marchand: > > > Rather than maintain a file in parallel of the code, symbols to be > > > exported can be marked with a token RTE_EXPORT_*SYM

Re: [PATCH v6 4/8] build: generate symbol maps

2025-04-02 Thread Thomas Monjalon
28/03/2025 11:52, David Marchand: > --- /dev/null > +++ b/lib/eal/common/eal_symbol_exports.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright (c) 2025 Red Hat, Inc. > + */ > + > +#ifndef EAL_SYMBOL_EXPORTS_H > +#define EAL_SYMBOL_EXPORTS_H > + > +/* Internal macros fo

Re: [PATCH v6 4/8] build: generate symbol maps

2025-04-01 Thread Thomas Monjalon
28/03/2025 11:52, David Marchand: > +scriptname, link_mode, abi_version_file, output, *files = sys.argv You should add a comment to show the usage of the script. [...] > +if link_mode == 'mslinker': > +with open(output, "w") as outfile: > +print(f"EXPORTS", file=outfile) > +fo

Re: [PATCH v6 4/8] build: generate symbol maps

2025-04-01 Thread Thomas Monjalon
28/03/2025 11:52, David Marchand: > Rather than maintain a file in parallel of the code, symbols to be > exported can be marked with a token RTE_EXPORT_*SYMBOL. > > From those marks, the build framework generates map files only for > symbols actually compiled (which means that the WINDOWS_NO_EXPOR

Re: [PATCH] doc/bluefield: add comparison between BlueField versions

2025-03-25 Thread Thomas Monjalon
19/03/2025 13:13, Raslan Darawsheh: > Updated BlueField-3 documentation to include a detailed comparison > with BlueField-2 and added notes on compiler requirements. > > Signed-off-by: Raslan Darawsheh Applied, thanks.

Re: [PATCH] doc: add tested platforms with NVIDIA NICs

2025-03-25 Thread Thomas Monjalon
20/03/2025 09:44, Raslan Darawsheh: > Add tested platforms with NVIDIA NICs to the 25.03 release notes. > > Signed-off-by: Raslan Darawsheh Applied, thanks.

DPDK 25.03 released

2025-03-24 Thread Thomas Monjalon
A new major release is available: https://fast.dpdk.org/rel/dpdk-25.03.tar.xz It was a small release cycle: 812 commits from 137 authors 1601 files changed, 85099 insertions(+), 38808 deletions(-) It is not planned to start a maintenance branch for 25.03. This version is A

Re: [PATCH v1] doc: update release notes for 25.03

2025-03-24 Thread Thomas Monjalon
21/03/2025 18:34, John McNamara: > Fix grammar, spelling and formatting of DPDK 25.03 release notes > > Signed-off-by: John McNamara Applied with an additional merge of vhost and virtio RSA features. Also removed the comments. Thanks

Re: [Patch v3] doc: announce bus/vmbus API changes

2025-03-24 Thread Thomas Monjalon
17/03/2025 21:09, lon...@linuxonhyperv.com: > From: Long Li > > All vmbus APIs are used internally by DPDK core and net/netvsc PMD. > It's not feasible or practical to use those APIs by the application. > Those APIs will become internal in DPDK 25.11. > > Signed-off-by: Long Li Applied, thanks

Re: [PATCH v1 1/2] maintainers: update for crypto performance test

2025-03-24 Thread Thomas Monjalon
20/03/2025 15:21, Brian Dooley: > Replacing myself as Crypto Perf App maintainer with Kai Ji. > > Signed-off-by: Brian Dooley > --- > Crypto performance test application > -M: Brian Dooley > +M: Kai Ji Series applied, thanks.

Re: [PATCH v3] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Thomas Monjalon
24/03/2025 14:18, Morten Brørup: > > From: Raslan Darawsheh [mailto:rasl...@nvidia.com] > > Sent: Monday, 24 March 2025 10.34 > > > > When processing VLAN or QinQ packets, an infinite loop occurred, > > preventing the csum forward engine from proceeding and causing > > testpmd to hang during shutd

Re: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Thomas Monjalon
23/03/2025 13:28, Raslan Darawsheh: > Updated the `get_ethertype_by_ptype` function to correctly parse VLAN > headers. You should describe what is broken and how. > Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API") > Cc: haij...@huawei.com Do you think it is critical for the relea

Re: [PATCH] net/ixgbe: fix missing checks for E610 VFs

2025-03-23 Thread Thomas Monjalon
21/03/2025 18:15, Medvedkin, Vladimir: > Acked-by: Vladimir Medvedkin > > On 21/03/2025 17:12, Bruce Richardson wrote: > > A number of places in the ixgbe code check for a virtual function, but > > these checks were missing the identifier for the E610 VF. Add them into > > the conditionals. > > >

Re: [PATCH v1] net/i40e: updated latest recommended matching list

2025-03-23 Thread Thomas Monjalon
21/03/2025 01:36, hailinx: > Signed-off-by: hailinx Applied, thanks.

Re: [PATCH v2] eal: fix undetected NUMA nodes

2025-03-23 Thread Thomas Monjalon
19/03/2025 17:31, David Marchand: > On Wed, Mar 5, 2025 at 5:25 PM Bruce Richardson > wrote: > > > > In cases where the number of cores on a given socket is greater than > > RTE_MAX_LCORES, then EAL will be unaware of all the sockets/numa nodes > > on a system. Fix this limitation by having the EA

Re: [RFC] doc: Document frequency and volume limits on patches.

2025-03-19 Thread Thomas Monjalon
Hello, 05/03/2025 02:33, Aaron Conole: > The DPDK project has two constrained resources - reviewers and > public CI infrastructure. These are shared among the entire > project, and there are true costs associated with using these > resources. Thus, there are two motivations behind this change: >

Re: [EXTERNAL] [PATCH] config/arm: fix meson for native instruction set Arm CPUs

2025-03-19 Thread Thomas Monjalon
19/03/2025 12:10, Pavan Nikhilesh Bhagavatula: > > Hi Gregory, > > > > > Arm meson.build unconditionally relays on the `extra_features` > > > member of SoC configuration. > > > > > > SoC dictionary is populated for Arm CPUs with generic instruction set > > > only. > > > For Arm CPUs with native CP

release candidate 25.03-rc3

2025-03-18 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v25.03-rc3 There are 71 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_25_03.html Please test and report new issues on https://bugs.dpdk.org If no maj

Re: [PATCH] doc/dmadevs: clarify naming constraints for idxd devices

2025-03-18 Thread Thomas Monjalon
18/02/2025 16:44, Kevin Laatz: > On 31/01/2025 14:49, Bruce Richardson wrote: > > The requirement to have DPDK in the DSA wq name is given in the idxd > > chapter section 5.3.3 [1]. However, that information should also be > > given in section 5.3.1 [2] where we list out the fields to be set and >

Re: [PATCH v1 1/1] usertools/devbind: add documentation for no-IOMMU mode

2025-03-18 Thread Thomas Monjalon
18/02/2025 10:46, Bruce Richardson: > On Mon, Dec 02, 2024 at 09:35:01AM +, Anatoly Burakov wrote: > > Support for `--noiommu-mode` flag was added, but documentation for it was > > not. Add documentation for the flag. > > > > Signed-off-by: Anatoly Burakov > > Acked-by: Bruce Richardson Ap

Re: [PATCH v4 1/1] usertools/devbind: allow changing UID/GID for VFIO

2025-03-18 Thread Thomas Monjalon
02/12/2024 10:35, Burakov, Anatoly: > On 12/2/2024 10:31 AM, Anatoly Burakov wrote: > > Currently, when binding a device to VFIO, the UID/GID for the device will > > always stay as system default (`root`). Yet, when running DPDK as non-root > > user, one has to change the UID/GID of the device to m

Re: [PATCH] examples/ipsec-secgw: fix cryptodev and eventdev ID

2025-03-18 Thread Thomas Monjalon
23/01/2025 11:27, Anoob Joseph: > > Subject: [PATCH] examples/ipsec-secgw: fix cryptodev and eventdev ID > > > > Fixing cryptodev and eventdev ID numbers. > > > > Fixes: 0dbe550a4af5 ("examples/ipsec-secgw: initialize event crypto > > adapter") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Tej

Re: [PATCH] examples/flow_filtering: fix destination IP mask

2025-03-18 Thread Thomas Monjalon
10/03/2025 07:48, Shani Peretz: > From: Thomas Monjalon > > 12/01/2025 08:52, Shani Peretz: > > > This patch corrects the destination IP address mask to restore the > > > previous implementation's behavior. > > > > > > Also it fixes a misuse of r

Re: [PATCH] pdump: clear statistics when enabled

2025-03-18 Thread Thomas Monjalon
20/12/2024 00:58, Stephen Hemminger: > The pdump statistics are used to keep track of the number > of packets captured, filtered, etc. These need not be cumalative > and instead should be start counting when capture starts. > > This fixes the issue where multiple invocations of dumpcap > would inc

Re: [PATCH v3] app/test: fix stack overflow in lpm6_perf_autotest

2025-03-18 Thread Thomas Monjalon
05/03/2025 21:04, Medvedkin, Vladimir: > On 05/03/2025 14:45, Andre Muezerie wrote: > > On Wed, Mar 05, 2025 at 10:08:33AM +, Bruce Richardson wrote: > >> On Wed, Dec 18, 2024 at 07:21:26AM -0800, Andre Muezerie wrote: > >>> Test lpm6_perf_autotest was hitting a stack overflow on Windows > >>>

Re: [PATCH] config/arm: fix march features not being set

2025-03-18 Thread Thomas Monjalon
> > From: Pavan Nikhilesh > > > > Fix extra_march_features not being added to mcpu flags when SoC > > configuration advertises them. > > > > Fixes: c02c01dbf907 ("config/arm: prefer strict use of -mcpu if supported") > > Acked-by: Jerin Jacob Applied, thanks.

Re: [PATCH] config/arm: add crypto to cn9k soc

2025-03-18 Thread Thomas Monjalon
08/03/2025 10:01, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > Add crypto as extra march feature to cn9k soc. > > Signed-off-by: Pavan Nikhilesh Applied, thanks.

Re: [PATCH] devtools: enhance the license check

2025-03-15 Thread Thomas Monjalon
10/12/2024 10:10, David Marchand: > Reformat the license/exceptions.txt file to make it easier to build > a list of exempted files. > Display all files committed in DPDK that are non compliant > with BSD-3 license. > > Signed-off-by: David Marchand Applied, thanks

Re: [RFC] git: consolidate .gitignore files

2025-03-15 Thread Thomas Monjalon
10/02/2025 18:20, Stephen Hemminger: > Lets have only one .gitignore at top level. > > Signed-off-by: Stephen Hemminger Applied with uAPI rules dropped and these explanations added: " Some generated DTS files must be ignored. The Linux uAPI files should not be ignored. "

Re: [RFC] git: consolidate .gitignore files

2025-03-14 Thread Thomas Monjalon
14/03/2025 16:18, Patrick Robb: > https://git.dpdk.org/next/dpdk-next-dts/commit/?id=564f4abb42df0cdf7da8c53933705bc205642005 > > This commit on next-dts changes the name of this default config file from > test_runs.yaml to test_run.yaml. However, it is not pulled to main yet. > > I can send a pa

Re: [RFC v3 5/8] build: generate symbol maps

2025-03-14 Thread Thomas Monjalon
11/03/2025 10:56, David Marchand: > +if is_ms_linker > +link_mode = 'msvc' It can be MSVC or clang. mslinker may be a better naming. > +elif is_windows > +link_mode = 'mingw' > +else > +link_mode = 'gnu' > +endif

Re: [PATCH] dts: fix SPDX tag

2025-03-14 Thread Thomas Monjalon
14/03/2025 14:43, Thomas Monjalon: > The license in the SPDX tag was incomplete. > > Fixes: d77a4a27bd24 ("dts: remove node distinction") > > Signed-off-by: Thomas Monjalon Reviewed-by: Luca Vizzarro Applied, thanks.

[PATCH] dts: fix SPDX tag

2025-03-14 Thread Thomas Monjalon
The license in the SPDX tag was incomplete. Fixes: d77a4a27bd24 ("dts: remove node distinction") Signed-off-by: Thomas Monjalon --- dts/framework/remote_session/dpdk.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dts/framework/remote_session/dpdk.py b/dts

Re: [PATCH] doc: announce bus/vmbus API changes

2025-03-13 Thread Thomas Monjalon
12/03/2025 22:43, lon...@linuxonhyperv.com: > From: Long Li > > All vmbus APIs are used internally by DPDK core and net/netvsc PMD. > It's not feasible or practical to use those APIs by the application. > Those APIs will be moved from "DPDK" to "Internal" in DPDK 25.11. > > Signed-off-by: Long L

Minutes of DPDK Technical Board Meeting, 2025-03-05

2025-03-13 Thread Thomas Monjalon
Members Attending: 10/11 - Aaron Conole - Bruce Richardson - Hemant Agrawal - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Morten Brørup - Thomas Monjalon (Chair) NOTE

Re: [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD

2025-03-13 Thread Thomas Monjalon
13/03/2025 09:56, Bruce Richardson: > On Thu, Mar 13, 2025 at 09:00:09AM +0100, Morten Brørup wrote: > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Thursday, 13 March 2025 00.02 > > > > > > On Wed, 19 Feb 2025 15:5

Re: [PATCH] rust: support DPDK API

2025-03-12 Thread Thomas Monjalon
12/03/2025 16:29, Igor Gutorov: > On Mon, Mar 10, 2025 at 7:34 PM Stephen Hemminger > wrote: > > > > The real benefit would the ability to support PMD's built in Rust. > > Having DPDK libraries as Rust crates would be beneficial as well. The > mempool library in particular is something I've wante

Re: [PATCH v2] rust: support raw DPDK API

2025-03-12 Thread Thomas Monjalon
10/03/2025 17:25, Bruce Richardson: > On Mon, Mar 10, 2025 at 04:13:21PM +, Van Haaren, Harry wrote: > > Looking at the above parts of "Port abstraction in Rust", I'm not sure it > > really adds anything. > > It feels a bit "middle of the road" (aka, adding some "abstraction", but > > not goi

Re: [PATCH] doc: update ionic driver guides

2025-03-11 Thread Thomas Monjalon
27/02/2025 21:14, Andrew Boyer: > Update broken links and add a link for the DSC3-400 product brief. > > Cc: sta...@dpdk.org > Signed-off-by: Andrew Boyer Applied, thanks.

Re: [PATCH v2] devtools: fix regex of skip files

2025-03-11 Thread Thomas Monjalon
06/03/2025 18:12, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > SKIP_FILES should include the path of the file along with the name. > Update the regex to match the entire path. > > Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver") > Fixes: 2b843cac232e ("drivers: use

Re: [PATCH] doc: fix year of final LTS release

2025-03-11 Thread Thomas Monjalon
10/03/2025 11:28, fengchengwen: > Acked-by: Chengwen Feng > > On 2025/3/10 18:08, Kevin Traynor wrote: > > LTS length was updated to 3 years, but a sentence saying > > when the final release would be was not updated. > > > > Fixes: 3c60ea7b289a ("doc: update LTS maintenance to 3 years") > > Cc:

Re: [PATCH] devtools: fix regex of cnxk skip files

2025-03-06 Thread Thomas Monjalon
06/03/2025 16:25, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > SKIP_FILES should include the path of the file. > Update the regex to match the path. Can you please also check this one: -v SKIP_FILES='osdep.h$' Is it really working without the full path?

Re: [PATCH] test/ring: fix return uninitialized variable

2025-03-06 Thread Thomas Monjalon
22/02/2025 03:08, fengchengwen: > Acked-by: Chengwen Feng > > On 2025/2/19 22:23, Konstantin Ananyev wrote: > > This change addresses the CID 455328: Uninitialized variables (UNINIT). > > Strictly speaking right now it should never happen, as role_mask is not > > zero. But that might change in f

release candidate 25.03-rc2

2025-03-06 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v25.03-rc2 There are 251 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_25_03.html Most significant changes are in multiple drivers. Please test and r

Re: [PATCH] ethdev: fix get_reg_info

2025-03-06 Thread Thomas Monjalon
19/02/2025 19:45, Stephen Hemminger: > On Tue, 18 Feb 2025 12:58:28 +0100 > Thierry Herbelot wrote: > > > 'width' and 'offset' are input parameters when dumping the register > > info of an Ethernet device. They should be copied in the new request > > before calling the device callback function. >

Re: [PATCH] app/test: fix DMA API tests in IOVA as PA mode

2025-03-06 Thread Thomas Monjalon
28/02/2025 01:15, fengchengwen: > Reviewed-by: Chengwen Feng > > On 2025/2/27 21:27, Bruce Richardson wrote: > > When running without IOMMU for address translation, i.e. IOVAs are > > physical rather than virtual addresses, we need to translate the > > pointers to IOVAs for the completion API tes

Re: [PATCH] devtools: fix regex of cnxk skip files

2025-03-06 Thread Thomas Monjalon
06/03/2025 16:25, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > SKIP_FILES should include the path of the file. > Update the regex to match the path. > > Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver") > > Signed-off-by: Pavan Nikhilesh > --- > - -v SK

Re: [PATCH] vhost/crypto: fix locking

2025-03-05 Thread Thomas Monjalon
05/03/2025 10:52, Maxime Coquelin: > > On 3/5/25 10:12 AM, David Marchand wrote: > > vc_req_out->vq->iotlb_lock is taken twice on the same thread: > > vc_req_out->vq refers to vc_req->vq (after a memcpy), which itself > > is a reference to the vq. > > > > clang probably does not detect that the s

Re: [PATCH] vhost/crypto: fix build with asserts

2025-03-05 Thread Thomas Monjalon
05/03/2025 10:48, Maxime Coquelin: > > On 3/5/25 10:43 AM, David Marchand wrote: > > ../lib/vhost/vhost_crypto.c: In function > > ‘virtio_crypto_asym_rsa_der_to_xform’: > > ../lib/vhost/vhost_crypto.c:538:42: warning: comparison of integer > > expressions > > of different signedness: ‘long i

Re: [PATCH v3 00/16] net/zxdh: updated net zxdh driver

2025-03-04 Thread Thomas Monjalon
25/02/2025 17:12, Stephen Hemminger: > On Tue, 25 Feb 2025 18:42:52 +0800 > Junlong Wang wrote: > > Junlong Wang (16): > > net/zxdh: optimize np dtb channel initialization > > net/zxdh: optimize queue res alloc/free process > > net/zxdh: optimize link update process > > net/zxdh: update Rx

DPDK Summit CFP extended - last days

2025-03-04 Thread Thomas Monjalon
The next DPDK Summit will happen on May 8-9 in Prague, Czech Republic. The events team decided to extend the CFP period by one week to give you a little more chance to propose interesting talks. This is the very last week to submit on this page: https://events.linuxfoundation.org/dpdk-sum

Re: MPLS Push action

2025-03-03 Thread Thomas Monjalon
Hi, This is the related code: /** * RTE_FLOW_ACTION_TYPE_OF_PUSH_MPLS * * Implements OFPAT_PUSH_MPLS ("push a new MPLS tag") as defined by the * OpenFlow Switch Specification. */ struct rte_flow_action_of_push_mpls { rte_be16_t ethertype; /**< EtherType. */ }; > On Mon, Mar 3, 2025 at

DPDK Summit CFP reminder - last week

2025-02-25 Thread Thomas Monjalon
This is the last week to submit a talk proposal for the DPDK Summit happening on May 8-9 in Prague, Czech Republic. When your idea is ready, go to this page: https://events.linuxfoundation.org/dpdk-summit/program/cfp/ The CFP period closes on this Sunday, 2 March. The DPDK Summit is welc

Re: [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD

2025-02-22 Thread Thomas Monjalon
22/02/2025 00:05, Stephen Hemminger: > On Wed, 19 Feb 2025 15:55:17 +0100 > Thomas Monjalon wrote: > > > 14/02/2025 18:20, Stephen Hemminger: > > > The Linux version of sys/queue.h is frozen at an older version > > > and is missing the _SAFE macro

Re: [PATCH] config/arm: update NVIDIA BlueField-3 configuration

2025-02-19 Thread Thomas Monjalon
19/02/2025 17:35, Wathsala Wathawana Vithanage: > > Subject: [PATCH] config/arm: update NVIDIA BlueField-3 configuration > > > > ARM configuration requires explicit `mcpu` specifications in the implementor > > description. > > > > The patch adds `mcpu` and `flags` description for the NVIDIA > > B

Re: [PATCH] config/arm: add Phytium TengYun S5000c

2025-02-19 Thread Thomas Monjalon
13/02/2025 08:14, luzhipeng: > add support for Phytium tengyunS5000c > > Signed-off-by: luzhipeng Applied, thanks.

Re: Link custom libarchive meson support

2025-02-19 Thread Thomas Monjalon
11/02/2025 19:46, Ben Magistro: > Will acknowledge this may be more of a meson question and less of a DPDK > issue but things didn't seem to work as expected and had to tweak the > config/meson.build to want to start with the DPDK team. > > Our project is cmake based and we use fetch content to pu

Re: [PATCH v8] graph: mcore: optimize graph search

2025-02-19 Thread Thomas Monjalon
07/02/2025 02:39, Huichao Cai: > In the function __rte_graph_mcore_dispatch_sched_node_enqueue, > use a slower loop to search for the graph, modify the search logic > to record the result of the first search, and use this record for > subsequent searches to improve search speed. > > Signed-off-by:

Re: [PATCH] examples/flow_filtering: fix destination IP mask

2025-02-19 Thread Thomas Monjalon
12/01/2025 08:52, Shani Peretz: > This patch corrects the destination IP address mask to > restore the previous implementation's behavior. > > Also it fixes a misuse of rte_flow_item_tcp struct. > Replace it with the appropriate rte_flow_item_ipv4 struct, > as the code in this context filters ipv4

Re: [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD

2025-02-19 Thread Thomas Monjalon
14/02/2025 18:20, Stephen Hemminger: > The Linux version of sys/queue.h is frozen at an older version > and is missing the _SAFE macro variants. Several drivers started > introducing the own workarounds for this. Should be handled in EAL. > > Signed-off-by: Stephen Hemminger We may want to unify

Re: [PATCH v4 0/4] Introduce Topology NUMA grouping for lcores

2025-02-13 Thread Thomas Monjalon
13/02/2025 04:09, Varghese, Vipin: > [AMD Official Use Only - AMD Internal Distribution Only] > > Adding Thomas and Ajit to the loop. > > Hi Ajit, we have been using the patch series for identifying the topology and > getting l3 cache id for populating the steering tag for Device Specific Model

release candidate 25.03-rc1

2025-02-12 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v25.03-rc1 There are 478 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_25_03.html Highlights of 25.03-rc1: - Staged-Ordered ring (SORING)

Re: [PATCH] mbuf: enable to be compiled with MSVC

2025-02-12 Thread Thomas Monjalon
Mer 12 févr 2025, à 15:23, Thomas Monjalon a écrit : > 11/02/2025 03:19, Andre Muezerie: >> On Mon, Feb 10, 2025 at 02:34:29PM -0800, Stephen Hemminger wrote: >> > On Mon, 10 Feb 2025 13:51:05 -0800 >> > Andre Muezerie wrote: >> > >> > >

Re: [PATCH] doc: add release not for af_packet

2025-02-12 Thread Thomas Monjalon
22/01/2025 16:56, Stephen Hemminger: > +* **Enhancements to af_packet net driver.** > + > + Added ability to option to configure receive packet fanout mode. > + Improved statistics including failed receive buffer allocation > + and missed packets. Was squashed in relevant commits, thanks.

Re: [PATCH V1] doc: add tested Intel platforms two NICs

2025-02-12 Thread Thomas Monjalon
06/12/2024 06:39, Lingli Chen: > Add tested E825-C and I350 NICs to v24.11 release note. > > Signed-off-by: Lingli Chen Cc: sta...@dpdk.org Applied after the release, and can be backported, thanks.

Re: [PATCH] doc: add tested platforms with NVIDIA NICs

2025-02-12 Thread Thomas Monjalon
03/12/2024 08:59, Raslan Darawsheh: > Add tested platforms with NVIDIA NICs to the 24.11 release notes. > > Signed-off-by: Raslan Darawsheh Cc: sta...@dpdk.org Applied after the release, and can be backported, thanks.

Re: [PATCH] build: allow disabling avx512 support via compiler flag

2025-02-12 Thread Thomas Monjalon
11/02/2025 18:02, Stokes, Ian: > > DPDK build checks for build support for various instruction sets by > > checking both the target machine and the compiler for support. However, > > any disabling of instruction sets via compiler flags was not taken into > > account in many cases. For AVX512 suppor

Re: [PATCH v4] mbuf: add raw free and alloc bulk functions

2025-02-12 Thread Thomas Monjalon
30/01/2025 15:49, Morten Brørup: > When putting an mbuf back into its mempool, there are certain requirements > to the mbuf. Specifically, some of its fields must be initialized. > > These requirements are in fact invariants about free mbufs, held in > mempools, and thus also apply when allocating

Re: [PATCH] mbuf: enable to be compiled with MSVC

2025-02-12 Thread Thomas Monjalon
11/02/2025 03:19, Andre Muezerie: > On Mon, Feb 10, 2025 at 02:34:29PM -0800, Stephen Hemminger wrote: > > On Mon, 10 Feb 2025 13:51:05 -0800 > > Andre Muezerie wrote: > > > > > Now that the issues preventing this lib from be compiled with MSVC > > > are fixed it can be included in the compilatio

Re: [PATCH v2 1/2] mempool: fix rte_errno in rte_mempool_create_empty

2025-02-12 Thread Thomas Monjalon
07/02/2025 15:30, Konstantin Ananyev: > > > > > When returning from rte_mempool_set_ops_byname(), rte_errno is not set > > for error exits. > > > > The API requires rte_errno to be set in that case. > > > > Bugzilla ID: 1559 > > Fixes: c2c6b2f41305 ("mempool: fix default ops for an empty mempoo

Re: [PATCH 1/1] eal/linux: Remove unused values

2025-02-12 Thread Thomas Monjalon
13/01/2025 18:19, Ariel Otilibili: > Found by static analysis: > > In dev_uev_socket_fd_create(), fd is assigned before a return, > and not used. > > The same for the variables buf and i in dev_uev_parse(). > > Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle") > Fixes: 0d0f47

Re: raw/gdtc: use standard macros to optimize code style

2025-02-12 Thread Thomas Monjalon
10/12/2024 21:37, Stephen Hemminger: > On Tue, 10 Dec 2024 10:11:30 +0800 > Yong Zhang wrote: > > > Use RTE_BIT to optimize non-standard macro definitions > > > > Signed-off-by: Yong Zhang > > --- > > Code will end up the same, but it is easier to read. > > Acked-by: Stephen Hemminger Appli

Re: [PATCH v2] app/procinfo: add xstats parameter to hide zero

2025-02-12 Thread Thomas Monjalon
07/02/2025 04:13, Dengdui Huang: > The number of xstats may be large, after the hide zero parameter to > hide zero only non-zero values can be displayed. > > So display xstats with hide zero: > dpdk-proc-info --proc-type=secondary -- --xstats > and without hide zero: > dpdk-proc-info --pro

Re: [PATCH v3 00/19] minor fixes from PVS studio bug list

2025-02-12 Thread Thomas Monjalon
> Stephen Hemminger (19): > common/cnxk: remove duplicate condition > net/cpfl: avoid calling log (printf) with null > raw/cnxk_gpio: fix file descriptor leak > net/ntnic: remove dead code > net/i40e: remove duplicate code > eal: fix out of bounds access in devargs > net/qede: fix mis

Re: [PATCH v3 1/2] config/arm: strict use of -mcpu for supported CPUs

2025-02-11 Thread Thomas Monjalon
06/01/2025 19:31, Wathsala Vithanage: > Arm recommends using -mcpu over -march and march-extensions when the > compiler supports the target CPU (neoverse-n1 etc.). Arm build so far > has been an amalgam of -mcpu and -march. When march is in use, it has > been the case so far to silently fall back t

Re: [RFC] git: consolidate .gitignore files

2025-02-11 Thread Thomas Monjalon
10/02/2025 18:20, Stephen Hemminger: > +# ignore Linux UAPI kernel headers > +kernel/linux/uapi/version > +kernel/linux/uapi/**/*.h The original .gitignore had some "!" for an opposite logic. I think we can just completely drop this one, it looks unneeded.

Re: [PATCH] devtools: ignore .gitignore in SPDX check

2025-02-10 Thread Thomas Monjalon
07/02/2025 19:26, Stephen Hemminger: > New .gitignore file in dts was getting marked as error. > Change to ignore all .gitignore files. Actually I would prefer we don't create too much .gitignore files. It is easier to manage if we have all in a single .gitignore. We have already a line for DTS in

[PATCH] drivers: allow build with VLAs

2025-02-08 Thread Thomas Monjalon
ariable length array 'requests_crp' [-Werror=vla] 865 | struct sam_cio_op_params requests_crp[nb_ops]; Fixes: 1bf86800f7da ("build: warn on uses of VLA") Signed-off-by: Thomas Monjalon --- drivers/crypto/mvsam/meson.build | 2 ++ drivers/net/mvpp2/meson.build| 2 ++ drivers/

Re: [PATCH v5 1/4] bus/pci: fix registration of PCI device

2025-02-06 Thread Thomas Monjalon
ch fix this issue by saving the parsed PCI in device->name, > so when a new PCI device is registering the name displayed in the device > list will be the parsed version. > > Fixes: 23eaa9059ec2 ("bus/pci: use given name as generic name") > > Cc: sta...@dpdk.org > Signed-off-by: Shani Peretz It's way simpler. Acked-by: Thomas Monjalon

Re: [PATCH v3 1/2] config/arm: strict use of -mcpu for supported CPUs

2025-02-05 Thread Thomas Monjalon
06/01/2025 19:31, Wathsala Vithanage: > +'mcpu_generic_aarch32': { > +'march': 'armv8-a', > +'march_extensions': ['simd'], > +} > +'mcpu_thunderx2t99': { > +'march': 'armv8.1-a', > +'march_extensions': ['crc', 'crypto'] > +}, A comma is missing. I c

  1   2   3   4   5   6   7   8   9   10   >