Re: [PATCH] maintainers: update for DTS

2025-07-25 Thread Thomas Monjalon
22/07/2025 18:05, Luca Vizzarro: > Paul is giving up his role of co-maintainer of DTS, electing Luca > Vizzarro in his place. > > Signed-off-by: Luca Vizzarro Acked-by: Paul Szczepanek Acked-by: Patrick Robb Applied, thank you for volunteering.

Re: [PATCH] net/mlx5: deprecate representor matching devarg

2025-07-23 Thread Thomas Monjalon
23/07/2025 11:07, Adrian Schollmeyer: > Hi, > > On 16.07.25 11:38, Dariusz Sosnowski wrote: > > > Mark repr_matching_en device argument exposed by mlx5 PMD > > as deprecated and schedule its removal in 25.11 release. > > > > [...] > > > > A new unified representor model, described in > > https://

DPDK 25.07 released

2025-07-21 Thread Thomas Monjalon
A new major release is available: https://fast.dpdk.org/rel/dpdk-25.07.tar.xz It was a small release cycle: 806 commits from 133 authors 1685 files changed, 94020 insertions(+), 27600 deletions(-) It is not planned to start a maintenance branch for 25.07. This version is A

Re: [PATCH] doc: announce changes in structure alignments for UBSan

2025-07-21 Thread Thomas Monjalon
09/07/2025 14:40, David Marchand: > As part of the effort to limit undefined behaviors in DPDK code, some > structure alignments revealed not to be accurate enough. > At the moment two structures have been identified but others may be > found while running more parts of DPDK with UBSan. > > Though

Re: [PATCH v2] net/intel: deprecate some SSE paths

2025-07-21 Thread Thomas Monjalon
03/07/2025 16:31, Ciara Loftus: > The SSE rx and tx paths will be removed from the i40e, iavf and ice > drivers in the 25.11 release. Each of these drivers have faster vector > paths (AVX2 and AVX-512) which have feature parity with the soon to be > removed SSE paths. In environments where AVX2 or

Re: [PATCH] net/mlx5: deprecate representor matching devarg

2025-07-21 Thread Thomas Monjalon
16/07/2025 11:38, Dariusz Sosnowski: > Mark repr_matching_en device argument exposed by mlx5 PMD > as deprecated and schedule its removal in 25.11 release. > > Functionality exposed by this device argument does not fit > current E-Switch representor model exposed by DPDK. > A new unified represent

Re: [PATCH v0 1/1] doc: announce inter-device DMA capability support in dmadev

2025-07-21 Thread Thomas Monjalon
10/07/2025 10:51, Vamsi Krishna: > From: Vamsi Attunuru > > Modern DMA hardware supports data transfer between multiple > DMA devices, enabling data communication across isolated domains or > containers. To facilitate this, the ``dmadev`` library requires changes > to allow devices to register wi

Re: [EXTERNAL] [PATCH] doc: announce DMA configuration structure changes

2025-07-21 Thread Thomas Monjalon
> Deprecate rte_dma_conf structure to allow for a more flexible > configuration of DMA devices. > The new structure will have a flags field instead of multiple > boolean fields for each feature. > > Signed-off-by: Pavan Nikhilesh > --- > +* dmadev: The ``rte_dma_c

Re: [PATCH] rcu: add deprecation notice about limit on defer queue element size

2025-07-21 Thread Thomas Monjalon
14/07/2025 11:01, Konstantin Ananyev: > > 10/07/2025 16:37, Andre Muezerie: > > > On Tue, Jul 01, 2025 at 04:17:20PM +0200, Thomas Monjalon wrote: > > > > 23/05/2025 01:37, Andre Muezerie: > > > > > The functions rte_rcu_qsbr_dq_create and rte_rcu_qsbr_dq

Re: [PATCH] doc: announce mbuf fast free configuration requirements

2025-07-21 Thread Thomas Monjalon
15/07/2025 17:12, Konstantin Ananyev: > > > For TX mbuf fast release offload, the mbuf mempool pointer will be added > > to the ethdev tx queue configuration structure, so the ethdev TX burst > > operation doesn't need to fetch it from the first mbuf of each burst being > > fast free'd to the memp

Re: [PATCH v2] doc: update kernel version requirement

2025-07-21 Thread Thomas Monjalon
21/07/2025 12:45, Kevin Traynor: > On 10/04/2025 16:20, Stephen Hemminger wrote: > > The 4.19 kernel version was end of life in December 2024. > > Update to 5.4 and also add better description of what "not supported" > > means in this case. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: M

Re: [RFC] doc: change recommendation for installation of tools on Fedora

2025-07-21 Thread Thomas Monjalon
09/06/2025 05:03, Stephen Hemminger: > The syntax changed with Fedora 41 and the old command is now: > $ sudo dnf group install development-tools > > Not sure what is on RHEL 9 or later. [...] > -* For RHEL/Fedora systems these can be installed using ``dnf > groupinstall "Development Tools"``

Re: [PATCH] doc: install guides and api docs to different directories

2025-07-21 Thread Thomas Monjalon
06/01/2025 11:30, Bruce Richardson: > On Mon, Dec 23, 2024 at 03:38:40PM +, luca.bocca...@gmail.com wrote: > > From: Luca Boccassi > > > > Otherwise they both get installed to /usr/share/doc/dpdk/html/ and overwrite > > each other's files > > > > Signed-off-by: Luca Boccassi > > Acked-by:

Re: [PATCH v3] mailmap: add new email to DPDK

2025-07-21 Thread Thomas Monjalon
19/07/2025 17:17, Pravin Pathak: > Adding new mail for DPDK contribution > > Signed-off-by: Pravin Pathak > --- > -Pravin Pathak > +Pravin Pathak Applied, thanks.

Re: [PATCH] mailmap: keep only one name per contributor

2025-07-21 Thread Thomas Monjalon
21/07/2025 18:06, Bruce Richardson: > On Mon, Jul 21, 2025 at 05:44:01PM +0200, David Marchand wrote: > > Some duplicates have slipped in the mailmap file. > > Clean this up. > > > > Signed-off-by: David Marchand > Acked-by: Bruce Richardson Applied, thanks.

Re: [PATCH] buildtools/check-git-log: print expected driver prefix

2025-07-21 Thread Thomas Monjalon
24/01/2025 18:24, Bruce Richardson: > When outputting an error for an invalid log prefix, don't just tell the > user that the prefix is wrong - also tell them what the expected prefix > should be. > > Signed-off-by: Bruce Richardson Applied (with fixed prefix :), thanks.

Re: [PATCH] devtools: forbid use of compiler pragmas

2025-07-21 Thread Thomas Monjalon
30/01/2025 09:52, David Marchand: > On Thu, Jan 30, 2025 at 9:45 AM Morten Brørup > wrote: > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Thursday, 30 January 2025 09.38 > > > > > > Using pragma must be prevented to avoid breaking builds with other > > > compilers.

Re: [PATCH] devtools: exclude atomic checks for common cnxk

2025-07-21 Thread Thomas Monjalon
12/06/2025 15:39, Jerin Jacob: > On Thu, Mar 27, 2025 at 4:50 PM wrote: > > > > From: Pavan Nikhilesh > > > > Since driver/common/cnxk has common code that is > > used across multiple platforms, allow use of > > GCC builtin atomic functions. > > > > Signed-off-by: Pavan Nikhilesh > > Acked-by:

Re: [PATCH v2] ethdev: Align enable logic handling with disable functions

2025-07-21 Thread Thomas Monjalon
21/07/2025 15:05, Sunyang Wu: > This patch modifies the handling logic of the "enable" related > operations. The key intention is to align it with the processing > approach of the "disable" functions. > Previously, there was an inconsistency in how failure scenarios were > dealt with between the "e

Re: [PATCH] mailmap: fix entries with many aliases

2025-07-21 Thread Thomas Monjalon
16/07/2025 16:41, David Marchand: > According to gitmailmap manual, a line is composed of a contact > information followed by commit information. > > Which translates to the following formats: > Proper Name > > Proper Name > Proper Name Commit Name > > Some lines had multiple commit infos

Re: 回复: [PATCH] ethdev: keep promiscuous/allmulti value before enabling

2025-07-21 Thread Thomas Monjalon
21/07/2025 14:13, Sunyang Wu: > Hi, Thomas: > Thanks for your note. The main purpose of this modification is to align the > handling logic with the "disable" functions, > aiming to enhance the overall consistency and maintainability of the code. > > Previously, the handling of failure scenarios i

Re: [PATCH] ethdev: keep promiscuous/allmulti value before enabling

2025-07-21 Thread Thomas Monjalon
21/07/2025 13:51, Sunyang Wu: > The values of the promiscuous and allmulticast variables > are set after calling the driver, according to the return value. > > Fixes: 400d75818266 ("ethdev: check device promiscuous state") > de5ccf0775ae ("ethdev:do nothing if all-multicast mode is applied > again

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Thomas Monjalon
21/07/2025 13:46, Ivan Malov: > On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: > > > + mlx5 maintainers > > > > Thank you for the patch. > > > > Could you please include other PMD maintainers (or other maintainers, > > depending on changed code) > > in the future patches? > > There is a script whi

Re: [PATCH v7 7/8] trace: add PMU

2025-07-21 Thread Thomas Monjalon
21/07/2025 12:24, Tomasz Duszynski: > > On Fri, Jun 27, 2025 at 5:41 PM Tomasz Duszynski > > wrote: > > > > > > In order to profile app, one needs to store significant amount of samples > > > somewhere for an analysis later on. > > > Since trace library supports storing data in a CTF format, > >

Re: [PATCH] maintainers: update for dlb2

2025-07-21 Thread Thomas Monjalon
> > Subject: [PATCH] maintainers: update for dlb2 > > > > Add myself as maintainer for dlb2. > > > > Signed-off-by: Tirthendu Sarkar > Acked-by: Pravin Pathak Applied, thanks.

Re: [PATCH] maintainers: update for ethdev library

2025-07-21 Thread Thomas Monjalon
15/07/2025 17:10, Ferruh Yigit: > On 7/11/2025 3:43 PM, Thomas Monjalon wrote: > > Ferruh Yigit has no time this year for ethdev maintenance. > > > > Signed-off-by: Thomas Monjalon > > --- > > MAINTAINERS | 1 - > > 1 file changed, 1 deletion(-) > >

Re: [PATCH] doc: add tested platforms with NVIDIA NICs

2025-07-21 Thread Thomas Monjalon
14/07/2025 08:38, Raslan Darawsheh: > Add tested platforms with NVIDIA NICs to the 25.07 release notes. > > Signed-off-by: Raslan Darawsheh Applied, thanks.

Re: [PATCH V1] doc: add tested Intel platforms with Intel NICs

2025-07-21 Thread Thomas Monjalon
15/07/2025 07:57, Yu Jiang: > Add tested Intel platforms with Intel NICs to v25.07 release note. > > Signed-off-by: Yu Jiang Applied, thanks.

Re: [PATCH v2] net/ice: updated latest recommended matching list

2025-07-21 Thread Thomas Monjalon
18/07/2025 12:48, Bruce Richardson: > On Fri, Jul 18, 2025 at 10:00:08AM +0800, hailinx wrote: > > Signed-off-by: hailinx > > --- > > doc/guides/nics/ice.rst | 23 +-- > > 1 file changed, 21 insertions(+), 2 deletions(-) > > > Acked-by: Bruce Richardson Applied, thanks.

Re: [PATCH v1] net/i40e: updated latest recommended matching list

2025-07-21 Thread Thomas Monjalon
18/07/2025 12:51, Bruce Richardson: > On Thu, Jul 17, 2025 at 02:16:03PM +0800, hailinx wrote: > > Signed-off-by: hailinx > > --- > Acked-by: Bruce Richardson Applied, thanks.

Re: [PATCH v1] net/ixgbe: add nic and updated recommended matching list

2025-07-21 Thread Thomas Monjalon
18/07/2025 14:13, David Marchand: > On Thu, Jul 17, 2025 at 8:55 AM hailinx wrote: > > > > Signed-off-by: hailinx Please make sure to have your name here as Hailin Xu. > > --- > > doc/guides/nics/ixgbe.rst | 21 + > > 1 file changed, 21 insertions(+) > > > > diff --git a/do

Re: [PATCH] eal: add description of service corelist in usage

2025-07-20 Thread Thomas Monjalon
17/07/2025 11:51, Bruce Richardson: > On Thu, Jul 17, 2025 at 11:42:32AM +0200, David Marchand wrote: > > The -S option is not described in EAL usage(). > > > > Fixes: 7dbd7a6413ef ("service: add -S corelist option") > > Cc: sta...@dpdk.org > > > > Signed-off-by: David Marchand > Acked-by: Bruce

Re: [PATCH 2/2] doc: use common description of EAL parameters

2025-07-20 Thread Thomas Monjalon
17/07/2025 14:15, Bruce Richardson: > On Thu, Jul 17, 2025 at 01:46:04PM +0200, David Marchand wrote: > > Rather than have a subset of the EAL parameters described in the sample > > apps documentation, prefer referring to the full list. > > > > Signed-off-by: David Marchand > > --- > Acked-by: Br

Re: [PATCH v3 0/2] cpu0 and memory channels doc update

2025-07-20 Thread Thomas Monjalon
15/07/2025 23:56, Stephen Hemminger: > This is revised version of earlier patches to address > some guidance about CPU and memory channels in the documentation. > > Stephen Hemminger (2): > doc: add note about CPU 0 > doc: remove use of '-n 4' option in documentation examples Applied, thanks.

Re: [PATCH v3] net/mlx5: remove use of sizeof(rte_v128u32_t)

2025-07-20 Thread Thomas Monjalon
09/07/2025 09:26, Dariusz Sosnowski: > Thank you for addressing the comments. > > On Tue, Jul 08, 2025 at 08:11:56AM -0700, Andre Muezerie wrote: > > When compiling with MSVC the error below is hit: > > > > drivers\net\mlx5\mlx5_tx.h(1148): error C2065: 'rte_v128u32_t': > > undeclared identif

Re: [PATCH v2] doc: update parameters to use for mlx5 on Windows

2025-07-20 Thread Thomas Monjalon
15/07/2025 16:14, Andre Muezerie: > The linker parameters to use with MSVC and Clang differ. > Showing explicitly what to use with each in the documentation. > > Signed-off-by: Andre Muezerie Acked-by: Patrick Robb Acked-by: Dariusz Sosnowski Applied, thanks.

Re: [PATCH] doc: Document frequency and volume limits on patches.

2025-07-20 Thread Thomas Monjalon
17/04/2025 20:12, Aaron Conole: > The DPDK project has two constrained resources - reviewers and > public CI infrastructure. These are shared among the entire > project, and there are true costs associated with using these > resources. Thus, there are two motivations behind this change: > - Enc

Re: [PATCH] doc/contributing: remove obsolete advice in coding std

2025-07-20 Thread Thomas Monjalon
27/03/2025 17:28, Bruce Richardson: > Remove obsolete, and generally not followed, advice in the coding > standards doc, around local variables. > > Signed-off-by: Bruce Richardson Applied, thanks.

Re: [PATCH] doc/linux_gsg: add build instructions for new Arm SoCs

2025-07-20 Thread Thomas Monjalon
16/05/2025 20:53, Doug Foster: > Add explanation of recent build configuration changes for Arm SoCs and > instructions for adding a build configuration for a new Arm SoC. > > Signed-off-by: Doug Foster > Reviewed-by: Wathsala Vithanage > Reviewed-by: Dhruv Tripathi Reworded a little to make si

Re: [PATCH] doc: update ABI reference version in example

2025-07-20 Thread Thomas Monjalon
29/05/2025 01:30, Stephen Hemminger: > The example should list current ABI reference version. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/contributing/patches.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/guides/contributing/patches.rst > b/doc/gu

Re: [PATCH] doc: remove the public interfaces from bus/vmbus

2025-07-20 Thread Thomas Monjalon
03/06/2025 02:31, lon...@linuxonhyperv.com: > From: Long Li > > The deprecation notice has been sent in > 7642e3b0e0 ("doc: announce vmbus API deprecation") > > Remove those interfaces in this release. > > Signed-off-by: Long Li > --- > doc/guides/rel_notes/release_25_07.rst | 3 ++- > 1 file

Re: [PATCH v3] doc: reword glossary

2025-07-20 Thread Thomas Monjalon
02/12/2024 06:23, Nandini Persad: > I added additional reference links and definitions to many > of the terms in the glossary. Please feel free to provide > feedback to ensure my definitions suit the proper context > in the DPDK community. > > Signed-off-by: Nandini Persad I've improved consiste

Re: [PATCH v2] mailmap: add new email to DPDK

2025-07-20 Thread Thomas Monjalon
19/07/2025 06:21, Pravin Pathak: > Adding new mail for DPDK contribution > > Signed-off-by: Pravin Pathak > --- > .mailmap | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.mailmap b/.mailmap > index c7d55c7386..1c5c367f6c 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -1

Re: [PATCH 0/4] rework mlx5 guide

2025-07-18 Thread Thomas Monjalon
18/07/2025 00:05, Thomas Monjalon: > The main mlx5 doc (for net driver) is improved > with better explanations, better organization, better readability, > and will be a better skeleton for future detailed explanations. > > Maayan Kashani (1): > doc: add testpmd command exam

Re: [PATCH 0/4] rework mlx5 guide

2025-07-18 Thread Thomas Monjalon
18/07/2025 17:36, Stephen Hemminger: > Looks better, it would be good to look at the table of contents > (right column in html) to see if could be better in complex document > like this. Yes I've paid attention to the table of contents. Thanks for the suggestions below. > For example the Usage, d

[PATCH 2/4] doc: add table styles for guides

2025-07-17 Thread Thomas Monjalon
Add 2 style classes for tables: - numbered-table: numbering table rows - punchcard: colouring filled cells They can be used by inserting the class comment before the table: .. rst-class:: numbered-table .. rst-class:: punchcard Signed-off-by: Thomas Monjalon --- doc/guides

[PATCH 1/4] doc: simplify mlx5 devices lists

2025-07-17 Thread Thomas Monjalon
No need to list all devices of a family. Instead, a list of families is given with technical details. Signed-off-by: Thomas Monjalon --- doc/guides/nics/mlx4.rst | 5 +- doc/guides/nics/mlx5.rst | 91 +--- doc/guides/platform/mlx5.rst | 9 ++-- doc

[PATCH 0/4] rework mlx5 guide

2025-07-17 Thread Thomas Monjalon
The main mlx5 doc (for net driver) is improved with better explanations, better organization, better readability, and will be a better skeleton for future detailed explanations. Maayan Kashani (1): doc: add testpmd command examples in mlx5 guide Thomas Monjalon (3): doc: simplify mlx5

[PATCH 4/4] doc: add testpmd command examples in mlx5 guide

2025-07-17 Thread Thomas Monjalon
From: Maayan Kashani Adding testpmd command examples to mlx5 guide, either inline if short enough or using external links to a GitHub repository hosting tests. Signed-off-by: Maayan Kashani --- doc/guides/nics/mlx5.rst | 138 +++ 1 file changed, 138 insertio

Re: [PATCH] doc: remove Mellanox acquisition explanation

2025-07-17 Thread Thomas Monjalon
16/07/2025 12:15, Thomas Monjalon: > Time has passed since Mellanox acquisition by NVIDIA. > No need to explain this anymore. > > Signed-off-by: Thomas Monjalon Applied

Re: [PATCH] examples/multi_process: revert ports cleanup on exit

2025-07-17 Thread Thomas Monjalon
15/07/2025 14:11, Thomas Monjalon: > When closing the primary process, an error occurs when closing ports: > > Error closing ports > EAL: failed to send to (/var/run/dpdk/dpdk_X/mp_socket_Y) due to Bad file > descriptor > EAL: Fail to send request /var/run/dpdk/dpdk_X/mp_socke

Re: [PATCH] examples/multi_process: fix cleanup on exit

2025-07-17 Thread Thomas Monjalon
09/07/2025 17:01, Stephen Hemminger: > On Tue, 8 Jul 2025 10:09:54 +0300 > Maayan Kashani wrote: > > > +static void > > +exit_cleanup(void) > > +{ > > + unsigned int i; > > + > > + RTE_LOG(INFO, APP, "Close ports.\n"); > > + for (i = 0; i < num_ports; i++) { > > + if (rte_eal_proc

Re: [PATCH] doc: make table headers more visible in guides

2025-07-17 Thread Thomas Monjalon
16/07/2025 12:14, Thomas Monjalon: > Set a background color to table header > so that it is visually easier to read. > > Signed-off-by: Thomas Monjalon Applied

Re: [PATCH] doc: remove Mellanox acquisition explanation

2025-07-16 Thread Thomas Monjalon
16/07/2025 12:37, Bruce Richardson: > On Wed, Jul 16, 2025 at 12:15:16PM +0200, Thomas Monjalon wrote: > > Time has passed since Mellanox acquisition by NVIDIA. > > No need to explain this anymore. > > > > Signed-off-by: Thomas Monjalon > > --- > >

[PATCH] doc: remove Mellanox acquisition explanation

2025-07-16 Thread Thomas Monjalon
Time has passed since Mellanox acquisition by NVIDIA. No need to explain this anymore. Signed-off-by: Thomas Monjalon --- doc/guides/compressdevs/mlx5.rst | 7 --- doc/guides/cryptodevs/mlx5.rst| 7 --- doc/guides/nics/mlx4.rst | 7 --- doc/guides/nics/mlx5.rst

[PATCH] doc: make table headers more visible in guides

2025-07-16 Thread Thomas Monjalon
Set a background color to table header so that it is visually easier to read. Signed-off-by: Thomas Monjalon --- doc/guides/custom.css | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/custom.css b/doc/guides/custom.css index b662abb34e..7db37ffc68 100644 --- a/doc/guides

[PATCH] examples/multi_process: revert ports cleanup on exit

2025-07-15 Thread Thomas Monjalon
Song Jiale Signed-off-by: Thomas Monjalon --- examples/multi_process/symmetric_mp/main.c | 27 -- 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index de16608a0f..f7d8439cd4 10

[PATCH] maintainers: update for ethdev library

2025-07-11 Thread Thomas Monjalon
Ferruh Yigit has no time this year for ethdev maintenance. Signed-off-by: Thomas Monjalon --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0e9357f3a3..b96496adb7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -435,7 +435,6 @@ F: app/test

Re: [PATCH] rcu: add deprecation notice about limit on defer queue element size

2025-07-11 Thread Thomas Monjalon
10/07/2025 16:37, Andre Muezerie: > On Tue, Jul 01, 2025 at 04:17:20PM +0200, Thomas Monjalon wrote: > > 23/05/2025 01:37, Andre Muezerie: > > > The functions rte_rcu_qsbr_dq_create and rte_rcu_qsbr_dq_reclaim establish > > > no limit on the size of each element in the

DPDK release candidate 25.07-rc3

2025-07-09 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v25.07-rc3 There are 86 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_25_07.html Please test and report new issues on https://bugs.dpdk.org Only docu

Re: [PATCH v3] doc: remove known issues

2025-07-09 Thread Thomas Monjalon
11/04/2025 18:15, Nandini Persad: > I have uploaded all these known issues into Bugzilla, > so they are not needed here anymore. > > Signed-off-by: Nandini Persad Applied, thanks.

Re: [PATCH v2 2/2] dts: rewrite dts rst

2025-07-09 Thread Thomas Monjalon
25/06/2025 06:07, Patrick Robb: > Applied to next-dts, thanks Dean. I'm almost sure it has overriden some doc added recently by Nicholas Pratte. Anyway it is too difficult to understand what is changed in this series, because there are too many unrelated changes. I prefer not pulling this series

Re: [PATCH] examples/ipsec-secgw: fix number of queue pairs

2025-07-09 Thread Thomas Monjalon
09/07/2025 10:23, Volodymyr Fialko: > Fix a mismatch between the signature of the cryptodevs_init() function > and the arguments passed to it during the call. This caused incorrect > initialization of queue pairs in ipsec-secgw example. > > Fixes: 253265f8fb97 ("examples/ipsec-secgw: reduce queues

Re: [PATCH] examples/flow_filtering: add re-route to kernel snippet

2025-07-09 Thread Thomas Monjalon
21/05/2025 09:27, Shani Peretz: > The snippet enables direct packet re-routing to kernel by using > the new RTE_FLOW_ACTION_TYPE_SEND_TO_KERNEL action. > > Added support for snippet-specific configurations: > * port configuration: set promiscuous mode / flow isolation mode > * Flow configurati

Re: [PATCH] examples/flow_filtering: fix make clean

2025-07-09 Thread Thomas Monjalon
> > make clean is unable to delete build directory because *.o files are not > > removed. > > > > The other way to fix this would be to add all the c files into SRCS-y. > > > > Signed-off-by: Tanzeel Ahmed > > I checked and looks good on my side Applied with fixes line, thanks.

Re: [PATCH] examples/ntb: fix the heap allocation check

2025-07-09 Thread Thomas Monjalon
21/05/2025 19:23, Bing Zhao: > In some rare case, the libc memory heap allocation may fail and > return NULL pointer. Before accessing the memory via the pointer, > the NULL pointer check should be done to ensure the code locates > in the safe side and no crash. > > Some newer GCC version will che

Re: [PATCH] examples/multi_process: fix cleanup on exit

2025-07-09 Thread Thomas Monjalon
09/07/2025 15:30, Burakov, Anatoly: > On 7/8/2025 9:09 AM, Maayan Kashani wrote: > > Device was started but not stopped on exit signal. > > Added port stop and close on exit. > > > > Fixes: af75078fece3 ("first public release") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Maayan Kashani > > --

Re: [PATCH] examples/symmetric_mp: log/ignore promiscuous fail

2025-07-09 Thread Thomas Monjalon
20/05/2025 20:37, mamcg...@microsoft.com: > From: Matthew G McGovern > > The example apps have a few different failure modes when enabling promiscuous > mode: > > - testpmd will warn about the failure and continue. > > - l3fwd has a flag '-P' to explicitly require promiscuous mode. > > - symm

Re: [PATCH v1 1/1] net/iavf: fix order of inclusion in vector code

2025-07-09 Thread Thomas Monjalon
09/07/2025 15:28, Bruce Richardson: > On Wed, Jul 09, 2025 at 02:06:29PM +0100, Anatoly Burakov wrote: > > IAVF driver does not support 16-byte descriptors (because there is no PF > > that can support a VF using 16-byte descriptor), but if IAVF is built with > > a flag that enables 16-byte descript

Re: [PATCH] bus/auxiliary: fix auxiliary device port destruction

2025-07-09 Thread Thomas Monjalon
07/07/2025 12:06, Gregory Etelson: > DPDK auxiliary bus first creates a list of known devices in the > `auxiliary_bus.device_list` and then tries to attach a driver to each > device on that list. > > If the driver attachment has failed, a device will remain on the list. > > The device destruction

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-07-03 Thread Thomas Monjalon
The best is to have only rte_pcapng to depend on libpcap, as you did. If the problem is only in ABI check, this is what we need to fix. I'm not sure how to fix this. > From: Thomas Monjalon > Sent: Thursday, July 3, 2025 7:27 AM > To: Dylan Schneider > Cc: dev@dpdk.org ; Res

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-07-03 Thread Thomas Monjalon
kip these libraries if they are not built? > Or better question: How does the abi-check even know about these libraries if > they are never built? > > Thanks! > Dylan > > > > From: Thomas Monjalon > Sent: Monday, June 30, 2025 8:28

Re: [PATCH v3] build/x86: fix support for older compilers

2025-07-03 Thread Thomas Monjalon
03/07/2025 12:21, Bruce Richardson: > Some older compilers e.g. gcc 8.5, do not support overriding > -march=native with another architecture, leading to build warnings such > as reported in Bugzilla (link below). Add a check for that case, and > explicitly add the avx512 flags if necessary. > > No

Re: [PATCH] node: fix C++ compatibility errors (option 2)

2025-07-02 Thread Thomas Monjalon
01/07/2025 16:48, Nitin Saxena: > On Mon, Jun 30, 2025 at 4:27 PM Bruce Richardson > wrote: > > > > C++ does not allow zero-sized unions - they end up being of size 1-byte, > > which leads to C/C++ compatibility issues, flagged by the compiler. > > > > lib/node/rte_node_mbuf_dynfield.h:78:2: err

Re: [PATCH] test/event: disable vector adapter test

2025-07-01 Thread Thomas Monjalon
01/07/2025 15:44, Bruce Richardson: > On Tue, Jul 01, 2025 at 03:15:24PM +0200, Thomas Monjalon wrote: > > This test triggers failures in the CI: > > > > event_vector_adapter_autotest FAIL > > 3.39s (exit status 255 or signal 127 SIGinvalid) > > &

Re: [PATCH] rcu: add deprecation notice about limit on defer queue element size

2025-07-01 Thread Thomas Monjalon
23/05/2025 01:37, Andre Muezerie: > The functions rte_rcu_qsbr_dq_create and rte_rcu_qsbr_dq_reclaim establish > no limit on the size of each element in the defer queue. Very good, we need more unlimited API in DPDK. > With DPDK 25.11 a hard limit will be set (``RTE_QSBR_ESIZE_MAX``). I think it

Re: [EXT] Re: [v4 07/10] net/dpaa: add Tx rate limiting DPAA PMD API

2025-07-01 Thread Thomas Monjalon
01/07/2025 13:42, Vanshika Shukla: > From: Stephen Hemminger > > On Wed, 11 Jun 2025 12:40:36 +0530 > > vanshika.shu...@nxp.com wrote: > > > > > From: Vinod Pullabhatla > > > > > > Add support to set Tx rate on DPAA platform through PMD APIs > > > > > > Signed-off-by: Vinod Pullabhatla > > > Si

[PATCH] test/event: disable vector adapter test

2025-07-01 Thread Thomas Monjalon
This test triggers failures in the CI: event_vector_adapter_autotest FAIL 3.39s (exit status 255 or signal 127 SIGinvalid) Disable it until we have a fix. Bugzilla ID: 1720 Fixes: 2eca0f4cd5da ("test/event: fix event vector adapter timeouts") Signed-off-by: Thoma

Re: [PATCH] node: fix C++ compatibility errors (option 2)

2025-07-01 Thread Thomas Monjalon
30/06/2025 12:50, Bruce Richardson: > C++ does not allow zero-sized unions - they end up being of size 1-byte, > which leads to C/C++ compatibility issues, flagged by the compiler. > > lib/node/rte_node_mbuf_dynfield.h:78:2: error: union has size 0 in C, > size 1 in C++ [-Werror,-Wextern-c-compa

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-30 Thread Thomas Monjalon
15:50, Dylan Schneider: > Hey Thomas, just wanted to confirm, I see the ARM build passing in CI. Is > there a reason it would pass there but not on your dev machine? > > > > From: Dylan Schneider > Sent: Friday, June 27, 2025 11:46 AM > T

release candidate 25.07-rc2

2025-06-29 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v25.07-rc2 There are 141 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_25_07.html Most significant changes are in multiple drivers. Please test and r

Re: [PATCH] build: error out when missing elftools python module

2025-06-29 Thread Thomas Monjalon
27/06/2025 17:27, Bruce Richardson: > In the case where we use the meson python "find_installation()" function > to get our python binary, we can fail the configure/setup step if the > elftools module is missing. This avoids later errors on build when the > module is missed. > > Old output (error

Re: [PATCH] buildtools/get-test-suites.py: muti-line macros

2025-06-29 Thread Thomas Monjalon
18/06/2025 14:39, Marat Khalili: > Test list is currently generated by scanning all files for macros > starting with `REGISTER_` and ending with `_TEST`. Unfortunately, this > was done line-by-line, and macros split into several lines were silently > ignored resulting in tests being excluded from t

Re: [PATCH] doc: fix missing feature matrix for event device

2025-06-29 Thread Thomas Monjalon
16/06/2025 17:05, Jerin Jacob: > On Mon, Jun 16, 2025 at 2:02 PM wrote: > > > > From: Pavan Nikhilesh > > > > Fix missing feature matrix addition for event device DMA and > > vector adapters. > > > > Fixes: 66a30a29387a ("eventdev/dma: introduce DMA adapter") > > Fixes: e12c3754da7a ("eventdev/ve

Re: [PATCH] more replace memcpy with structure assignment

2025-06-29 Thread Thomas Monjalon
12/06/2025 05:08, Stephen Hemminger: > Prefer using simple structure assignment instead of memcpy. > Using a structure assignment preserves type information and > compiler checks types already. > > Signed-off-by: Stephen Hemminger Applied, thanks.

Re: [PATCH v3 0/3] handle sysconf(_SC_PAGESIZE) negative return value

2025-06-29 Thread Thomas Monjalon
24/06/2025 10:03, Morten Brørup: > Coverity reports some defects, where the root cause seems to be negative > return value from sysconf(_SC_PAGESIZE) not being handled. > This series addresses those defects in the DPDK libraries. > > PS: "_SC_PAGESIZE" has the alias "_SC_PAGE_SIZE". Both are cover

Re: [PATCH v5 0/5] Use consecutive Tx queues' memory

2025-06-29 Thread Thomas Monjalon
> Bing Zhao (5): > net/mlx5: add new devarg for Tx queue consecutive memory > net/mlx5: calculate the memory length for all Tx queues > net/mlx5: allocate and release unique resources for Tx queues > net/mlx5: pass the information in Tx queue start > net/mlx5: use consecutive memory for T

Re: [PATCH] ethdev: sync ethtool link modes with Linux 6.15

2025-06-29 Thread Thomas Monjalon
26/06/2025 17:13, Thomas Monjalon: > 26/06/2025 16:26, Stephen Hemminger: > > On Wed, 25 Jun 2025 15:42:02 +0200 > > Thomas Monjalon wrote: > > > > > diff --git a/lib/ethdev/ethdev_linux_ethtool.c > > > b/lib/ethdev/ethdev_linux_ethtool.c > > >

Re: [PATCH v3 2/3] eal: handle sysconf(_SC_PAGESIZE) negative return value

2025-06-29 Thread Thomas Monjalon
29/06/2025 00:49, Stephen Hemminger: > On Sat, 28 Jun 2025 18:45:44 +0200 > Morten Brørup wrote: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Friday, 27 June 2025 20.30 > > > > > > 27/06/2025 19:49, Morten Brørup:

Re: [PATCH] test/event: fix event vector adapter timeouts

2025-06-27 Thread Thomas Monjalon
27/06/2025 09:53, Jerin Jacob: > On Thu, Jun 19, 2025 at 6:52 PM Pavan Nikhilesh Bhagavatula > wrote: > > > > >Sent: Thursday, June 12, 2025 05:43 > > >To: Jerin Jacob; tho...@monjalon.net; david.march...@redhat.com; Pavan > > >Nikhilesh Bhagavatula > > >Cc: dev@dpdk.org > > >Subject: [PATCH] tes

Re: [PATCH v3 00/16] NBL PMD for Nebulamatrix NICs

2025-06-27 Thread Thomas Monjalon
27/06/2025 23:07, Stephen Hemminger: > On Thu, 26 Jun 2025 18:40:06 -0700 > "dimon.zhao" wrote: > > Dimon Zhao (16): > > net/nbl: add doc and minimum nbl build framework > > net/nbl: add simple probe/remove and log module > > net/nbl: add PHY layer definitions and implementation > > net/nb

Re: [PATCH v7 1/2] node: add global node mbuf dynfield

2025-06-27 Thread Thomas Monjalon
26/06/2025 16:14, Nitin Saxena: > On Thu, Jun 26, 2025 at 7:29 PM Stephen Hemminger > wrote: > > On Thu, 19 Jun 2025 21:14:49 +0530 > > Nitin Saxena wrote: > > > > > +#ifndef RTE_NODE_MBUF_PERSISTENT_FIELDS_SIZE > > > +/** Size of persistent mbuf fields */ > > > +#define RTE_NODE_MBUF_PERSISTENT_

Re: [PATCH] bus/pci: fix automatic interrupt type selection

2025-06-27 Thread Thomas Monjalon
27/06/2025 21:33, Pekka Riikonen: > On 2025-06-27 19:00, Thomas Monjalon wrote: > > 20/06/2025 13:47, priik...@iki.fi: > >> Check if kernel returns 0 interrupt vectors and try another interrupt > >> type in that case. Failing to check the vector count can select an

Re: [PATCH v3 2/3] eal: handle sysconf(_SC_PAGESIZE) negative return value

2025-06-27 Thread Thomas Monjalon
27/06/2025 19:49, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Friday, 27 June 2025 19.35 > > > > 27/06/2025 18:38, Morten Brørup: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Sent: Friday,

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-27 Thread Thomas Monjalon
27/06/2025 19:46, Dylan Schneider: > Can you tell me the build command you're using to produce those errors? I > have ran the builds on my test machine and cannot reproduce these. Thanks! I run devtools/test-meson-builds.sh with an Arm toolchain installed. Message: = Libraries E

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-27 Thread Thomas Monjalon
09/06/2025 23:19, Schneide: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating pcapng files. > This change is needed to specify the protocol type in the pcapng file, > DLT_EN10MB specifies ethernet packets only. This will allow dissectors > for other protocols

Re: [PATCH v3 2/3] eal: handle sysconf(_SC_PAGESIZE) negative return value

2025-06-27 Thread Thomas Monjalon
27/06/2025 18:38, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Friday, 27 June 2025 17.58 > > > > 24/06/2025 10:03, Morten Brørup: > > > + if ((ssize_t)page_size < 0) > > > +

Re: [PATCH v3 1/3] eal/unix: fix log message for madvise() failure

2025-06-27 Thread Thomas Monjalon
27/06/2025 18:47, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Friday, 27 June 2025 17.56 > > > > 24/06/2025 10:03, Morten Brørup: > > > In eal_mem_set_dump(), when madvise() failed, an incorrect reason was > > > logged

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-27 Thread Thomas Monjalon
09/06/2025 23:19, Schneide: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating pcapng files. > This change is needed to specify the protocol type in the pcapng file, > DLT_EN10MB specifies ethernet packets only. This will allow dissectors > for other protocols

Re: [PATCH] bus/pci: fix automatic interrupt type selection

2025-06-27 Thread Thomas Monjalon
20/06/2025 13:47, priik...@iki.fi: > Check if kernel returns 0 interrupt vectors and try another interrupt > type in that case. Failing to check the vector count can select an > interrupt type that's unusable. > > Signed-off-by: Pekka Riikonen Please could you be explicit about the use case you

  1   2   3   4   5   6   7   8   9   10   >