On 5/3/2018 11:58 AM, Tan, Jianfeng wrote:
I have a question, hope you can clarify it a little bit. As I
understand, this FPGA bus are used for AFU device enumeration, and
each device on this bus needs a AFU driver to drive. But now we
register AFU drivers, but enumerate rte_ifpga_device
For title prefix, use "bus/ifpga" instead.
On 4/26/2018 5:43 PM, Xu, Rosen wrote:
From: Rosen Xu
Defined FPGA-BUS for Acceleration Drivers of AFUs
1. FPGA PCI Scan (1st Scan) follows DPDK UIO/VFIO PCI Scan Process,
probe Intel FPGA Rawdev Driver.
As I understand, this part is not covered in
Hi Olivier,
On 5/2/2018 7:24 PM, Olivier Matz wrote:
Hi Jianfeng,
On Wed, May 02, 2018 at 10:17:50AM +, Jianfeng Tan wrote:
After below commit, we encounter some strange issue:
1) Dead lock as described here:
http://dpdk.org/ml/archives/dev/2018-April/099806.html
2) SIGSEGV is
On 5/2/2018 6:08 PM, Olivier Matz wrote:
On Wed, May 02, 2018 at 06:01:20PM +0800, Tan, Jianfeng wrote:
Hi Olivier and Anatoly,
[...]
Below patch can fix another strange sigsegv issue in my VM. Please check
if it works for you. I doubt it's use-after-free problem which could
le
Hi Olivier and Anatoly,
[...]
Below patch can fix another strange sigsegv issue in my VM. Please check
if it works for you. I doubt it's use-after-free problem which could
lead to different issues in different env. Please have a try.
diff --git a/lib/librte_eal/common/eal_common_thread.c
b/li
On 5/2/2018 5:30 PM, Burakov, Anatoly wrote:
On 02-May-18 9:50 AM, Tan, Jianfeng wrote:
Hi Maxime,
On 5/2/2018 4:34 PM, Maxime Coquelin wrote:
Hi Jiangfeng,
On 05/02/2018 10:19 AM, Tan, Jianfeng wrote:
On 5/1/2018 2:46 AM, Olivier Matz wrote:
Hi Maxime,
Le 30 avril 2018 17:45:52 GMT
Hi Maxime and Olivier,
[...]
Below patch can fix another strange sigsegv issue in my VM. Please check
if it works for you. I doubt it's use-after-free problem which could
lead to different issues in different env. Please have a try.
diff --git a/lib/librte_eal/common/eal_common_thread.c
b/lib/
Hi Maxime,
On 5/2/2018 4:34 PM, Maxime Coquelin wrote:
Hi Jiangfeng,
On 05/02/2018 10:19 AM, Tan, Jianfeng wrote:
On 5/1/2018 2:46 AM, Olivier Matz wrote:
Hi Maxime,
Le 30 avril 2018 17:45:52 GMT+02:00, Maxime Coquelin
a écrit :
Hi Olivier,
On 04/24/2018 04:46 PM, Olivier Matz wrote
On 5/1/2018 2:46 AM, Olivier Matz wrote:
Hi Maxime,
Le 30 avril 2018 17:45:52 GMT+02:00, Maxime Coquelin
a écrit :
Hi Olivier,
On 04/24/2018 04:46 PM, Olivier Matz wrote:
Some parts of dpdk use their own management threads. Most of the
time,
the affinity of the thread is not properly se
On 4/28/2018 9:24 AM, Stephen Hemminger wrote:
On Fri, 27 Apr 2018 21:52:26 +0200
Thomas Monjalon wrote:
27/04/2018 19:45, Shreyansh Jain:
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Shreyansh Jain wrote:
From: Jianfeng Tan
Below commit introduced pthread barrier for syn
On 4/28/2018 9:21 AM, Stephen Hemminger wrote:
On Fri, 27 Apr 2018 21:52:26 +0200
Thomas Monjalon wrote:
27/04/2018 19:45, Shreyansh Jain:
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Shreyansh Jain wrote:
From: Jianfeng Tan
Below commit introduced pthread barrier for syn
On 4/27/2018 11:46 PM, Tan, Jianfeng wrote:
Hi Olivier,
After this patch, I find the two IPC threads block at
pthread_barrier_wait(), and never wake up. Please refer below for more
information. The system is Ubuntu 16.04.
On 4/24/2018 10:46 PM, Olivier Matz wrote:
To avoid code
Hi Olivier,
After this patch, I find the two IPC threads block at
pthread_barrier_wait(), and never wake up. Please refer below for more
information. The system is Ubuntu 16.04.
On 4/24/2018 10:46 PM, Olivier Matz wrote:
To avoid code duplication, add a parameter to rte_ctrl_thread_create()
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, April 25, 2018 9:04 PM
> To: dev@dpdk.org
> Cc: Burakov, Anatoly; Pattan, Reshma; Tan, Jianfeng
> Subject: [PATCH] app/pdump: remove unused socket path options
>
> The
On 4/17/2018 11:48 PM, Anatoly Burakov wrote:
Return value from rte_socket_id_by_idx() may be negative, which would
result in negative index access.
Additionally, return value was of mismatched type (function returns
signed int, socket id was unsigned).
Coverity issue: 272571
Coverity issue:
On 4/17/2018 11:42 PM, Anatoly Burakov wrote:
Coverity issue: 272607
Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 7 +--
1 file changed, 5 insertions(+),
On 4/17/2018 11:42 PM, Anatoly Burakov wrote:
Value returned by rte_socket_id_by_idx() may be negative, which would
result in negative array index access.
Coverity issue: 272600
Fixes: b666f17858a3 ("mem: read hugepage counts from node-specific sysfs path")
Cc: anatoly.bura...@intel.com
Sign
> -Original Message-
> From: Burakov, Anatoly
> Sent: Monday, April 23, 2018 5:55 PM
> To: Tan, Jianfeng; dev@dpdk.org
> Cc: tho...@monjalon.net
> Subject: Re: [dpdk-dev] [PATCH v4 3/5] bus/vdev: bus scan by multi-process
> channel
>
> On 20-Apr-18 5:57 PM,
On 4/20/2018 11:19 PM, Burakov, Anatoly wrote:
On 20-Apr-18 3:28 PM, Tan, Jianfeng wrote:
On 4/20/2018 4:41 PM, Burakov, Anatoly wrote:
On 19-Apr-18 5:50 PM, Jianfeng Tan wrote:
To scan the vdevs in primary, we send request to primary process
to obtain the names for vdevs.
Only the name
On 4/20/2018 11:16 PM, Burakov, Anatoly wrote:
On 20-Apr-18 3:19 PM, Tan, Jianfeng wrote:
On 4/20/2018 4:26 PM, Burakov, Anatoly wrote:
On 19-Apr-18 5:50 PM, Jianfeng Tan wrote:
As we could add virtual devices from different threads now, we
add a spin lock to protect the vdev device list
On 4/20/2018 3:55 PM, Burakov, Anatoly wrote:
On 20-Apr-18 2:21 AM, Jianfeng Tan wrote:
Following below commit, we change some internal function and variable
names:
commit ce3a7312357b ("eal: rename IPC request as synchronous one")
Also use calloc to supersede malloc + memset for code clea
On 4/17/2018 11:46 PM, Anatoly Burakov wrote:
This patchset fixes a few Coverity issues introduced
when various parts of DPDK IPC were added, and explains
away other reported issues.
Coverity issues fixed:
- 272595 - return without mutex unlock
- 272609 - fd leak
Coverity issues intentionally
On 4/20/2018 4:41 PM, Burakov, Anatoly wrote:
On 19-Apr-18 5:50 PM, Jianfeng Tan wrote:
To scan the vdevs in primary, we send request to primary process
to obtain the names for vdevs.
Only the name is shared from the primary. In probe(), the device
driver is supposed to locate (or request mor
On 4/20/2018 4:26 PM, Burakov, Anatoly wrote:
On 19-Apr-18 5:50 PM, Jianfeng Tan wrote:
As we could add virtual devices from different threads now, we
add a spin lock to protect the vdev device list.
Suggested-by: Anatoly Burakov
Signed-off-by: Jianfeng Tan
Reviewed-by: Qi Zhang
---
<...
On 4/20/2018 4:16 PM, Burakov, Anatoly wrote:
On 19-Apr-18 5:50 PM, Jianfeng Tan wrote:
Adjust the init sequence: put mp channel init before bus scan
so that we can init the vdev bus through mp channel in the
secondary process before the bus scan.
Signed-off-by: Jianfeng Tan
Reviewed-by: Qi
> -Original Message-
> From: Tan, Jianfeng
> Sent: Friday, April 20, 2018 9:22 AM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Burakov, Anatoly; Tan, Jianfeng
> Subject: [PATCH 2/2] ipc: fix timeout not properly handled in async
>
> In original implementati
Hi Ferruh,
On 4/17/2018 7:26 PM, Ferruh Yigit wrote:
On 4/17/2018 5:54 AM, Tiwei Bie wrote:
On Mon, Apr 16, 2018 at 05:10:24PM +0100, Ferruh Yigit wrote:
On 4/14/2018 11:55 AM, Tiwei Bie wrote:
On Fri, Apr 13, 2018 at 10:53:55PM +0100, Ferruh Yigit wrote:
On 4/10/2018 4:41 PM, Tiwei Bie wro
Sorry, forget the version change log. FYI:
v6->v7:
- Rebase on master.
v5->v6: (Address comments from Anatoly)
- Naming, return checking, logging.
- Move vfio action register after rte_bus_probe().
On 4/15/2018 11:06 PM, Jianfeng Tan wrote:
Previously, vfio uses its own private channel f
On 4/13/2018 11:55 PM, Anatoly Burakov wrote:
We are trying to notify sender that response from current process
should be ignored, but we didn't specify which request this response
was for. Fix by copying request name from the original message.
Fixes: 579a4ccc345c ("eal: ignore IPC messages un
On 4/13/2018 7:55 PM, Anatoly Burakov wrote:
Previously, we were removing request from the list only if we
have succeeded to send it. This resulted in leaving an invalid
pointer in the request list.
Fix this by only adding new requests to the request list if we
have succeeded in sending them.
On 4/13/2018 7:54 PM, Anatoly Burakov wrote:
Previously, we were adding synchronous requests to request list, we
were doing it after checking if request existed. However, we only
removed the request from the request list if we have succeeded in
sending the request. In case of failed request sen
On 4/10/2018 11:28 PM, Anatoly Burakov wrote:
EAL did not stop processing further asynchronous requests on
encountering a request that should trigger the callback. This
resulted in erasing valid requests but not triggering them.
Fix this by stopping the loop once we have a request that
can tri
Hi Thomas,
On 4/13/2018 7:30 AM, Thomas Monjalon wrote:
Hi Jinafeng,
05/04/2018 19:44, Jianfeng Tan:
As we know, we have below limitations in vdev:
- dpdk-procinfo cannot get the stats of (most) vdev in primary process;
- dpdk-pdump cannot dump the packets for (most) vdev in primary pro
On 4/13/2018 12:28 AM, Junjie Chen wrote:
In some cases we want vhost dequeue work in interrupt mode to
release cpus to others when no data to transmit. So we install
interrupt handler of vhost device and interrupt vectors for each
rx queue when creating new backend according to vhost intrerupt
On 4/12/2018 3:29 PM, Maxime Coquelin wrote:
On 04/12/2018 09:21 AM, Tan, Jianfeng wrote:
On 4/12/2018 1:02 AM, Junjie Chen wrote:
dev_start sets *dev_attached* after setup queues, this sets device to
invalid state since no frontend is attached. Also destroy_device set
*started* to zero
On 4/12/2018 1:02 AM, Junjie Chen wrote:
dev_start sets *dev_attached* after setup queues, this sets device to
invalid state since no frontend is attached. Also destroy_device set
*started* to zero which makes *allow_queuing* always zero until dev_start
get called again. Actually, we should not
On 4/11/2018 4:35 PM, Chen, Junjie J wrote:
On 4/11/2018 6:53 PM, Junjie Chen wrote:
dev_start sets *dev_attached* after setup queues, this sets device to
invalid state since no frontend is attached. Also destroy_device set
*started* to zero which makes *allow_queuing* always zero until
dev_s
On 4/11/2018 6:53 PM, Junjie Chen wrote:
dev_start sets *dev_attached* after setup queues, this sets device to
invalid state since no frontend is attached. Also destroy_device set
*started* to zero which makes *allow_queuing* always zero until dev_start
get called again. Actually, we should not
On 4/10/2018 10:17 PM, Burakov, Anatoly wrote:
On 10-Apr-18 2:53 PM, Tan, Jianfeng wrote:
On 4/10/2018 6:03 PM, Anatoly Burakov wrote:
EAL did not stop processing further asynchronous requests on
encountering a request that should trigger the callback. This
resulted in erasing valid
On 4/10/2018 6:03 PM, Anatoly Burakov wrote:
EAL did not stop processing further asynchronous requests on
encountering a request that should trigger the callback. This
resulted in erasing valid requests but not triggering them.
That means one wakeup could process multiple replies, and followi
Hi Junjie,
I think the code is still buggy. As vhost thread and master thread are
separately invoking new_device() and dev_start().
On 4/10/2018 10:18 PM, Junjie Chen wrote:
dev_start sets *dev_attached* after setup queues, this sets device to
invalid state since no frontend is attached. Also
> -Original Message-
> From: Yang, Zhiyong
> Sent: Friday, April 6, 2018 5:26 PM
> To: dev@dpdk.org
> Cc: Yang, Zhiyong; maxime.coque...@redhat.com; Tan, Jianfeng; Bie, Tiwei;
> Wang, Zhihong; Wang, Dong1; tho...@monjalon.net
> Subject: [PATCH v7] net/virtio-user: a
On 4/6/2018 8:18 AM, zhiyong.y...@intel.com wrote:
In a container environment if the vhost-user backend restarts, there's
no way for it to reconnect to virtio-user. To address this, support for
server mode is added. In this mode the socket file is created by virtio-
user, which the backend then
On 4/6/2018 12:10 AM, Jeff Guo wrote:
In order to handle the uevent which has been detected from the kernel
side, add uevent parse and process function to translate the uevent into
device event, which user has subscribed to monitor.
Signed-off-by: Jeff Guo
Other than two nits below,
Reviewe
Hi Anatoly,
An obvious action would be change rte_mp_request to
rte_mp_request_sync(). Before sending out the new patch, do you have any
other comments for this patch?
Hi Thomas,
Several patches will change vfio; may I know the your preferred apply
sequence? (I'm trying to find out which pa
Sorry, it seems that I missed this email.
On 4/5/2018 5:45 PM, Pattan, Reshma wrote:
Hi
Signed-off-by: Jianfeng Tan
---
Note this patch needs this patch set:
http://dpdk.org/dev/patchwork/patch/36814/
v2:
- Update doc for deprecation of API, rte_pdump_set_socket_dir,
and API change f
On 4/5/2018 6:37 PM, Pattan, Reshma wrote:
Hi,
-Original Message-
From: Tan, Jianfeng
Sent: Wednesday, April 4, 2018 4:08 PM
To: dev@dpdk.org
Cc: Tan, Jianfeng ; Pattan, Reshma
Subject: [PATCH v2] pdump: change to use generic multi-process channel
The original code replies on the
On 4/5/2018 5:02 PM, Jeff Guo wrote:
In order to handle the uevent which has been detected from the kernel
side, add uevent parse and process function to translate the uevent into
device event, which user has subscribed to monitor.
Signed-off-by: Jeff Guo
---
v19->18:
fix some misunderstandin
On 4/5/2018 4:32 PM, Jeff Guo wrote:
This patch aims to add a general device event monitor framework at
EAL device layer, for device hotplug awareness and actions adopted
accordingly. It could also expand for all other types of device event
monitor, but not in this scope at the stage.
To get s
On 4/5/2018 12:31 AM, Matan Azrad wrote:
Hi all
What do you think about adding the "--hotplug" parameter as a new EAL command
line parameter?
+1
Thanks,
Jianfeng
From: Tan, Jianfeng, Wednesday, April 4, 2018 6:23 AM
-Original Message-
From: Guo, Jia
Sent: Tuesda
> -Original Message-
> From: Guo, Jia
> Sent: Wednesday, April 4, 2018 2:17 AM
> To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh;
> Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing;
> tho...@monjalon.net; mo...@mellanox.com; Van Haaren, Harr
> -Original Message-
> From: Guo, Jia
> Sent: Wednesday, April 4, 2018 2:17 AM
> To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh;
> Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing;
> tho...@monjalon.net; mo...@mellanox.com; Van Haaren, Harr
> -Original Message-
> From: Yang, Zhiyong
> Sent: Wednesday, April 4, 2018 11:32 AM
> To: Tan, Jianfeng; dev@dpdk.org
> Cc: maxime.coque...@redhat.com; tho...@monjalon.net; Wang, Zhihong;
> Bie, Tiwei
> Subject: RE: [PATCH v4 1/1] net/virtio-user: add support fo
> -Original Message-
> From: Guo, Jia
> Sent: Tuesday, April 3, 2018 6:34 PM
> To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh;
> Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing;
> tho...@monjalon.net; mo...@mellanox.com; Van Haaren, Harry; Ta
Jingjing;
> tho...@monjalon.net; mo...@mellanox.com; Van Haaren, Harry; Tan,
> Jianfeng
> Cc: jblu...@infradead.org; shreyansh.j...@nxp.com; dev@dpdk.org; Guo,
> Jia; Zhang, Helin
> Subject: [PATCH V18 3/4] eal/linux: uevent parse and process
>
> In order to handle the uevent whi
> -Original Message-
> From: Guo, Jia
> Sent: Tuesday, April 3, 2018 6:34 PM
> To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh;
> Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing;
> tho...@monjalon.net; mo...@mellanox.com; Van Haaren, Harry; Ta
> -Original Message-
> From: Guo, Jia
> Sent: Tuesday, April 3, 2018 6:34 PM
> To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh;
> Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing;
> tho...@monjalon.net; mo...@mellanox.com; Van Haaren, Harry; Ta
On 4/3/2018 8:20 PM, zhiyong.y...@intel.com wrote:
virtio-user adds support for server mode in this patch.
Client mode vhost-user startup firstly, server mode virtio-user startups
and creates the socket file to exchange vhost messages.
If the connection is broken, client mode vhost-user can s
...@huawei.com; Tan, Jianfeng
Subject: RE: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external
backend support
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang
Sent: Thursday, March 29, 2018 2:53 PM
To: dev@dpdk.org
Cc: maxime.coque...@redhat.com; jianjay.z
> -Original Message-
> From: Burakov, Anatoly
> Sent: Sunday, April 1, 2018 1:06 AM
> To: dev@dpdk.org
> Cc: Tan, Jianfeng; Ananyev, Konstantin; tho...@monjalon.net
> Subject: [PATCH v7 2/3] eal: rename mp_request to mp_request_sync
>
> Rename rte_mp_request t
On 3/29/2018 10:37 PM, Junjie Chen wrote:
In some cases we want vhost dequeue work in interrupt mode to
release cpus to others when no data to transmit. So we install
interrupt handler of vhost device and interrupt vectors for each
rx queue when creating new backend according to vhost intrerupt
We shall split this patch to multiple patches.
- This helper function is not necessarily exposed to users. Whenever
there is a device remove event, before invoking the callbacks, we do the
remap.
- PCI related code shall be put into librte_pci.
- Personally, I don't think we shall add an ops
For the title prefix, "vhost" is just fine.
On 3/29/2018 8:52 PM, Fan Zhang wrote:
This patch adds session message handler to vhost crypto.
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 428
1 file changed, 428 insertions(+)
creat
On 3/29/2018 8:57 PM, Wodkowski, PawelX wrote:
DPDK vhost-user handles this message rudely by unmap all existing
regions and map new ones. This might lead to segfault if there
is pmd thread just trying to touch those unmapped memory regions.
But for most cases, except VM memory hotplug,
FYI,
On 3/29/2018 3:35 PM, Maxime Coquelin wrote:
On 03/29/2018 09:01 AM, Tan, Jianfeng wrote:
Hi Maxime and Victor,
-Original Message-
From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
Sent: Tuesday, December 5, 2017 10:28 PM
To: Yuanhan Liu; Tan, Jianfeng; Victor Kaplansky
Cc
Hi Xiangxia,
> -Original Message-
> From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com]
> Sent: Wednesday, March 28, 2018 1:49 PM
> To: Tan, Jianfeng
> Cc: dev@dpdk.org; Tonghao Zhang
> Subject: [PATCH 2/2] vhost: add pipe event for optimizing negotiating
Hi Maxime and Victor,
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Tuesday, December 5, 2017 10:28 PM
> To: Yuanhan Liu; Tan, Jianfeng; Victor Kaplansky
> Cc: dev@dpdk.org; sta...@dpdk.org; Yang, Yi Y
> Subject: Re: [PATCH] v
It's interesting that we add some new APIs to be used by the
lib/librte_vhost/ itself. I can understand as we planned to not put
vhost crypto into the lib.
As vhost crypto is not a real "external backend", we could ask opinion
of a real external backend if these are really necessary. pre and
> -Original Message-
> From: Seán Harte [mailto:sea...@gmail.com]
> Sent: Thursday, March 29, 2018 12:55 AM
> To: Ning Li; Yuanhan Liu; Maxime Coquelin; Bie, Tiwei
> Cc: dev@dpdk.org; Tan, Jianfeng
> Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: specify the MAC of
On 3/26/2018 7:20 PM, Jeff Guo wrote:
Use testpmd for example, to show an application how to use device event
mechanism to monitor the hotplug event, involve both hot removal event
involve -> including
and the hot insertion event.
The process is that, testpmd first enable hotplug monitorin
BTW, adding new .c file needs to update meson.build now.
On 3/26/2018 7:20 PM, Jeff Guo wrote:
In order to handle the uevent which have been detected from the kernel
side, add uevent parse and process function to translate the uevent into
device event, which user has subscribe to monitor.
Signe
Hi Zhiyong,
Triggered by the community discussion of thread creation in a library
(http://dpdk.org/dev/patchwork/patch/36579/), we can think about if
possible to avoid the pthread creation here.
Just a quick think, it could be feasible. The key idea is to properly
set up the LSC interrupt fo
Hi Thomas and Harry,
On 3/28/2018 4:22 PM, Van Haaren, Harry wrote:
From: Thomas Monjalon [mailto:tho...@monjalon.net]
Sent: Wednesday, March 28, 2018 8:30 AM
To: Tan, Jianfeng
Cc: Burakov, Anatoly ; dev@dpdk.org; Ananyev,
Konstantin ; Van Haaren, Harry
Subject: Re: [dpdk-dev] [PATCH v6 2/2
On 3/21/2018 11:03 AM, zhiyong.y...@intel.com wrote:
Add checking for cvq to judge if virtio_ack_link_announce should be called.
The existing code doesn't cause issue, and add the checking just to look
more reasonable.
Signed-off-by: Zhiyong Yang
Reviewed-by: Jianfeng Tan
Thanks,
Jianfeng
On 3/21/2018 11:03 AM, zhiyong.y...@intel.com wrote:
It is necessary to add pointer checking because in some case the
code will cause crash. For example, the code goes here before
memory allocation of rxvq is finished.
Fixes: 7365504f77e3("net/virtio: support guest announce")
Cc: sta...@dpdk.o
> -Original Message-
> From: Guo, Jia
> Sent: Monday, March 26, 2018 7:21 PM
> To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh;
> Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing;
> tho...@monjalon.net; mo...@mellanox.com; Van Haaren, Harry; Ta
Hi Thomas ,
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, March 28, 2018 12:34 AM
> To: Burakov, Anatoly
> Cc: dev@dpdk.org; Tan, Jianfeng; Ananyev, Konstantin; Van Haaren, Harry
> Subject: Re: [dpdk-dev] [PATCH v6 2/2] eal
On 3/27/2018 7:28 PM, Maxime Coquelin wrote:
On 03/27/2018 11:42 AM, Tan, Jianfeng wrote:
On 3/27/2018 5:24 PM, Chen, Junjie J wrote:
On 3/28/2018 12:05 AM, Junjie Chen wrote:
when creating vdev dynamically, vhost pmd driver start directly
without checking TX/RX queues ready or not, and
On 3/27/2018 6:18 PM, Chen, Junjie J wrote:
On 3/27/2018 5:24 PM, Chen, Junjie J wrote:
On 3/28/2018 12:05 AM, Junjie Chen wrote:
when creating vdev dynamically, vhost pmd driver start directly
without checking TX/RX queues ready or not, and thus cause
segmentation fault when vhost library ac
On 3/27/2018 5:24 PM, Chen, Junjie J wrote:
On 3/28/2018 12:05 AM, Junjie Chen wrote:
when creating vdev dynamically, vhost pmd driver start directly
without checking TX/RX queues ready or not, and thus cause
segmentation fault when vhost library accessing queues. This patch
add flag to check
Hi,
On 3/26/2018 7:20 PM, Jeff Guo wrote:
Add new interrupt handle type of RTE_INTR_HANDLE_DEV_EVENT, for
device event interrupt monitor.
A simple search of RTE_INTR_HANDLE_ALARM, we can see that we still need
to update rte_intr_enable()/rte_intr_disable(), and test_interrupt_init().
Thank
On 3/27/2018 5:02 PM, Chen, Junjie J wrote:
Hi Jianfeng
On 3/28/2018 12:05 AM, Junjie Chen wrote:
when creating vdev dynamically, vhost pmd driver start directly
without checking TX/RX queues ready or not, and thus cause
segmentation fault when vhost library accessing queues. This patch add
On 3/28/2018 12:05 AM, Junjie Chen wrote:
when creating vdev dynamically, vhost pmd driver start directly without
checking TX/RX queues ready or not, and thus cause segmentation fault when
vhost library accessing queues. This patch add flag to check whether queues
setup or not, and add driver s
> -Original Message-
> From: Pattan, Reshma
> Sent: Wednesday, March 21, 2018 5:55 PM
> To: Tan, Jianfeng; dev@dpdk.org
> Subject: RE: [PATCH] pdump: change to use generic multi-process channel
>
> Hi,
>
> > -Original Message-
> > From: Tan,
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Wednesday, March 21, 2018 11:44 PM
> To: dev@dpdk.org; Tan, Jianfeng; Bie, Tiwei; jfreim...@redhat.com
> Cc: sta...@dpdk.org; Maxime Coquelin
> Subject: [PATCH] vhost: avoid concur
On 3/24/2018 8:46 PM, Anatoly Burakov wrote:
This API is similar to the blocking API that is already present,
but reply will be received in a separate callback by the caller
(callback specified at the time of request, rather than registering
for it in advance).
Under the hood, we create a sepa
On 3/24/2018 8:46 PM, Anatoly Burakov wrote:
Signed-off-by: Anatoly Burakov
Suggested-by: Jianfeng Tan
Acked-by: Jianfeng Tan
On 3/8/2018 12:56 AM, Anatoly Burakov wrote:
This enables multiprocess synchronization for memory hotplug
requests at runtime (as opposed to initialization).
Basic workflow is the following. Primary process always does initial
mapping and unmapping, and secondary processes always follow primar
Hi Anatoly,
Two general comments firstly.
Q1. As I understand, malloc usage as an example, when a primary process
receives a request in rte_mp_handle thread, it will allocate memory, and
broadcast an async request to all secondary processes, and it will
return immediately; then responses are
> -Original Message-
> From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com]
> Sent: Thursday, March 22, 2018 8:40 PM
> To: Tan, Jianfeng
> Cc: dev@dpdk.org; Tonghao Zhang
> Subject: [PATCH 2/2] vhost: add fdset-event thread name
>
> From: Tonghao Zha
Hi Xiangxia,
> -Original Message-
> From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com]
> Sent: Thursday, March 22, 2018 8:40 PM
> To: Tan, Jianfeng
> Cc: dev@dpdk.org; Tonghao Zhang
> Subject: [PATCH 1/2] vhost: make sure vhost fdset-thread created
> s
On 3/21/2018 1:27 PM, Jeff Guo wrote:
In order to handle the uevent which have been detected from the kernel
side, add uevent process function, let hot plug event to be example to
show uevent mechanism how to pass the uevent and process the uevent.
In fact, how to pass the uevent to eal/linux
Hi Gaetan,
On 3/21/2018 7:20 AM, Gaetan Rivet wrote:
In preparation to making devargs_list private.
Bus drivers generally need to access rte_devargs pertaining to their
operations. This match is a common operation for bus drivers.
Add a new accessor for the rte_devargs list.
Signed-off-by: G
On 3/21/2018 7:20 AM, Gaetan Rivet wrote:
This list should not be operated upon by drivers.
Use the public API to achieve the same functionalities.
Signed-off-by: Gaetan Rivet
Acked-by: Jianfeng Tan
Thanks,
Jianfeng
---
drivers/bus/vdev/Makefile | 1 +
drivers/bus/vdev/vdev.c | 11
Thank you for the comments!
> -Original Message-
> From: Pattan, Reshma
> Sent: Wednesday, March 21, 2018 12:38 AM
> To: Tan, Jianfeng; dev@dpdk.org
> Subject: RE: [PATCH] pdump: change to use generic multi-process channel
>
> Hi,
>
> > -Original Messag
> -Original Message-
> From: Chen, Junjie J
> Sent: Thursday, March 15, 2018 12:24 AM
> To: Tan, Jianfeng; maxime.coque...@redhat.com; y...@fridaylinux.org
> Cc: dev@dpdk.org; Chen, Junjie J
> Subject: [PATCH v4] doc: add driver limitation for vhost dequeue zero copy
&g
Hi Anatoly,
Thank you for the review. All your comments will be addressed in next version,
except for below concern which might be taken care of in another patch if it
also concerns you.
> -Original Message-
> From: Burakov, Anatoly
> Sent: Wednesday, March 14, 2018 9:27 PM
On 3/7/2018 2:10 PM, Matan Azrad wrote:
Yes, we are removing all private rte_eth_dev_data. If I missed some
device, welcome to point out.
net/ring
What is about next PCI device?
net/cxgbe
Will change these two in next version. Thank you, Matan.
On 3/7/2018 10:00 PM, Burakov, Anatoly wrote:
On 04-Mar-18 3:30 PM, Jianfeng Tan wrote:
To scan the vdevs in primary, we send request to primary process
to obtain the names for vdevs.
Only the name is shared from the primary. In probe(), the device
driver is supposed to locate (or request mor
On 3/9/2018 6:07 PM, Junjie Chen wrote:
In vhost-switch example, when binding nic to vfio-pci with iommu enabled,
dequeue zero copy cannot work in VM2NIC mode due to no iommu dma mapping
is setup for guest memory currently.
Signed-off-by: Junjie Chen
---
Changes in V3:
- update limitation to
1 - 100 of 578 matches
Mail list logo
