[PATCH v8 01/13] bpf: add ability to load bpf into a buffer

2025-08-04 Thread Stephen Hemminger
. Signed-off-by: Stephen Hemminger --- app/test/test_bpf.c | 28 +++ lib/bpf/bpf_load.c | 111 ++-- lib/bpf/rte_bpf.h | 38 +++ 3 files changed, 163 insertions(+), 14 deletions(-) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c

[PATCH v8 13/13] app/dumpcap: use port mirror instead of pdump

2025-08-04 Thread Stephen Hemminger
BPF support is updated. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 389 app/dumpcap/meson.build | 3 +- 2 files changed, 317 insertions(+), 75 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 3d3c0dbc66

[PATCH v8 11/13] pcapng: split packet copy from header insertion

2025-08-04 Thread Stephen Hemminger
In new model, the packet was already copied, only need to wrap it in pcapng format. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 178 +--- lib/pcapng/rte_pcapng.h | 27 +- 2 files changed, 120 insertions(+), 85 deletions(-) diff --git

[PATCH v8 12/13] pcapng: make queue optional

2025-08-04 Thread Stephen Hemminger
The queue field is optional in pcapng received packet. Use UINT16_MAX as flag value. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 7 --- lib/pcapng/rte_pcapng.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng

[PATCH v8 09/13] ethdev: add port mirroring feature

2025-08-04 Thread Stephen Hemminger
This adds new feature port mirroring to the ethdev layer. And standalone tests for those features. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_ethdev_mirror.c| 325 config/rte_config.h | 1 + lib/ethdev

[PATCH v8 10/13] app/testpmd: support for port mirroring

2025-08-04 Thread Stephen Hemminger
Add new commands to enable testing of port mirror functionality. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 13 ++ app/test-pmd/cmdline_mirror.c | 194 app/test-pmd/cmdline_mirror.h | 13 ++ app/test-pmd

[PATCH v8 08/13] mbuf: add dynamic flag for use by port mirroring

2025-08-04 Thread Stephen Hemminger
Add names for new port mirror fields. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/mbuf/rte_mbuf_dyn.h b/lib/mbuf/rte_mbuf_dyn.h index 865c90f579..72a31b22b3 100644 --- a/lib/mbuf/rte_mbuf_dyn.h +++ b/lib/mbuf

[PATCH v8 07/13] net/ring: add new devarg to create vdev from existing ring

2025-08-04 Thread Stephen Hemminger
n the parameter. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 966c64d9a5..a43ff20ecc 100644 --- a/drivers/net

[PATCH v8 06/13] net/ring: allow lockfree transmit if ring supports it

2025-08-04 Thread Stephen Hemminger
Need to be able have multiple threads all using same transmit queue when using SPAN. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c

[PATCH v8 05/13] test: add test for hotplug and secondary process operations

2025-08-04 Thread Stephen Hemminger
Use null device to exercise ethdev start/stop in secondary process. Signed-off-by: Stephen Hemminger --- app/test/test_mp_secondary.c | 50 +--- 1 file changed, 47 insertions(+), 3 deletions(-) diff --git a/app/test/test_mp_secondary.c b/app/test

[PATCH v8 04/13] ethdev: swap bpf and ethdev dependency

2025-08-04 Thread Stephen Hemminger
In order to allow use of BPF in the mirror code in ethdev. Need to switch so that ethdev library depends on BPF library. Since meson doesn't allow co-dependency, move the BPF ethdev callback portion into the ethdev lib. And cleanup usage of VLA in that code. Signed-off-by: Stephen Hemm

[PATCH v8 03/13] ethdev: make sure all necessary headers included

2025-08-04 Thread Stephen Hemminger
Best not to depend on other EAL headers to include stuff. Some of the later changes had build failures on some platforms. Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_private.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev

[PATCH v8 02/13] ethdev: allow start/stop from secondary process

2025-08-04 Thread Stephen Hemminger
later add queue and other operations as needed. Bugzilla ID: 73 Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_driver.c | 12 - lib/ethdev/ethdev_private.c | 92 + lib/ethdev/ethdev_private.h | 26 +++ lib/ethdev/rte_ethdev.c | 82

[PATCH v8 00/13] Packet capture using port mirroring

2025-08-04 Thread Stephen Hemminger
more that the overhead of looking at the callback list. TODO items: - need release note and documentation - more through testing on real hardware - figure out deprecation plan for pdump v8 - do BPF in ethdev (when packets are tx/rx). This allows for selective mirroring and improves perfor

Re: [PATCH v7] app/testpmd: monitor state of primary process when using secondary

2025-08-04 Thread Stephen Hemminger
ocess. > When primary process exits it forces secondary to exit avoiding > issues from cleanup logic. > > Fixes: a550baf24af9 ('app/testpmd: support multi-process') > Cc: sta...@dpdk.org > > Signed-off-by: Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> > Si

Re: [PATCH v3 1/2] ethdev: remove unnecessary type conversion

2025-08-04 Thread Stephen Hemminger
On Mon, 4 Aug 2025 13:16:23 +0530 wrote: > From: Sunil Kumar Kori > > As rte_eth_rx_queue_count() returns signed value to represent > the error cases but internally invoked callback is returning > unsigned value. Hence unnecessary type conversion is done. > > To avoid this typecasting from sig

Re: [PATCH v4] net/null: Add fast mbuf release TX offload

2025-08-04 Thread Stephen Hemminger
On Wed, 30 Jul 2025 14:04:51 + Morten Brørup wrote: > Added fast mbuf release, re-using the existing mbuf pool pointer > in the queue structure. > > Signed-off-by: Morten Brørup > --- > v4: > * Force the generic function called by the separate tx_pkt_burst callbacks > to be inlined. > v3:

Re: [PATCH v2 0/6] net/zxdh: fix meson.build issues in compilation

2025-08-03 Thread Stephen Hemminger
On Thu, 10 Jul 2025 18:56:37 +0800 Junlong Wang wrote: > v2: > - using structure assignment operation instead of memcpy. > mac_filter->mac = eth_dev->data->mac_addrs; > > Junlong Wang (6): > net/zxdh: fix meson.build issues in compilation > net/zxdh: fix issues related to MAC configura

Re: [PATCH v3 2/2] net/zxdh: add support flow director ops

2025-08-03 Thread Stephen Hemminger
On Wed, 2 Jul 2025 15:34:45 +0800 Bingbin Chen wrote: > if (hw->is_pf) { > + dtb_qid = hw->dev_sd->dtb_sd.queueid; > + fd_entry = rte_malloc(NULL, > + sizeof(ZXDH_DTB_ACL_ENTRY_INFO_T) * > ZXDH_MAX_FLOW_NUM, 1); > +

Re: [V5 13/18] net/hinic3: add dev ops

2025-08-03 Thread Stephen Hemminger
On Wed, 2 Jul 2025 10:09:36 +0800 Feifei Wang wrote: > From: Feifei Wang > > Add ops related function codes. > > Signed-off-by: Feifei Wang > Signed-off-by: Xin Wang > Reviewed-by: Yi Chen > --- Some spelling errors in this patch that should be fixed. ### [PATCH] net/hinic3: add dev ops

Re: [V5 02/18] net/hinic3: add basic header files

2025-08-03 Thread Stephen Hemminger
On Wed, 2 Jul 2025 10:09:25 +0800 Feifei Wang wrote: > +static inline unsigned long > +clock_gettime_ms(void) > +{ > + struct timespec tv; > + > + clock_gettime(CLOCK_TYPE, &tv); > + > + return (unsigned long)tv.tv_sec * HINIC3_S_TO_MS_UNIT + > +(unsigned long)tv.tv_nsec

Re: [PATCH v3 04/15] net/txgbe: add basic link configuration for Amber-Lite NICs

2025-08-03 Thread Stephen Hemminger
On Thu, 26 Jun 2025 16:02:09 +0800 Zaiyu Wang wrote: > Due to Amber-Lite's significant differences from our 10G NICs, we split > link configuration components (setup_link, check_link, etc.) into new > files. > > Signed-off-by: Zaiyu Wang > --- This does not apply cleanly to current main (or ne

[PATCH] bpf: remove dependency on vla

2025-08-03 Thread Stephen Hemminger
The code for ethdev callbacks was using variable length arrays which is a feature not supported on MSVC and later C standards. Replace with alloca(). Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_pkt.c | 16 +--- lib/bpf/meson.build | 2 -- 2 files changed, 9 insertions(+), 9

Re: [v3] net/cksum: compute raw cksum for several segments

2025-08-03 Thread Stephen Hemminger
On Sat, 2 Aug 2025 04:08:16 -0700 Su Sai wrote: > The rte_raw_cksum_mbuf function is used to compute > the raw checksum of a packet. > If the packet payload stored in multi mbuf, the function > will goto the hard case. In hard case, > the variable 'tmp' is a type of uint32_t, > so rte_bswap16 wil

Re: [PATCH] ethdev: Reject conflicting TX offloads configuration

2025-08-03 Thread Stephen Hemminger
On Sun, 3 Aug 2025 12:51:59 +0200 Morten Brørup wrote: > > From: Ivan Malov [mailto:ivan.ma...@arknetworks.am] > > Sent: Saturday, 2 August 2025 23.34 > > > > Hi, > > > > On Sat, 2 Aug 2025, Stephen Hemminger wrote: > > > > > On Thu, 31

Re: [PATCH v2 0/2] common/sfc_efx/base: fix compiler warnings in X4 netport API

2025-08-02 Thread Stephen Hemminger
On Sat, 2 Aug 2025 08:30:08 +0400 Ivan Malov wrote: > The 25.07 release has got support for AMD Solarflare X45xx adapters [1]. > This series is a follow-up to [1] to fix compiler warnings in the base > driver that are seen in Windows driver build, also based on this driver. > > [1] https://patc

Re: [PATCH] ethdev: Reject conflicting TX offloads configuration

2025-08-02 Thread Stephen Hemminger
On Thu, 31 Jul 2025 09:07:31 + Morten Brørup wrote: > + RTE_ETHDEV_LOG_LINE(DEBUG, > + "Ethdev port_id=%d tx_queue_id=%d, Tx offload %s > potential conflict with per-port Tx offload %s, " > + "runtime support depends on the driver", Shorte

Re: [PATCH] net/bnxt: fix free of not allocated object

2025-08-02 Thread Stephen Hemminger
On Wed, 21 May 2025 12:37:27 -0700 Stephen Hemminger wrote: > This was found as error when compiling with LTO. > The function allocates new data with rte_zmalloc and then > stores pointer in the pointer-to-pointer passed as argument. > In the unwind case, it would call rte_free() wi

[PATCH] bpf: add allocation annotations to functions

2025-08-02 Thread Stephen Hemminger
In commit 80da7efbb4c4 ("eal: annotate allocation functions") helper macros were added to provide compiler information to detect misuse of alloc/free combinations. This covered many of the functions in DPDK but missed the case of data allocated by BPF load functions. Signed-off-b

Re: [PATCH] app/testpmd: fix mask in random flow item definition

2025-08-01 Thread Stephen Hemminger
On Wed, 30 Jul 2025 14:32:43 +0300 Maayan Kashani wrote: > A previous patch addressing an ASAN global-buffer-overflow issue > inadvertently degraded the random mask value translation. > Specifically, changing the mask from 0x to 0x caused > the value to be shifted left by 16 bits, sin

Re: [PATCH v6] app/testpmd: monitor state of primary process when using secondary

2025-08-01 Thread Stephen Hemminger
ocess. > When primary process exits it forces secondary to exit avoiding > issues from cleanup logic. > > Fixes: a550baf24af9 ('app/testpmd: support multi-process') > Cc: sta...@dpdk.org > > Signed-off-by: Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> > Signe

Re: [PATCH v5] net/af_xdp: enable AF_XDP program attachment mode

2025-08-01 Thread Stephen Hemminger
On Wed, 30 Jul 2025 11:41:21 + Shivaji Kant wrote: > Currently, the AF_XDP PMD attaches its XDP program using a fixed > set of flags, defaulting to `XDP_FLAGS_UPDATE_IF_NOEXIST`. This lacks > flexibility for users who might need to explicitly control the XDP > mode based on their specific har

Re: [PATCH v10 06/10] lib/pmu: do not try enabling perf counter access on arm64

2025-08-01 Thread Stephen Hemminger
On Fri, 1 Aug 2025 12:21:05 +0200 Tomasz Duszynski wrote: > /proc/sys/kernel/perf_user_access attribute allow user process to access > perf counters. Though in order to change it binary requires elevated > capabilities or must be run as root. If that's not the case counter > access remains disabl

Re: [PATCH v9 1/8] lib/pmu: quiesce rte_pmu_read deprecation warning in chkincs

2025-08-01 Thread Stephen Hemminger
On Fri, 1 Aug 2025 11:37:06 +0200 Tomasz Duszynski wrote: > > > Add a dummy rte_pmu_read() definition for chkincs when > > > ALLOW_EXPERIMENTAL_API is not defined to suppress warnings from > > > use of experimental APIs in tracepoints. > > > > > > Fixes: 960c43184c4d ("pmu: introduce library for

Re: [PATCH v4 1/4] eal: add basename function for common path manipulation

2025-08-01 Thread Stephen Hemminger
On Thu, 31 Jul 2025 16:00:38 + Bruce Richardson wrote: > There is no standard, cross-platform function to get the basename of a > file path across all the supported DPDK platforms, Linux, BSD and > Windows. Both Linux and BSD have a "basename" function in standard > library, except: > * Linux

Re: [PATCH v10 03/10] lib/pmu: quiesce rte_pmu_read deprecation warning in chkincs

2025-08-01 Thread Stephen Hemminger
On Fri, 1 Aug 2025 12:21:02 +0200 Tomasz Duszynski wrote: > Add a dummy rte_pmu_read() definition for chkincs when > ALLOW_EXPERIMENTAL_API is not defined to suppress warnings from > use of experimental APIs in tracepoints. > > Fixes: 960c43184c4d ("pmu: introduce library for reading PMU events"

Re: [PATCH v4] net/af_xdp: enable AF_XDP program attachment mode

2025-07-29 Thread Stephen Hemminger
On Tue, 29 Jul 2025 16:17:47 + Shivaji Kant wrote: > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > b/drivers/net/af_xdp/rte_eth_af_xdp.c > index 5f65850a27..9858ac24b2 100644 > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > @@ -169,6 +169,7 @@ st

Re: [PATCH] [PATCH v5] app/testpmd: fix segfault in secondary process by monitoring primary

2025-07-29 Thread Stephen Hemminger
leanup logic. Fixes: a550baf24af9 ("app/testpmd: support multi-process") Cc: sta...@dpdk.org Signed-off-by: Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> Signed-off-by: Stephen Hemminger --- app/test-pmd/testpmd.c | 41 - 1 file changed, 40 ins

Re: [PATCH] [PATCH v4] lib/ethdev: fix segfault in secondary process by validating dev_private pointer

2025-07-29 Thread Stephen Hemminger
On Tue, 29 Jul 2025 01:42:29 -0400 Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> wrote: > Hi Stephen, > > Many Thanks for the feedback. > I have addressed all the comments on the patch, I have removed the > unnecessary check in ethdev, the only one check in rte_ethdev seems to be a > neccessary

Re: [PATCH v3] net/af_xdp: enable AF_XDP program attachment mode

2025-07-29 Thread Stephen Hemminger
On Tue, 29 Jul 2025 10:08:45 + Shivaji Kant wrote: > @@ -2147,6 +2189,10 @@ parse_parameters(struct rte_kvargs *kvlist, char > *if_name, int *start_queue, > > ret = rte_kvargs_process(kvlist, ETH_AF_XDP_DP_PATH_ARG, >&parse_prog_arg, dp_path); > + > +

Re: [PATCH v3] net/af_xdp: enable AF_XDP program attachment mode

2025-07-29 Thread Stephen Hemminger
On Tue, 29 Jul 2025 10:08:45 + Shivaji Kant wrote: > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > b/drivers/net/af_xdp/rte_eth_af_xdp.c > index 5f65850a27..fbd592c538 100644 > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > @@ -104,6 +104,7 @@ RT

Re: [PATCH v8 0/5] NXP DPAA2 driver enhancements and fixes

2025-07-28 Thread Stephen Hemminger
On Wed, 2 Jul 2025 15:21:39 +0530 Gagandeep Singh wrote: > V1-logs: > This patch series introduces enhancements and fixes to the > NXP DPAA2 Ethernet driver. > It includes support for > - software taildrop on ordered queues. > - setup speed capabilities. > - DPAA2 resource version. > - MAC l

Re: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-07-28 Thread Stephen Hemminger
On Mon, 12 May 2025 20:37:19 +0530 wrote: > From: Sunil Kumar Kori > > As rte_eth_rx_queue_count() returns signed value to represent > the error cases but internally invoked callback is returning > unsigned value. Hence unnecessary type conversion is done. > > To avoid this typecasting from si

Re: [PATCH v3 3/3] app/testpmd: improve output when processing cmdline files

2025-07-28 Thread Stephen Hemminger
On Mon, 7 Jul 2025 12:17:51 +0100 Bruce Richardson wrote: > Two small improvements for the cmdline file processing in testpmd. > > * Now that we support multiple files, change the prompt to indicate what > file is currently being processed, and just print an EOF message when > done. > * Whe

Re: [PATCH] app/testpmd: add flag to enable RSS for single-queue

2025-07-28 Thread Stephen Hemminger
On Tue, 15 Jul 2025 12:53:30 + Bruce Richardson wrote: > For testing purposes it can be desirable to enable RSS even when only a > single queue per port is in use. Add an "enable-rss" flag to testpmd to > match the existing "disable-rss" flag. > > Signed-off-by: Bruce Richardson > --- Appl

Re: [PATCH] app/test-flow-perf: support testing the flow tables query rate

2025-07-28 Thread Stephen Hemminger
On Thu, 8 May 2025 10:36:38 +0800 Sunyang Wu wrote: > Support testing the flow tables query rate. > > Signed-off-by: Sunyang Wu > > --- Applied to next-net for 25.11

[PATCH v7 11/12] app/testpmd: support for port mirroring

2025-07-28 Thread Stephen Hemminger
Add new commands to enable testing of port mirror functionality. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 13 ++ app/test-pmd/cmdline_mirror.c | 194 app/test-pmd/cmdline_mirror.h | 13 ++ app/test-pmd

[PATCH v7 12/12] app/dumpcap: use port mirror instead of pdump

2025-07-28 Thread Stephen Hemminger
BPF support is updated. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 471 app/dumpcap/meson.build | 3 +- 2 files changed, 382 insertions(+), 92 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 3d3c0dbc66

[PATCH v7 09/12] pcapng: split packet copy from header insertion

2025-07-28 Thread Stephen Hemminger
In new model, the packet was already copied, only need to wrap it in pcapng format. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 178 +--- lib/pcapng/rte_pcapng.h | 27 +- 2 files changed, 120 insertions(+), 85 deletions(-) diff --git

[PATCH v7 10/12] pcapng: make queue optional

2025-07-28 Thread Stephen Hemminger
The queue field is optional in pcapng received packet. Use UINT16_MAX as flag value. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 7 --- lib/pcapng/rte_pcapng.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng

[PATCH v7 08/12] test: add tests for ethdev mirror

2025-07-28 Thread Stephen Hemminger
Simple API and packet mirroring standalone tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_ethdev_mirror.c | 325 ++ 2 files changed, 326 insertions(+) create mode 100644 app/test/test_ethdev_mirror.c diff --git

[PATCH v7 07/12] ethdev: add port mirroring feature

2025-07-28 Thread Stephen Hemminger
This adds new feature port mirroring to the ethdev layer. Signed-off-by: Stephen Hemminger --- config/rte_config.h | 1 + lib/ethdev/ethdev_driver.h | 6 + lib/ethdev/ethdev_private.c | 58 - lib/ethdev/ethdev_private.h | 3 + lib/ethdev/ethdev_trace.h

[PATCH v7 06/12] mbuf: add dynamic flag for use by port mirroring

2025-07-28 Thread Stephen Hemminger
Add names for new port mirror fields. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/mbuf/rte_mbuf_dyn.h b/lib/mbuf/rte_mbuf_dyn.h index 865c90f579..72a31b22b3 100644 --- a/lib/mbuf/rte_mbuf_dyn.h +++ b/lib/mbuf

[PATCH v7 05/12] net/ring: add new devarg to create vdev from existing ring

2025-07-28 Thread Stephen Hemminger
n the parameter. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 966c64d9a5..a43ff20ecc 100644 --- a/drivers/net

[PATCH v7 04/12] net/ring: allow lockfree transmit if ring supports it

2025-07-28 Thread Stephen Hemminger
Need to be able have multiple threads all using same transmit queue when using SPAN. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c

[PATCH v7 03/12] test: add test for hotplug and secondary process operations

2025-07-28 Thread Stephen Hemminger
Use null device to exercise ethdev start/stop in secondary process. Signed-off-by: Stephen Hemminger --- app/test/test_mp_secondary.c | 51 +--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/app/test/test_mp_secondary.c b/app/test

[PATCH v7 02/12] ethdev: make sure all necessary headers included

2025-07-28 Thread Stephen Hemminger
Best not to depend on other EAL headers to include stuff. Some of the later changes had build failures on some platforms. Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_private.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev

[PATCH v7 01/12] ethdev: allow start/stop from secondary process

2025-07-28 Thread Stephen Hemminger
later add queue and other operations as needed. Bugzilla ID: 73 Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_driver.c | 12 - lib/ethdev/ethdev_private.c | 92 + lib/ethdev/ethdev_private.h | 26 +++ lib/ethdev/rte_ethdev.c | 82

[PATCH v7 00/12] Port mirroring for packet capture

2025-07-28 Thread Stephen Hemminger
more that the overhead of looking at the callback list. TODO items: - need release note and documentation - more through testing on real hardware - figure out deprecation for pdump v7 - review feedback - add statistics - remove deprecation of pdump Stephen Hemminger (12): ethdev: allow

[PATCH v2] dumpcap: fix warnings when primary exits

2025-07-23 Thread Stephen Hemminger
If primary process exits, there is no point in calling pdump to release resources. Bugzilla ID: 1760 Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Signed-off-by: Stephen Hemminger --- v2 - fix indentation app/dumpcap/main.c | 11 ++- 1 file

Re: [PATCH v6 08/13] pcapng: split packet copy from header insertion

2025-07-23 Thread Stephen Hemminger
On Wed, 23 Jul 2025 06:32:45 +0400 (+04) Ivan Malov wrote: > Hi Stephen, > > On Tue, 22 Jul 2025, Stephen Hemminger wrote: > > > In new model, the packet was already copied, only need > > Copied? But what if it was "indirect attached" instead, as the model

Re: [PATCH v6 07/13] ethdev: add port mirroring feature

2025-07-23 Thread Stephen Hemminger
On Wed, 23 Jul 2025 06:13:27 +0400 (+04) Ivan Malov wrote: > +static inline void > > +eth_dev_mirror(uint16_t port_id, uint16_t queue_id, uint8_t direction, > > +struct rte_mbuf **pkts, uint16_t nb_pkts, > > +const struct rte_eth_mirror_conf *conf) > > +{ > > + struct rte_mbuf

Re: [PATCH v6 01/13] ethdev: allow start/stop from secondary process

2025-07-23 Thread Stephen Hemminger
On Wed, 23 Jul 2025 05:08:04 +0400 (+04) Ivan Malov wrote: > + > > +int > > +ethdev_request(uint16_t port_id, enum ethdev_mp_operation operation, > > + const void *buf, size_t buf_len) > > +{ > > + struct rte_mp_msg mp_req = { }; > > + struct rte_mp_reply mp_reply; > > + struct et

Re: [PATCH] net/tap: fix BPF build failure in cross-compilation environment

2025-07-23 Thread Stephen Hemminger
On Wed, 23 Jul 2025 07:57:02 -0500 Ashok Kaladi wrote: > During cross-compilation, BPF build incorrectly includes header files > from the host system instead of the target sysroot. This leads to > build failures due to incompatible headers or unavailability of header > files in the host. > > Fix

Re: [PATCH] [PATCH v3] lib/ethdev: fix segfault in secondary process by validating dev_private pointer

2025-07-23 Thread Stephen Hemminger
On Wed, 23 Jul 2025 18:34:04 +0500 Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> wrote: > Hi Ivan, agree. I think we can atleast currently guard all the known > crashes. > > Sure, I will check the macro and get back to you. > > Thank you! > > On Wed, Jul 23, 2025, 18:19 Ivan Malov wrote: > >

Re: [PATCH] lib/ethdev: fix segfault in secondary process by validating dev_private pointer

2025-07-22 Thread Stephen Hemminger
On Tue, 22 Jul 2025 23:05:06 +0400 (+04) Ivan Malov wrote: > There is a difference between control path and data path. Always has been. > Yes, > on data path, DPDK has historically sought better performance, but on the slow > path, checks have typically been implemented, even in the flow API, wi

Re: [PATCH] lib/ethdev: fix segfault in secondary process by validating dev_private pointer

2025-07-22 Thread Stephen Hemminger
On Tue, 22 Jul 2025 22:04:32 +0500 Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> wrote: > Agree, but I think it's also a good practice to guard against known cases > that are prone to crashes. Right but DPDK chooses performance over API safety. For example rx/tx burst doesn't check args. The po

[PATCH v6 12/13] app/dumpcap: use port mirror instead of pdump

2025-07-22 Thread Stephen Hemminger
BPF support is updated. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 468 app/dumpcap/meson.build | 8 +- 2 files changed, 378 insertions(+), 98 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 3d3c0dbc66

[PATCH v6 13/13] pdump: mark API and application as deprecated

2025-07-22 Thread Stephen Hemminger
When the pdump application is run print a warning. Add release note about deprecation and mark the API's as deprecated. Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 3 +++ app/pdump/meson.build | 1 + app/test-pmd/meson.

[PATCH v6 11/13] app/testpmd: support for port mirroring

2025-07-22 Thread Stephen Hemminger
Add new commands to enable testing of port mirror functionality. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 1 + app/test-pmd/cmdline_mirror.c | 129 app/test-pmd/cmdline_mirror.h | 12 ++ app/test-pmd

[PATCH v6 10/13] test: add tests for ethdev mirror

2025-07-22 Thread Stephen Hemminger
Simple API and packet mirroring standalone tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_ethdev_mirror.c | 286 ++ 2 files changed, 287 insertions(+) create mode 100644 app/test/test_ethdev_mirror.c diff --git

[PATCH v6 09/13] pcapng: make queue optional

2025-07-22 Thread Stephen Hemminger
The queue field is optional in pcapng received packet. Use UINT16_MAX as flag value. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 7 --- lib/pcapng/rte_pcapng.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng

[PATCH v6 08/13] pcapng: split packet copy from header insertion

2025-07-22 Thread Stephen Hemminger
In new model, the packet was already copied, only need to wrap it in pcapng format. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 178 +--- lib/pcapng/rte_pcapng.h | 27 +- 2 files changed, 120 insertions(+), 85 deletions(-) diff --git

[PATCH v6 07/13] ethdev: add port mirroring feature

2025-07-22 Thread Stephen Hemminger
This adds new feature port mirroring to the ethdev layer. Signed-off-by: Stephen Hemminger --- config/rte_config.h | 1 + lib/ethdev/ethdev_driver.h | 6 + lib/ethdev/ethdev_private.c | 58 - lib/ethdev/ethdev_private.h | 3 + lib/ethdev/ethdev_trace.h

[PATCH v6 06/13] mbuf: add dynamic flag for use by port mirroring

2025-07-22 Thread Stephen Hemminger
Add names for new port mirror fields. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/mbuf/rte_mbuf_dyn.h b/lib/mbuf/rte_mbuf_dyn.h index 865c90f579..72a31b22b3 100644 --- a/lib/mbuf/rte_mbuf_dyn.h +++ b/lib/mbuf

[PATCH v6 05/13] net/ring: add new devarg to create vdev from existing ring

2025-07-22 Thread Stephen Hemminger
n the parameter. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 966c64d9a5..a43ff20ecc 100644 --- a/drivers/net

[PATCH v6 04/13] net/ring: allow lockfree transmit if ring supports it

2025-07-22 Thread Stephen Hemminger
Need to be able have multiple threads all using same transmit queue when using SPAN. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c

[PATCH v6 02/13] ethdev: make sure all necessary headers included

2025-07-22 Thread Stephen Hemminger
Best not to depend on other EAL headers to include stuff. Some of the later changes had build failures on some platforms. Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_private.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev

[PATCH v6 03/13] test: add test for hotplug and secondary process operations

2025-07-22 Thread Stephen Hemminger
Use null device to exercise ethdev start/stop in secondary process. Signed-off-by: Stephen Hemminger --- app/test/test_mp_secondary.c | 51 +--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/app/test/test_mp_secondary.c b/app/test

[PATCH v6 00/13] Packet capture using port mirroring

2025-07-22 Thread Stephen Hemminger
more that the overhead of looking at the callback list. TODO items: - need release notes for new features (will wait till 25.11) - more through testing on real hardware v6 - fix build errors on Windows - use libpcap BPF not DPDK bpf to allow Windows support. Stephen Hemminger (13): ethd

[PATCH v6 01/13] ethdev: allow start/stop from secondary process

2025-07-22 Thread Stephen Hemminger
later add queue and other operations as needed. Bugzilla ID: 73 Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_driver.c | 11 - lib/ethdev/ethdev_private.c | 93 + lib/ethdev/ethdev_private.h | 26 +++ lib/ethdev/rte_ethdev.c | 84

[PATCH] dumpcap: fix warnings when primary exits

2025-07-22 Thread Stephen Hemminger
If primary process exits, there is no point in calling pdump to release resources. Bugzilla ID: 1760 Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 11 ++- 1 file changed, 6 insertions(+), 5

Re: [PATCH] lib/ethdev: fix segfault in secondary process by validating dev_private pointer

2025-07-22 Thread Stephen Hemminger
On Tue, 22 Jul 2025 19:30:41 +0500 Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> wrote: > Hi Stephen, > Can we add only the check that fixes the segfault, or do you mean that it > should be fixed at the PMD level? > > Best regards, > Khadem > > On Tue, Jul 22,

Re: [PATCH] app/testpmd: fix set cores list string size

2025-07-21 Thread Stephen Hemminger
On Tue, 8 Jul 2025 20:51:59 +0800 Dengdui Huang wrote: > The cmdline_fixed_string_t has a length of only 128, which will > become insufficient when there are many cores, so it should be > replaced with a cmdline_multi_string_t of larger capacity. > > Fixes: af75078fece3 ("first public release")

Re: [PATCH 0/3] common/sfc_efx/base: fix compiler warnings in X4 netport API

2025-07-21 Thread Stephen Hemminger
On Fri, 11 Jul 2025 18:43:46 +0400 Ivan Malov wrote: > The 25.07 release has got support for AMD Solarflare X45xx adapters [1]. > This series is a follow-up to [1] to fix compiler warnings in the base > driver that are seen in Windows driver build, also based on this driver. > > [1] https://patc

Re: [PATCH] app/testpmd: fix set cores list string size

2025-07-21 Thread Stephen Hemminger
On Tue, 8 Jul 2025 20:51:59 +0800 Dengdui Huang wrote: > The cmdline_fixed_string_t has a length of only 128, which will > become insufficient when there are many cores, so it should be > replaced with a cmdline_multi_string_t of larger capacity. > > Fixes: af75078fece3 ("first public release")

Re: [PATCH 0/7] net/gve: Tx datapath fixes for GVE DQO

2025-07-21 Thread Stephen Hemminger
On Mon, 7 Jul 2025 16:18:04 -0700 Joshua Washington wrote: > There are a number of consistency errors with the DQO Tx datapath, which > this series aims to address. These changes should make the driver much > more resilient against edge case and malformed packets overall. > > Joshua Washington

Re: [PATCH v10 14/14] net/sxe: add Solve compilation problems.

2025-07-21 Thread Stephen Hemminger
On Sat, 19 Jul 2025 17:05:37 +0800 Jie Liu wrote: > Add Fix compiling issues. > > Signed-off-by: Jie Liu > --- Build is failing on the check-doc-vs-code tool which compares rte_flow in code vs document.

Re: [PATCH v10 02/14] net/sxe: add ethdev probe and remove

2025-07-21 Thread Stephen Hemminger
On Sat, 19 Jul 2025 17:05:25 +0800 Jie Liu wrote: > + > +#ifndef fallthrough > +# define fallthrough do {} while (0) > +#endif > + This won't do what is expected. Compilers will complain that switch statement has unexpected fall through. Either make it an attribute or use comment instead.

Re: [PATCH v10 13/14] net/sxe: add virtual function

2025-07-21 Thread Stephen Hemminger
On Sat, 19 Jul 2025 17:05:36 +0800 Jie Liu wrote: > diff --git a/drivers/net/sxe/base/sxevf_hw.c b/drivers/net/sxe/base/sxevf_hw.c > new file mode 100644 > index 00..7425bafedb > --- /dev/null > +++ b/drivers/net/sxe/base/sxevf_hw.c > @@ -0,0 +1,951 @@ > +/* SPDX-License-Identifier: BSD-3

Re: [PATCH v10 10/14] net/sxe: add xstats function

2025-07-21 Thread Stephen Hemminger
On Sat, 19 Jul 2025 17:05:33 +0800 Jie Liu wrote: > +s32 sxe_eth_stats_get(struct rte_eth_dev *eth_dev, > + struct rte_eth_stats *stats) > +{ > + struct sxe_adapter *adapter = eth_dev->data->dev_private; > + struct sxe_stats_info *stats_info = &adapter->stats_i

Re: [PATCH v10 14/14] net/sxe: add Solve compilation problems.

2025-07-21 Thread Stephen Hemminger
On Sat, 19 Jul 2025 17:05:37 +0800 Jie Liu wrote: > Add Fix compiling issues. > > Signed-off-by: Jie Liu > --- Please incorporate review feedback in new versions. I and others gave the feedback that this patch should be combined in with the patches that were problematic. Rather than one fix u

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Stephen Hemminger
On Mon, 21 Jul 2025 12:58:19 +0200 Dariusz Sosnowski wrote: > I don't think it's an issue on PMD level, but rather on > ethdev/multi-process handling level. > > When primary process closes the port, ethdev library zeroes and frees > device data shared between processes. > ethdev port data (rte_e

[PATCH v5 03/13] test: add test for hotplug and secondary process operations

2025-07-18 Thread Stephen Hemminger
Use null device to exercise ethdev start/stop in secondary process. Signed-off-by: Stephen Hemminger --- app/test/test_mp_secondary.c | 51 +--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/app/test/test_mp_secondary.c b/app/test

[PATCH v5 13/13] pdump: mark API and application as deprecated

2025-07-18 Thread Stephen Hemminger
When the pdump application is run print a warning. Add release note about deprecation and mark the API's as deprecated. Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 3 +++ app/pdump/meson.build | 1 + app/test-pmd/meson.

[PATCH v5 12/13] app/dumpcap: use port mirror instead of pdump

2025-07-18 Thread Stephen Hemminger
Use the new port mirror API instead of pdump. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 443 +--- app/dumpcap/meson.build | 2 +- 2 files changed, 373 insertions(+), 72 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c

[PATCH v5 10/13] test: add tests for ethdev mirror

2025-07-18 Thread Stephen Hemminger
Simple API and packet mirroring standalone tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_ethdev_mirror.c | 286 ++ 2 files changed, 287 insertions(+) create mode 100644 app/test/test_ethdev_mirror.c diff --git

[PATCH v5 11/13] app/testpmd: support for port mirroring

2025-07-18 Thread Stephen Hemminger
Add new commands to enable testing of port mirror functionality. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 1 + app/test-pmd/cmdline_mirror.c | 129 app/test-pmd/cmdline_mirror.h | 12 ++ app/test-pmd

[PATCH v5 09/13] pcapng: make queue optional

2025-07-18 Thread Stephen Hemminger
The queue field is optional in pcapng received packet. Use UINT16_MAX as flag value. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 7 --- lib/pcapng/rte_pcapng.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng

[PATCH v5 08/13] pcapng: split packet copy from header insertion

2025-07-18 Thread Stephen Hemminger
In new model, the packet was already copied, only need to wrap it in pcapng format. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 178 +--- lib/pcapng/rte_pcapng.h | 27 +- 2 files changed, 120 insertions(+), 85 deletions(-) diff --git

  1   2   3   4   5   6   7   8   9   10   >