Re: [dpdk-dev] [PATCH] net/szedata2: add Silicom Mango support

2019-07-01 Thread Rastislav Černay
Hi, I sent patches for both nfb and szedata2 with the documentation update. Patches: https://patches.dpdk.org/patch/55764/ https://patches.dpdk.org/patch/55763/ *Rastislav Černay I Software DeveloperNetcope Technologies, a.s.T: +420 530 510 680 <+420%20530%20510%20680>A: Sochorova 3

Re: [dpdk-dev] [PATCH v5] net/nfb: new netcope driver

2019-04-02 Thread Rastislav Černay
on same system. So our solution is not to test them both at same time. *Rastislav Černay I Software DeveloperNetcope Technologies, a.s.T: +420 530 510 680 <+420%20530%20510%20680>A: Sochorova 3232/34, Brno, 616 00, Czech Republic <https://maps.google.com/?q=Sochorova+3232/34,+Brno,+616+00,%C2%A0

Re: [dpdk-dev] [PATCH v5] net/nfb: new netcope driver

2019-04-01 Thread Rastislav Černay
as experimental, please see doc/guides/contributing/versioning.rst So after reading doc/guides/contributing/versioning.rst I thought that all new drivers should be experimental as they are new before they stabilize, and during this time changes can be done to public functions without much hassl

Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver

2019-03-06 Thread Rastislav Černay
> > > --Why is -lfdt added? I don't see any symbols from libfdt used in the > --rest of the patch? > Hi, libnfb is dependent on fdt and there is a special case, where some functions are defined in header (netcope/rxmac.h, netcope/txmac.h). So if one wants to use functions, from these headers fdt n

Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver

2019-03-04 Thread Rastislav Černay
2019 at 1:35 PM David Marchand > wrote: > >> >> >> On Mon, Mar 4, 2019 at 1:30 PM Rastislav Černay >> wrote: >> >>> >>> What is the point of adding when i >= RTE_ETHDEV_QUEUE_STAT_CNTRS ? >>> >>> struct rte_eth_stats { >

Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver

2019-03-04 Thread Rastislav Černay
>>> What is the point of adding when i >= RTE_ETHDEV_QUEUE_STAT_CNTRS ? struct rte_eth_stats { ... uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS] ... } As there can be more queues (nb_tx) then RTE_ETHDEV_QUEUE_STAT_CNTRS (16) and struct rte_eth_stats eth_stats is allocated statically, there is

Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver

2019-03-04 Thread Rastislav Černay
Typically device works in promiscuous mode and filtering/processing is done after packets are received, use of MACS is a marginal case so we are not exactly focused on it. I will add random ethernet address so card can work in initial state with multiple devices. On Fri, Mar 1, 2019 at 7:47 PM

Re: [dpdk-dev] [PATCH] net/nfb: new netcope driver

2019-02-26 Thread Rastislav Černay
Hi, examples/skeleton/basicfwd.c should not be touched in any way, it is mistake. *Rastislav Černay I Software DeveloperNetcope Technologies, a.s.T: +420 530 510 680 <+420%20530%20510%20680>A: Sochorova 3232/34, Brno, 616 00, Czech Republic <https://maps.google.com/?q=Sochorov