Re: [dpdk-dev] [kmods PATCH 0/3] windows/virt2phys: fix paging issue

2021-06-28 Thread Ranjit Menon
| 49 +++ 6 files changed, 472 insertions(+), 29 deletions(-) create mode 100644 windows/virt2phys/virt2phys_logic.c create mode 100644 windows/virt2phys/virt2phys_logic.h create mode 100644 windows/virt2phys/virt2phys_trace.h Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH 3/3] eal/windows: cleanup interrupt resources

2021-05-11 Thread Ranjit Menon
+ * Request interrupt thread to stop and wait its termination. + */ +void eal_intr_thread_cancel(void); + /** * Open virt2phys driver interface device. * Other than nit above, Acked-by: Ranjit Menon

Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] eal/windows: cleanup interrupt resources

2021-05-11 Thread Ranjit Menon
On 5/11/2021 12:59 AM, Dmitry Kozlyuk wrote: 2021-05-11 09:41 (UTC+0200), Thomas Monjalon: 02/05/2021 04:33, Dmitry Kozlyuk: Interrupt manager in Windows EAL allocates on IOCP and starts a control thread that runs indefinitely. At DPDK cleanup this thread was not stopped and IOCP handle was n

Re: [dpdk-dev] [PATCH v10 0/4] eal/windows: do not expose POSIX symbols

2021-04-14 Thread Ranjit Menon
/include/netinet/ip.h create mode 100644 lib/librte_eal/windows/include/rte_os_shim.h delete mode 100644 lib/librte_eal/windows/include/sys/socket.h Thanks, Dmitry. Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-14 Thread Ranjit Menon
On 4/14/2021 2:42 PM, Thomas Monjalon wrote: 14/04/2021 23:34, Ranjit Menon: On 4/14/2021 2:12 PM, Thomas Monjalon wrote: 13/04/2021 09:00, Dmitry Kozlyuk: Hi Ranjit, 2021-04-12 21:46 (UTC-0700), Ranjit Menon: [...] The change to remove the networking shim breaks l2fwd compilation on

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-14 Thread Ranjit Menon
On 4/14/2021 2:12 PM, Thomas Monjalon wrote: 13/04/2021 09:00, Dmitry Kozlyuk: Hi Ranjit, 2021-04-12 21:46 (UTC-0700), Ranjit Menon: [...] The change to remove the networking shim breaks l2fwd compilation on Windows, since l2fwd/main.c includes netinet/in.h explicitly. How do you propose

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-12 Thread Ranjit Menon
Hi Dmitry, On 4/10/2021 3:47 PM, Dmitry Kozlyuk wrote: On Windows, EAL contains two sets of functions and macros for POSIX compatibility: and a networking shim (socket headers). The latter conflicts with system headers and should not exist. Exposing the former from EAL can break consumer own PO

Re: [dpdk-dev] [PATCH v2] mem: fix cleanup when multi-process is disabled

2021-03-25 Thread Ranjit Menon
%s\n", + rte_strerror(rte_errno)); rte_eal_get_configuration()->mem_config = NULL; return 0; Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v2] bus/pci: fix Windows kernel driver categories

2021-03-18 Thread Ranjit Menon
essage --- drivers/bus/pci/rte_bus_pci.h | 13 +++-- drivers/bus/pci/windows/pci.c | 14 +++--- 2 files changed, 14 insertions(+), 13 deletions(-) Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH] bus/pci: fix Windows kernel driver categories

2021-03-18 Thread Ranjit Menon
On 3/18/2021 12:49 AM, Thomas Monjalon wrote: 18/03/2021 00:17, Ranjit Menon: Hi Thomas, On 3/16/2021 4:11 PM, Thomas Monjalon wrote: In Windows probing, the value RTE_PCI_KDRV_NONE was used instead of RTE_PCI_KDRV_UNKNOWN (mlx case), and RTE_PCI_KDRV_NIC_UIO (FreeBSD) was re-used instead

Re: [dpdk-dev] [PATCH] bus/pci: fix Windows kernel driver categories

2021-03-17 Thread Ranjit Menon
Hi Thomas, On 3/16/2021 4:11 PM, Thomas Monjalon wrote: In Windows probing, the value RTE_PCI_KDRV_NONE was used instead of RTE_PCI_KDRV_UNKNOWN (mlx case), and RTE_PCI_KDRV_NIC_UIO (FreeBSD) was re-used instead of having a new RTE_PCI_KDRV_NET_UIO for Windows NetUIO. Shouldn't the mlx case act

Re: [dpdk-dev] [PATCH v4 0/4] eal/windows: do not expose POSIX symbols

2021-03-17 Thread Ranjit Menon
-- 19 files changed, 122 insertions(+), 105 deletions(-) Sorry, ack-ed the v1 of this patch series by mistake. This is the real ACK! Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v3 0/4] net: replace Windows networking shim

2021-03-17 Thread Ranjit Menon
elete mode 100644 lib/librte_eal/windows/include/sys/socket.h Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH 0/7] eal/windows: do not expose POSIX symbols

2021-03-17 Thread Ranjit Menon
ev/rte_ethdev.c| 2 +- lib/librte_kvargs/rte_kvargs.c| 17 ++-- 38 files changed, 266 insertions(+), 206 deletions(-) Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul

2021-03-11 Thread Ranjit Menon
On 3/11/2021 5:34 PM, Tyler Retzlaff wrote: On Thu, Mar 11, 2021 at 04:40:58PM -0800, Ranjit Menon wrote: On 3/11/2021 1:08 PM, Tyler Retzlaff wrote: diff --git a/lib/librte_eal/include/rte_common.h b/lib/librte_eal/include/rte_common.h index 1b630baf1..640befee2 100644 --- a/lib/librte_eal

Re: [dpdk-dev] [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul

2021-03-11 Thread Ranjit Menon
On 3/11/2021 1:08 PM, Tyler Retzlaff wrote: Avoid expanding v and mul parameters multiple times in the macro. based on usage of the macro it seems like side effects were not intended. For example: ``return RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ);'' Signed-off-by: Tyler Retzl

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-10 Thread Ranjit Menon
return (uint32_t)__builtin_ctzll(v); Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v4] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-03-03 Thread Ranjit Menon
ET) || IsEqualGUID(&(device_info_data.ClassGuid), &GUID_DEVCLASS_NETUIO)) { ret = pci_scan_one(dev_info, &device_info_data); This last change appears to be a formatting change. Was it required by checkpatch? Other than that... Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH] eal/windows: add missing SPDX license tag

2021-03-01 Thread Ranjit Menon
ry Kozlyuk + */ + #include #include #include Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v2] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-02-18 Thread Ranjit Menon
Hi Khoa, On 2/18/2021 10:40 AM, Khoa To wrote: EAL -a and -b options are used to specify which PCI devices are explicitly allowed or blocked during PCI bus scan. This evaluation is missing in the Windows implementation of rte_pci_scan. This patch provides this missing functionality, so that app

Re: [dpdk-dev] [PATCH v3 0/2] Support i40e PMD on Windows

2021-01-14 Thread Ranjit Menon
On 1/14/2021 2:55 PM, Thomas Monjalon wrote: 22/12/2020 01:45, Pallavi Kadam: Pallavi Kadam (2): eal: add rte_random.c file on windows build: i40e PMD on Windows Applied, thanks For info, I've fixed an additional warning in i40e compilation on Windows: drivers/net/i40e/i40e_has

Re: [dpdk-dev] [PATCH v3] pci/windows: fix build with SDK >= 10.0.20253

2021-01-14 Thread Ranjit Menon
to redefinition. Fixes: c76ec01b4591 (bus/pci: support netuio on Windows) Cc: sta...@dpdk.org Signed-off-by: Tyler Retzlaff --- drivers/bus/pci/windows/pci_netuio.c | 6 ++ drivers/bus/pci/windows/pci_netuio.h | 2 ++ 2 files changed, 8 insertions(+) Acked-by: Ranjit Menon Quick q: Do

Re: [dpdk-dev] [PATCH v3 2/2] build: i40e PMD on Windows

2021-01-13 Thread Ranjit Menon
On 1/13/2021 2:52 PM, Thomas Monjalon wrote: 22/12/2020 01:45, Pallavi Kadam: Allows i40e PMD to compile on Windows and disable other drivers. Disable few warnings with Clang such as comparison of integers of different signs and macro redefinitions. Adds temp folder mlx5/windows as it is requir

Re: [dpdk-dev] [PATCH] build: fix using ELF-only linker flags with COFF

2021-01-13 Thread Ranjit Menon
LS variables with DLLs is problematic on Windows for now, so not attempting to check or solve the issue with plugin load. app/meson.build | 2 +- buildtools/pkg-config/meson.build | 6 +- examples/meson.build | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH] pci/windows: do not fail on missing NUMA node for PCIe

2020-12-14 Thread Ranjit Menon
d, 9 insertions(+) Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH] windows: minor build fixes

2020-10-30 Thread Ranjit Menon
endif else if is_windows lk_args = ['-Wl,--version-script=' + mingw_map.full_path()] Thanks, Nick. This finally fixes this problem I've been having since I upgraded to meson v0.54. Tested-by: Ranjit Menon Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v3] cmdline: avoid name clash with Windows system types

2020-10-30 Thread Ranjit Menon
On 10/29/2020 6:01 PM, Dmitry Kozlyuk wrote: cmdline_numtype member names clash with Windows system identifiers. Add RTE_ prefix to cmdline constants to avoid this and possible future conflicts. Suggested-by: Ranjit Menon Signed-off-by: Dmitry Kozlyuk --- v3: change prefix from CMDLINE_ to

Re: [dpdk-dev] [PATCH] eal: create a runtime directory on windows

2020-10-22 Thread Ranjit Menon
administrator privileges. As a result, if the user is not admin, the application will fail. Signed-off-by: Ranjit Menon Signed-off-by: Pallavi Kadam --- lib/librte_eal/windows/eal.c | 57 1 file changed, 57 insertions(+) diff --git a/lib/librte_eal/windows/eal.c b

Re: [dpdk-dev] [RFC] rcu: build on Windows

2020-10-20 Thread Ranjit Menon
On 10/20/2020 9:37 AM, Dharmik Thakkar wrote: On Oct 20, 2020, at 10:52 AM, Dmitry Kozlyuk wrote: On Tue, 20 Oct 2020 12:51:14 +, Dharmik Thakkar wrote: I tried cross-compilation on Linux (Ubuntu 18.04) with MinGW-w64 toolchain, but I am seeing some compilation error: ../lib/librte_e

Re: [dpdk-dev] [PATCH] bus/pci: clear undefined bits in Windows segment parsing

2020-10-14 Thread Ranjit Menon
dev_and_func >> 16; addr->function = dev_and_func & 0x; Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v4 1/2] eal/windows: add pthread mutex lock

2020-10-14 Thread Ranjit Menon
) +{ + LeaveCriticalSection(mutex); + return 0; +} + +static inline int +pthread_mutex_destroy(pthread_mutex_t *mutex) +{ + DeleteCriticalSection(mutex); + return 0; +} + #ifdef __cplusplus } #endif Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for clang

2020-10-06 Thread Ranjit Menon
rte_mem_map Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for clang

2020-10-02 Thread Ranjit Menon
Hi Tal, On 10/2/2020 12:18 PM, Tal Shnaiderman wrote: export for clang build all the functions currently built on Windows and listed in rte_eal_version.map by adding them to rte_eal_exports.def. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/rte_eal_exports.def | 156 +

Re: [dpdk-dev] [PATCH v5] windows/netuio: add Windows NetUIO kernel driver

2020-10-02 Thread Ranjit Menon
r now: Reviewed-by: Ranjit Menon Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v5] bus/pci: netuio interface for windows

2020-09-29 Thread Ranjit Menon
Hi Tal, On 9/29/2020 1:28 AM, Tal Shnaiderman wrote: [snip] In general: Regarding the issue Ranjit mentioned in the last community call on duplicated detection of netuio devices both as GUID_DEVCLASS_NETUIO and GUID_DEVCLASS_NET, in pci_scan_one there is actually code that take cares of dupli

Re: [dpdk-dev] [PATCH] mempool/ring: build on Windows

2020-09-24 Thread Ranjit Menon
/stack/meson.build +++ b/drivers/mempool/stack/meson.build @@ -1,6 +1,11 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017-2019 Intel Corporation +if is_windows + build = false + reason = 'not supported on Windows' +endif + sources = files('rte_mempool_stack.c') deps += ['stack'] Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v4] windows/netuio: add Windows NetUIO kernel driver

2020-09-22 Thread Ranjit Menon
On 9/18/2020 7:52 PM, Narcisa Ana Maria Vasile wrote: From: Narcisa Vasile The Windows netuio kernel driver provides the DPDK userspace application with direct access to hardware, by mapping the HW registers in userspace and allowing read/write operations from/to the device configuration spac

Re: [dpdk-dev] [PATCH v2] bus/pci: netuio interface for windows

2020-09-16 Thread Ranjit Menon
On 9/16/2020 5:48 PM, Ranjit Menon wrote: Hi, Stephen On 9/15/2020 6:54 PM, Stephen Hemminger wrote: On Tue, 15 Sep 2020 16:28:03 -0700 Pallavi Kadam wrote: +    if (IsEqualGUID((const void *)&(device_info_data->ClassGuid), +    (const void *)&GUID_DEVCLASS_NETUIO)) Is ther

Re: [dpdk-dev] [PATCH v2] bus/pci: netuio interface for windows

2020-09-16 Thread Ranjit Menon
Hi, Stephen On 9/15/2020 6:54 PM, Stephen Hemminger wrote: On Tue, 15 Sep 2020 16:28:03 -0700 Pallavi Kadam wrote: + if (IsEqualGUID((const void *)&(device_info_data->ClassGuid), + (const void *)&GUID_DEVCLASS_NETUIO)) Is there anyway to get rid of casts and have the righ

Re: [dpdk-dev] [PATCH] bus/pci: support segment value as address domain on Windows

2020-09-16 Thread Ranjit Menon
= 0; - addr->bus = bus_num; + addr->domain = bus_num >> 8; + addr->bus = bus_num & 0xff; addr->devid = dev_and_func >> 16; addr->function = dev_and_func & 0x; return 0; Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH] bus/pci: netuio interface for windows

2020-09-15 Thread Ranjit Menon
for netuio source code is known. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- drivers/bus/pci/windows/pci.c | 293 +-- --- 1 file changed, 257 insertions(+), 36 deletions(-) diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c

Re: [dpdk-dev] [PATCH] cmdline: avoid name clash with Windows system types

2020-08-21 Thread Ranjit Menon
On 8/21/2020 11:48 AM, Dmitry Kozlyuk wrote: cmdline_numtype member names clash with Windows system identifiers. Add CMDLINE_ prefix to cmdline constants to avoid this and possible future conflicts. Signed-off-by: Dmitry Kozlyuk Suggested-by: Ranjit Menon --- This patch made some lines

Re: [dpdk-dev] [PATCH v2] windows/netuio: add Windows NetUIO kernel driver

2020-08-20 Thread Ranjit Menon
Hi, Naty On 8/20/2020 3:23 PM, Narcisa Ana Maria Vasile wrote: From: Narcisa Vasile The Windows NetUIO kernel driver allows the DPDK userspace application to directly access the hardware. Cc: Harini Ramakrishnan Cc: Omar Cardona Signed-off-by: Narcisa Vasile --- v2: Fix license message

Re: [dpdk-dev] [PATCH v5 0/5] compiling ethdev lib under windows

2020-08-20 Thread Ranjit Menon
elemetry.c | 50 lib/librte_telemetry/telemetry_legacy.c | 25 lib/meson.build | 3 +- 8 files changed, 111 insertions(+), 3 deletions(-) create mode 100644 lib/librte_eal/windows/eal_interrupts.c Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH 00/22] windows/netuio: add netuio driver for Windows

2020-08-14 Thread Ranjit Menon
On 8/14/2020 1:57 PM, Dmitry Kozlyuk wrote: On Fri, 14 Aug 2020 13:26:11 -0700, Narcisa Ana Maria Vasile wrote: On Fri, Aug 14, 2020 at 11:01:39PM +0300, Dmitry Kozlyuk wrote: On Thu, 13 Aug 2020 16:21:23 -0700, Narcisa Ana Maria Vasile wrote: [...] As far as I understand, you're importing

Re: [dpdk-dev] [PATCH] maintainers: update Windows Maintainers

2020-08-06 Thread Ranjit Menon
/MAINTAINERS @@ -338,10 +338,10 @@ M: Bruce Richardson F: kernel/freebsd/nic_uio/ Windows support -M: Harini Ramakrishnan -M: Omar Cardona +M: Dmitry Kozlyuk +M: Narcisa Ana Maria Vasile +M: Dmitry Malloy M: Pallavi Kadam -M: Ranjit Menon F: lib/librte_eal/windows/ F: lib/librte_eal

Re: [dpdk-dev] [PATCH v4 0/3] compile librte_net for windows

2020-07-23 Thread Ranjit Menon
/librte_eal/windows/include/netinet/ip.h Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v2] eal/windows: detect insufficient privileges for hugepages

2020-07-08 Thread Ranjit Menon
RTE_LOG(ERR, EAL, "Cannot get hugepage information\n"); + RTE_LOG(ERR, EAL, "Cannot discover available hugepages\n"); return -1; } Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges for hugepages

2020-07-07 Thread Ranjit Menon
On 7/7/2020 1:22 PM, Dmitry Kozlyuk wrote: AdjustTokenPrivileges() succeeds even if no requested privileges have been granted; this behavior is documented. Check last error code in addition to return value to detect such case. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/windows/eal_hug

Re: [dpdk-dev] [PATCH 1/2] eal/windows: Add needed calls to detect vdev PMD

2020-07-07 Thread Ranjit Menon
On 7/7/2020 1:39 AM, Dmitry Kozlyuk wrote: On Tue, 7 Jul 2020 08:04:00 +, Tal Shnaiderman wrote: Dmitry, It looks like we got to this stage since hugepage_claim_privilege() cannot actually detect that "Lock pages" isn't granted to the current user, as a result we fail on the first usage

Re: [dpdk-dev] [PATCH 6/7] cmdline: support Windows

2020-06-28 Thread Ranjit Menon
On 6/28/2020 7:20 AM, Fady Bader wrote: Hi Dmitry, I'm trying to run test-pmd on Windows and I ran into this error with cmdline. The error log message is : In file included from ../app/test-pmd/cmdline_flow.c:23: ..\lib\librte_cmdline/cmdline_parse_num.h:24:2: error: 'INT64' redeclared as dif

Re: [dpdk-dev] [PATCH v4] eal/windows: fix thread handle

2020-06-24 Thread Ranjit Menon
Hi, Tasnim... On 6/24/2020 4:10 PM, Tasnim Bashar wrote: Casting thread ID to handle is not accurate way to get thread handle. Need to use OpenThread function to get thread handle from thread ID. pthread_setaffinity_np and pthread_getaffinity_np functions for Windows are affected because of it.

Re: [dpdk-dev] [PATCH v10 0/2] eal timer split and implementation for Windows

2020-06-18 Thread Ranjit Menon
eate mode 100644 lib/librte_eal/unix/eal_unix_timer.c create mode 100644 lib/librte_eal/windows/eal_timer.c Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v9 2/2] timer: support EAL functions on Windows

2020-06-17 Thread Ranjit Menon
On 6/17/2020 2:39 AM, Fady Bader wrote: Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 91

Re: [dpdk-dev] [PATCH v8 3/3] timer: support EAL functions on Windows

2020-06-16 Thread Ranjit Menon
On 6/14/2020 1:43 AM, Fady Bader wrote: Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 90

Re: [dpdk-dev] [PATCH v9 00/12] Windows basic memory management

2020-06-15 Thread Ranjit Menon
. * Do not use rte_panic() in library code. * Fix typos, comments, string formatting. * Split documentation commits. Great work on this, Dmitry! I know the patch has already been applied, but: Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v2 2/4] mempool: use generic memory management

2020-06-01 Thread Ranjit Menon
On 6/1/2020 12:59 PM, Dmitry Kozlyuk wrote: On Mon, 1 Jun 2020 13:31:37 +0300 Fady Bader wrote: [snip] /* populate the mempool with an anonymous mapping */ @@ -740,20 +739,20 @@ rte_mempool_populate_anon(struct rte_mempool *mp) } /* get chunk of virtually continuous memory */

Re: [dpdk-dev] [PATCH v4] eal/windows: ring build on Windows

2020-05-27 Thread Ranjit Menon
On 5/27/2020 1:24 AM, Fady Bader wrote: Exported per_lcore__rte_errno function to compile ring for windows. compilation error logs: librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol per_lcore__rte_errno referenced in function rte_ring_lookup The cause was that per_lcore__rt

Re: [dpdk-dev] [PATCH v2] ring: build on Windows

2020-05-20 Thread Ranjit Menon
On 5/20/2020 3:44 AM, Fady Bader wrote: Exported per_lcore__rte_errno function to compile ring for windows. compilation error logs: librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol per_lcore__rte_errno referenced in function rte_ring_lookup The cause was that per_lcore__rt

Re: [dpdk-dev] [PATCH] mbuf: align rte_mbuf for Windows

2020-05-19 Thread Ranjit Menon
*/ #else uint8_t inner_l4_type:4; /**< Inner L4 type. */ #endif }; We didn't have the bandwidth to test this on other OS, so we used #ifdef, but we know this allowed us to be as performant as Linux (using L3Fwd). Therefore: Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH] eal: fix warnings on Windows

2020-05-14 Thread Ranjit Menon
eal_common_options.c Signed-off-by: Ranjit Menon Signed-off-by: Pallavi Kadam Tested-by: Pallavi Kadam --- +#ifndef RTE_EXEC_ENV_WINDOWS static int eal_plugindir_init(const char *path) Why disabling the plugin mechanism? Can we make it working instead? The function that is calling eal_plugindir_init

Re: [dpdk-dev] [PATCH] eal: fix warnings on Windows

2020-05-13 Thread Ranjit Menon
-function] in eal_common_options.c Signed-off-by: Ranjit Menon Signed-off-by: Pallavi Kadam Tested-by: Pallavi Kadam --- lib/librte_eal/common/eal_common_options.c | 6 +- lib/librte_eal/windows/getopt.c| 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/lib

Re: [dpdk-dev] [PATCH 2/2] eal: add fnmatch implementation on Windows

2020-04-30 Thread Ranjit Menon
On 4/30/2020 12:30 AM, Dmitry Kozlyuk wrote: On 2020-04-30 08:52 GMT+0200 Thomas Monjalon wrote: 30/04/2020 01:24, Pallavi Kadam: Added fnmatch implementation on Windows to support log level arguments. The source file is with BSD-3-Clause license. https://github.com/lattera/freebsd/blob/master/

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-04-28 Thread Ranjit Menon
On 4/28/2020 4:50 PM, Dmitry Kozlyuk wrote: Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain IOVAs of hugepages allocated from user-mode. Multi-process mode is not implemented and is forcefully disabled at st

Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

2020-04-23 Thread Ranjit Menon
On 4/23/2020 3:48 AM, Thomas Monjalon wrote: 23/04/2020 11:06, Dmitry Kozlyuk: On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote: 23/04/2020 01:51, Ranjit Menon: On 4/22/2020 12:27 AM, tal...@mellanox.com wrote: From: Tal Shnaiderman Move common functions between Unix and Windows to

Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

2020-04-22 Thread Ranjit Menon
On 4/22/2020 12:27 AM, tal...@mellanox.com wrote: From: Tal Shnaiderman Move common functions between Unix and Windows to eal_config.c. Like other files in common, we should call this eal_common_config.c Those simple functions are getter functions for IOVA, configuration, Multi-process. M

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-21 Thread Ranjit Menon
On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: diff --git a/lib/librte_eal/windows/eal_memory.c b/lib/librte_eal/windows/eal_memory.c new file mode 100644 index 0..5697187ce --- /dev/null +++ b/lib/librte_eal/windows/eal_memory.c @@ -0,0 +1,437 @@ + + if ((flags & EAL_RESERVE_

Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers

2020-04-21 Thread Ranjit Menon
On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: System meory management is implemented differently for POSIX and Windows. Introduce wrapper functions for operations used across DPDK: * rte_mem_map() Create memory mapping for a regular file or a page file (swap). This supports mapping to a res

Re: [dpdk-dev] [PATCH v3 10/10] eal/windows: implement basic memory management

2020-04-16 Thread Ranjit Menon
On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain IOVAs of hugepages allocated from user-mode. Signed-off-by: Dmitry Kozlyuk --- diff --git a/lib/librte_eal/

Re: [dpdk-dev] [PATCH v3 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-14 Thread Ranjit Menon
On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: This driver supports Windows EAL memory management by translating current process virtual addresses to physical addresses (IOVA). Standalone virt2phys allows using DPDK without PMD and provides a reference implementation. Suggested-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v2 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-12 Thread Ranjit Menon
Reviewed-by: Ranjit Menon Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-10 Thread Ranjit Menon
On 4/9/2020 7:50 PM, Dmitry Kozlyuk wrote: + +_Use_decl_annotations_ +VOID +virt2phys_device_EvtIoInCallerContext( + IN WDFDEVICE device, IN WDFREQUEST request) +{ + WDF_REQUEST_PARAMETERS params; + ULONG code; + PVOID *virt; Should this be PVOID virt; (instead of PVOID

Re: [dpdk-dev] [PATCH 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-09 Thread Ranjit Menon
On 3/29/2020 9:10 PM, Dmitry Kozlyuk wrote: This patch is for dpdk-kmods tree. This driver supports Windows EAL memory management by translating current process virtual addresses to physical addresses (IOVA). Standalone virt2phys allows using DPDK without PMD and provides a reference implementat

Re: [dpdk-dev] Windows Draft Build

2020-02-25 Thread Ranjit Menon
On 2/24/2020 6:37 PM, Dmitry Kozlyuk wrote: > Oh boy! If DriverEntry() is not being called, the loader is finding something wrong and is unable to load the driver. > > @Harini: Can Jeffrey (@MS) help here? By trial and error I determined that changing device class from "Net" to a custom one fix

Re: [dpdk-dev] [PATCH v2] eal/windows: fix out-of-memory check

2020-02-18 Thread Ranjit Menon
s and macros") Signed-off-by: Dmitry Kozlyuk ---   lib/librte_eal/windows/eal/include/rte_os.h | 9 ++---   1 file changed, 6 insertions(+), 3 deletions(-) v2 Changes: Check vsnprintf() value before appending place for '\0'. Acked-by: Ranjit Menon

Re: [dpdk-dev] Windows Draft Build

2020-02-18 Thread Ranjit Menon
On 2/16/2020 5:14 PM, Dmitry Kozlyuk wrote: Hi, > "Dpdk.sln" builds OK, will try launching sample apps > a bit later. Netuio driver consistently fails to install on Windows 10 in QEMU with virtio-net (modern interface). Described below is my attempt to install the driver from clean "windpdk-v18

Re: [dpdk-dev] [PATCH v8 1/9] license: add license exception for windows

2020-02-12 Thread Ranjit Menon
On 2/12/2020 1:38 PM, Thomas Monjalon wrote: 07/02/2020 04:14, Pallavi Kadam: The Governing Board and Tech Board have provided exceptions for MIT and BSD-2-Clause license files for DPDK support on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon

Re: [dpdk-dev] Windows Draft Build

2020-02-09 Thread Ranjit Menon
On 2/8/2020 12:45 AM, Dmitry Kozlyuk wrote: Hi, I'm having trouble building "dpdk.sln" from "windpdk-v18.08-clang" branch of "dpdk-draft-windows" repository using Visual Studio 2019 Community Edition. All projects are set up to use some "llvm" toolset. If I install LLVM Build Tools and switch to

Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-07 Thread Ranjit Menon
On 2/7/2020 8:46 AM, Ranjit Menon wrote: On 2/6/2020 1:26 AM, Thomas Monjalon wrote: > As discussed in community meeting, the goal was to have core parsing > in Windows EAL 20.02. > Given that there is a crash and a doubt on the imported getopt library, > I think it's better

Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-02-07 Thread Ranjit Menon
On 2/6/2020 1:26 AM, Thomas Monjalon wrote: As discussed in community meeting, the goal was to have core parsing in Windows EAL 20.02. Given that there is a crash and a doubt on the imported getopt library, I think it's better to postpone this series to 20.05. Thomas... We have fixed the cras

[dpdk-dev] [PATCH] maintainers: update for Windows

2020-01-13 Thread Ranjit Menon
Since Anand is no longer with Intel, Pallavi will replace him as maintainer. Signed-off-by: Ranjit Menon --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4395d8df1..f6c35cf77 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -318,7

[dpdk-dev] DPDK Windows Community call - 26 June 2019

2019-07-08 Thread Ranjit Menon
Attendees: (present) - Cathal Pallavi Ranjit Harini Haseeb Thomas Absent/apologies: Eilon Greenstein Yohad Tor Raslan rasl...@mellanox.com Bruce Jeff jeffrey.tip...@microsoft.com; Omar Cardona ; Harini harini.ramakrish...@microsoft.com; Khoa k...@microsoft.com; S

[dpdk-dev] DPDK Windows Community call - 11 June 2019

2019-06-24 Thread Ranjit Menon
Attendees: (present) - Cathal Pallavi Ranjit Thomas tho...@monjalon.net Tal Shnaiderman Raslan rasl...@mellanox.com; Harini harini.ramakrish...@microsoft.com; Absent/apologies: Adham Masarwah Eilon Greenstein Yohad Tor Bruce Anan Saif ; Jeff jeffrey.tip...@micro

[dpdk-dev] DPDK Windows Community call - 28 May 2019

2019-06-09 Thread Ranjit Menon
Attendees: (present/accepted) - Cathal Pallavi Ranjit Thomas tho...@monjalon.net Tal Shnaiderman Raslan rasl...@mellanox.com; Harini harini.ramakrish...@microsoft.com; Omar Cardona ; Rani Sharoni ; Absent/apologies: - Adham Masarwah Eilon Greenstein Yohad Tor Bruce

[dpdk-dev] DPDK Windows Community call - 16 May 2019

2019-05-27 Thread Ranjit Menon
Attendees: (present) Cathal Pallavi Bruce Thomas tho...@monjalon.net Adham Masarwah Eilon Greenstein Yohad Tor Tal Shnaiderman Ranjit Anan Saif ; Rani Sharoni ; Raslan rasl...@mellanox.com; Harini harini.ramakrish...@microsoft.com; Omar Cardona ; Jeff jeffrey.tip...@microsoft.com; Khoa k.

[dpdk-dev] DPDK Windows Community call - 02 May 2019

2019-05-09 Thread Ranjit Menon
Attendees: (Present) Thomas (tho...@monjalon.net) Bruce (bruce.richard...@intel.com) Cathal (cathal.oh...@intel.com) Pallavi (pallavi.ka...@intel.com) Ranjit (ranjit.me...@intel.com) Anand (anand.ra...@intel.com) Harini (harini.ramakrish...@microsoft.com) Eilon (eil...@mellanox.com) Raslan (ras

[dpdk-dev] DPDK Windows Community call - 18 April 2019

2019-04-23 Thread Ranjit Menon
Attendees: (Present) Thomas (tho...@monjalon.net) Harini (harini.ramakrish...@microsoft.com) Bruce (bruce.richard...@intel.com) Cathal (cathal.oh...@intel.com) Anand (anand.ra...@intel.com) Pallavi (pallavi.ka...@intel.com) Ranjit (ranjit.me...@intel.com) Eilon (eil...@mellanox.com) Raslan (rasl

[dpdk-dev] DPDK Windows Community call - 04 April 2019

2019-04-08 Thread Ranjit Menon
Attendees: Thomas (tho...@monjalon.net) Eilon (eil...@mellanox.com) Raslan (rasl...@mellanox.com) Harini (harini.ramakrish...@microsoft.com) Bruce (bruce.richard...@intel.com) Cathal (cathal.oh...@intel.com) Anand (anand.ra...@intel.com) Pallavi (pallavi.ka...@intel.com) Ranjit (ranjit.me...@intel

[dpdk-dev] DPDK Windows Community call - 28 March 2019

2019-03-28 Thread Ranjit Menon
Attendees:- - Raslan Darawsheh Thomas Monjalon Bruce Richardson Cathal O'Hare Anand Rawat Pallavi Kadam Ranjit Menon * NEW: Bi-weekly call will start 04-Apr-2019 - 4pm Paris, 3pm Shannon, 7am Oregon Invitee list at present: tho...@monjalon.net eil...@mellanox.com

Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows

2019-03-27 Thread Ranjit Menon
. Added def file to list the exports for the eal library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Signed-off-by: Bruce Richardson Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/common/include/rte_common.h| 7 - .../common/include/rte_string_fns.h

Re: [dpdk-dev] checklist for DPDK on Windows

2019-03-19 Thread Ranjit Menon
Thomas... Status below: On 3/19/2019 2:52 AM, Thomas Monjalon wrote: Any feedback? Could we try to give a work estimation for these items? 15/03/2019 00:04, Thomas Monjalon: Hi, Below is a list of directories, files or functions which we need to check to make basic DPDK works on Windows. If

Re: [dpdk-dev] [PATCH v2] meson: fix building subdirectories separately

2019-03-05 Thread Ranjit Menon
setting the title to: "build: move variable definition to top level", or something similar. /Bruce Yes. This will help with the Windows port. Acked-by: Ranjit Menon

Re: [dpdk-dev] [PATCH 6/6] doc: add documention for windows

2019-03-01 Thread Ranjit Menon
On 3/1/2019 11:02 AM, Stephen Hemminger wrote: On Thu, 28 Feb 2019 23:18:47 -0800 Anand Rawat wrote: Add documentation to build helloworld example on windows using meson and clang. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit