Re: [dpdk-dev] [PATCH][pktgen] fix repopulation of tx_mbufs table

2018-12-14 Thread Rafał Kozik
pt., 14 gru 2018 o 16:45 Wiles, Keith napisał(a): > > > > > On Dec 14, 2018, at 9:29 AM, Wiles, Keith wrote: > > > > > > > >> On Dec 14, 2018, at 5:26 AM, Rafał Kozik wrote: > >> > >> Hello Keith, > >> > >> as f

Re: [dpdk-dev] [PATCH][pktgen] fix repopulation of tx_mbufs table

2018-12-14 Thread Rafał Kozik
Hello Keith, as from my last post passed about three weeks I would kindly ask if you could provide any comments about this patch? Best regards, Rafal Kozik pt., 23 lis 2018 o 09:23 Rafal Kozik napisał(a): > > If in one TX cycle NIC does not send any packet, pktgen tries > to allocate 0 mbufs fr

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/ena: fix out of order completion

2018-11-21 Thread Rafał Kozik
Hello Ferruh, this patch fix issue in Rx path which could have caused receive of wrong packets. If it is possible, I would be very grateful if this patch could be applied to v18.11. Best regards, Rafal śr., 21 lis 2018 o 16:16 Ferruh Yigit napisał(a): > > On 11/21/2018 8:21 AM, Rafal Kozik wrot

Re: [dpdk-dev] [PATCH] doc: update for ENA supported drivers

2018-10-10 Thread Rafał Kozik
Hello Ferruh, > Unless installed "igb_uio" won't be available to use with "modprobe", not sure > about adding that detail, what do you think? I did not add it. In current version this information is already present: > -#. Bind the intended ENA device to igb_uio module > This is only required if

Re: [dpdk-dev] [PATCH v4 1/4] igb_uio: add wc option

2018-06-29 Thread Rafał Kozik
> How can I confirm this silently fall-back behavior, is there any log can I > turn > on in kernel or anything from proc/sysfs? I cannot find any. I check it by measuring write speed. 2018-06-29 14:17 GMT+02:00 Rafal Kozik : > From: Kozik > > Write combining (WC) increases NIC performance by ma

Re: [dpdk-dev] [PATCH v2 3/4] eal: enable WC during resources mapping

2018-06-29 Thread Rafał Kozik
2018-06-29 11:05 GMT+02:00 Ferruh Yigit : > On 6/29/2018 9:58 AM, Rafał Kozik wrote: >> 2018-06-28 16:50 GMT+02:00 Ferruh Yigit : >>> On 6/28/2018 2:15 PM, Rafal Kozik wrote: >>>> Write combining (WC) increases NIC performance by making better >>>> utiliza

Re: [dpdk-dev] [PATCH v2 3/4] eal: enable WC during resources mapping

2018-06-29 Thread Rafał Kozik
2018-06-28 16:50 GMT+02:00 Ferruh Yigit : > On 6/28/2018 2:15 PM, Rafal Kozik wrote: >> Write combining (WC) increases NIC performance by making better >> utilization of PCI bus, but cannot be used by all PMDs. >> >> It will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in >> drivers flags

Re: [dpdk-dev] [PATCH v2 1/4] igb_uio: add wc option

2018-06-29 Thread Rafał Kozik
2018-06-28 16:32 GMT+02:00 Ferruh Yigit : > On 6/28/2018 2:15 PM, Rafal Kozik wrote: >> Write combining (WC) increases NIC performance by making better >> utilization of PCI bus, but cannot be use by all PMDs. >> >> To get internal_addr memory need to be mapped. But as memory could not be >> mapped

Re: [dpdk-dev] [PATCH 1/4] igb_uio: add wc option

2018-06-28 Thread Rafał Kozik
2018-06-27 18:34 GMT+02:00 Ferruh Yigit : > On 4/11/2018 3:07 PM, Rafal Kozik wrote: >> Write combining (wc) increase NIC performance by making better >> utilization of PCI bus, but cannot be use by all PMD. >> >> Parameter wc_activate add possibility to enable it for >> those PMD that could suppor

Re: [dpdk-dev] [PATCH 3/4] eal: enable WC during resources mapping

2018-06-28 Thread Rafał Kozik
2018-06-27 18:41 GMT+02:00 Ferruh Yigit : > On 4/11/2018 3:07 PM, Rafal Kozik wrote: >> Write combining (wc) increase NIC performenca by making better >> utilization of PCI bus, but cannot be used by all PMD. >> >> It will be enable only if RTE_PCI_DRV_WC_ACTIVATE will be set in >> drivers flags. F

Re: [dpdk-dev] [PATCH 2/4] bus/pci: reference driver structure

2018-06-28 Thread Rafał Kozik
2018-06-27 18:36 GMT+02:00 Ferruh Yigit : > On 4/11/2018 3:07 PM, Rafal Kozik wrote: >> Reference driver structure before calling rte_pci_map_device. >> It allow to use driver flags for adjusting configuration. >> >> Signed-off-by: Rafal Kozik >> --- >> drivers/bus/pci/pci_common.c | 13 -

Re: [dpdk-dev] [PATCH 4/4] net/ena: enable WC

2018-06-28 Thread Rafał Kozik
Hello Thomas, I will fix type, rebase and provide new patch set. Best regards, Rafal Kozik 2018-06-27 18:11 GMT+02:00 Thomas Monjalon : > 11/04/2018 16:07, Rafal Kozik: >> Write combining (wc) increase NIC performenca by making better >> utilization of PCI bus. ENA support this feature. >> >> To

Re: [dpdk-dev] [PATCH 0/4] support for write combining

2018-06-26 Thread Rafał Kozik
GMT+02:00 Rafał Kozik : > Hello Thomas, > > I have a question about support for write combining patch set. > It got ack from Bruce Richardson more then month ago. > Also no one has any further comments about it. > What is the next step to commit them to DPDK source? > > Best regards, > Rafal Kozik

Re: [dpdk-dev] [PATCH 0/4] support for write combining

2018-06-11 Thread Rafał Kozik
Hello Thomas, I have a question about support for write combining patch set. It got ack from Bruce Richardson more then month ago. Also no one has any further comments about it. What is the next step to commit them to DPDK source? Best regards, Rafal Kozik

Re: [dpdk-dev] [PATCH 0/4] support for write combining

2018-04-30 Thread Rafał Kozik
Hello Bruce, It should work because decision about kind of mapping is made in patch 3 based on PMD request. ENA use only one BAR in wc mode and two other without caching, therefore not making remap in igb_uio rather not spoil anything. I added patch 1 because this variable is provided also outsi

Re: [dpdk-dev] [PATCH 0/4] support for write combining

2018-04-27 Thread Rafał Kozik
Hello Bruce, As from my last post passed ten days I would kindly ask if there are any more comments? Best regards, Rafal Kozik

Re: [dpdk-dev] [PATCH 0/4] support for write combining

2018-04-16 Thread Rafał Kozik
Hello Bruce, thank you for your advices. > 1. Why not always have igb_uio support write-combining since it can be > controlled thereafter via userspace mapping one file or another? I added parameter to the igb_uio because currently it perform ioremap and fails if it return NULL. But performing i

Re: [dpdk-dev] [PATCH v2 1/2] net/ena: convert to new Tx offloads API

2018-01-18 Thread Rafał Kozik
2018-01-17 19:58 GMT+01:00 Ferruh Yigit : > On 1/17/2018 8:23 AM, Rafal Kozik wrote: >> Ethdev Tx offloads API has changed since: >> >> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") >> >> This commit support the new Tx offloads API. Queue configuration >> is stored in ena_ring.off