Oh, and I never answered your initial question - yes the traffic generator
issue is now sorted out. Thanks.
On Fri, Sep 26, 2025 at 4:50 PM Patrick Robb wrote:
> Hi Sameer,
>
> Thanks for your patience and I apologize for not reaching out yesterday.
>
> Normally, if you want a
ble to fix the issue with the traffic generator? Is there
> documentation on what steps need to be done to request a rerun?
>
> Thanks
> Sameer Vaze
> ------
> *From:* Patrick Robb
> *Sent:* Wednesday, September 24, 2025 2:24 PM
> *To:* Sameer Vaze
>
Reviewed-by: Patrick Robb
Signed-off-by: Jeremy Spewock
>
> -Args:
> -line: The line to parse.
> +@dataclass
> +class OffloadCapabilities(TextParser):
> +"""The result of testpmd's ``show port tx_offload
> capabilities`` command.
>
tx_offload or rx_offload, right?
Reviewed-by: Patrick Robb
On Wed, Sep 24, 2025 at 12:47 PM Andrew Bailey wrote:
> Currently, the RX/TX offload test in old DTS expects the TX ports to be
> initially configured to use mbuf fast free. This is no longer the case
> and must be updated to assume mbuf fast free is not initially utilized
> by capable NICs. Add
The CI testing failure for this series is due to an issue with the traffic
generator that is unrelated to the patch. I will resolve it tomorrow and do
a test rerun.
On Wed, Sep 24, 2025 at 12:19 PM Sameer Vaze wrote:
> Adds definitions for PDCP checksums and apis to pass in
> dictionaries
>
> Si
Applied with the commit message fixup.
Thanks Andrew.
On Wed, Sep 10, 2025 at 8:30 AM Andrew Bailey wrote:
> Currently, ports on the TG are not bound to the correct drivers prior to
> running DTS. This causes DTS to crash if they are not initially bound to
> the intended drivers. Binding the TG ports to the proper driver caused
> DTS to fail when th
Per the discussion at the CI meeting this morning I ran all the existing
tests on a cx5 card and saw no difference in results with this series
applied vs running on for-main.
So, I will merge this series tomorrow morning. Thanks Paul.
On Thu, Sep 18, 2025 at 1:30 AM Patrick Robb wrote
Hi Thomas,
FYI the recheck you submitted is for Shani's v1 patch. The recheck pipeline
picked up your request and is not running a recheck because the patch state
is superseded (which blocks the recheck). If you still want a recheck on
the v1, I will just remove the line in our script which stops
FYI The DTS failure for this series on patchwork for the MTU testsuite is
coming from a different patch than this one. Once I have that resolved, I
will put in a retest for this series which will clear up that MTU testsuite
failure.
On Mon, Sep 8, 2025 at 5:21 PM Thomas Monjalon wrote:
> After a
Reviewed-by: Patrick Robb
Reviewed-by: Patrick Robb
#
September 4, 2025
Attendees
1. Patrick Robb
2. Aaron Conole
3. Andrew Bailey
4. Luca Vizzarro
#
Minutes
September 11, 2025
Attendees
* Patrick Robb
* Luca Vizzarro
* Andrew Bailey
* Paul Szczepanek
Minutes
August 28, 2025
Attendees
* Patrick Robb
* Luca Vizzarro
* Andrew Bailey
* Paul Szczepanek
* Thomas Wilks
Minutes
FYI The DTS failure for this series on patchwork for the MTU testsuite is
coming from a different patch than this one. Once I have that resolved, I
will put in a retest for this series which will clear up that MTU testsuite
failure.
On Mon, Sep 8, 2025 at 12:35 PM Shani Peretz wrote:
> When --io
Putting in a retest at the Community Lab.
On Tue, Sep 16, 2025 at 5:36 AM Maxime Coquelin
wrote:
> This series is a follow-up of the workaround to ensure queues are
> in a ready state before starting the device.
>
> It also adds a patch to ensure data passed to the kernel are properly
> initiali
v5 pushed to next-dts, thanks.
On Fri, Sep 5, 2025 at 8:41 AM Andrew Bailey wrote:
> Mypy does not check functions and methods that are not entirely type
> hinted. This prevents full checks, so they have been added where missing.
> Full checks revealed some typing errors, pattern matching was ap
On Mon, Sep 8, 2025 at 6:03 AM Luca Vizzarro wrote:
> Hi Patrick,
>
> Perfectly understand the situation, I am just afraid that adding a whole
> 5 seconds every time an InteractiveShell is spawned may slow down
> everything by a lot. These are spawned a lot of times, so it will stack
> up. Is the
x27;t an ideal addition to DTS in my mind, but given that our
existing readiness checks seem correct (but may not be sufficient) this
seems like the correct action to me.
On Sun, Sep 7, 2025 at 9:48 PM Patrick Robb wrote:
> When running our existing DTS testsuites on a new
> NIC we observe
Reviewed-by: Patrick Robb
Applied to next-dts, thanks.
On Thu, Sep 4, 2025 at 5:16 PM Patrick Robb wrote:
> I think the changes in V2 make sense and I have tested it and I like the
> new way logs and pcaps are stored in dts/output. I will merge tomorrow to
> next-dts if there are no other comments. Thanks Luca.
>
>
>
DPDK shells, this issue was resolved.
Correctness is more important than execution
speed in DTS, so it seems justified to slow down
the execution a little in order to make the
testing framework less fragile to such device
specific bringup behaviors.
Signed-off-by: Patrick Robb
---
dts/framework
I think the changes in V2 make sense and I have tested it and I like the
new way logs and pcaps are stored in dts/output. I will merge tomorrow to
next-dts if there are no other comments. Thanks Luca.
On Thu, Sep 4, 2025 at 11:16 AM Luca Vizzarro wrote:
> On Wed, Sep 03, 2025 at 02:04:12PM +, Andrew Bailey wrote:
> > diff --git a/dts/framework/remote_session/testpmd_shell.py
> b/dts/framework/remote_session/testpmd_shell.py
> > index ad8cb273dc..4d9caceb37 100644
> > --- a/dts/framework/re
On Thu, Sep 4, 2025 at 7:47 AM Luca Vizzarro wrote:
>
> @dataclass
> class TestSuiteSetup(TestSuiteState):
> @@ -474,6 +457,11 @@ class TestSuiteSetup(TestSuiteState):
>
> logger_name: ClassVar[str] = "test_suite_setup"
>
> +def before(self) -> None:
> +"""Hook before the state
On Tue, Sep 2, 2025 at 12:52 PM Luca Vizzarro wrote:
> Hi Andrew,
>
> Thank you for clarifying. It makes more sense now.
>
> On Thu, Aug 28, 2025 at 08:37:58AM +, Andrew Bailey wrote:
> > diff --git a/dts/framework/testbed_model/port.py
> b/dts/framework/testbed_model/port.py
> > index fc58e2
Reviewed-by: Patrick Robb
Applying to next-dts with Luca's suggested fixup.
ity = (
> +TestPmdShell.get_capabilities_tx_offload,
> +None,
> +)
> +TX_OFFLOAD_MBUF_FAST_FREE: TestPmdShellNicCapability = (
> +TestPmdShell.get_capabilities_tx_offload,
> +None,
> +)
> +TX_OFFLOAD_SECURITY: TestPmdShellNicCapability = (
> +TestPmdShell.get_capabilities_tx_offload,
> +None,
> +)
> +TX_OFFLOAD_UDP_TNL_TSO: TestPmdShellNicCapability = (
> +TestPmdShell.get_capabilities_tx_offload,
> +None,
> +)
> +TX_OFFLOAD_IP_TNL_TSO: TestPmdShellNicCapability = (
> +TestPmdShell.get_capabilities_tx_offload,
> +None,
> +)
> +TX_OFFLOAD_OUTER_UDP_CKSUM: TestPmdShellNicCapability = (
> +TestPmdShell.get_capabilities_tx_offload,
> +None,
> +)
> +TX_OFFLOAD_SEND_ON_TIMESTAMP: TestPmdShellNicCapability = (
> +TestPmdShell.get_capabilities_tx_offload,
> +None,
> +)
> #: Scattered packets Rx enabled
> SCATTERED_RX_ENABLED: TestPmdShellNicCapability = (
> TestPmdShell.get_capabilities_rxq_info,
> --
> 2.50.1
>
>
Looks good. Have you verified the docs will build from this patch? If you
haven't done this yet it's
meson setup my_build
ninja -C my_build doc
Reviewed-by: Patrick Robb
Applied to next-dts, thanks.
Thanks Luca for the patch submission best practices advice. :)
Andrew we can chat more about the bound_for_dpdk() at the DTS meeting.
On Thu, Aug 28, 2025 at 8:38 AM Andrew Bailey wrote:
>
> +ctx = get_ctx()
> +prepare_node(ctx.tg_node)
> +prepare_node(ctx.sut_node)
> +
Thanks Dean and Luca.
Applied to next-dts.
This looks good except that I found the commit message to be confusing. For
instance, it is not true that all one link test runs will skip before this
patch - they will in fact run. I do know what you mean of course but I
think we should just be more clear.
I just modified the commit message to th
I forgot to add my tag to the previous email.
Reviewed-by: Patrick Robb
I think this patch looks good. Thanks Thomas and thanks Ivan for your
insights.
Reviewed-by: Patrick Robb
On Wed, Jul 30, 2025 at 8:59 AM Thomas Wilks wrote:
> From: Alex Chapman
>
> This patch adds the required functionality for the RSS key_update,
> RETA, and hash test
On Wed, Jul 30, 2025 at 8:59 AM Thomas Wilks wrote:
>
> +def configure_random_reta(self, testpmd: TestPmdShell, queue_number:
> int) -> list[int]:
> +"""Configure RETA to have random order of queues.
> +
> +Args:
> +testpmd: The testpmd instance that will be used t
#
August 21, 2025
Attendees
1. Patrick Robb
2. Luca Vizzarro
3. Maxime Coquelin
4. Dean Marx
#
Minutes
Adding Dean who I forgot to CC.
On Tue, Aug 19, 2025 at 5:48 PM Patrick Robb wrote:
> Hi Aaron or Maxime,
>
> I want to get your perspective on our testing goals for virtio in DTS if
> you are willing.
>
> Dean, who works on DTS, has been running various PVP and PVVP virtio
Hi Aaron or Maxime,
I want to get your perspective on our testing goals for virtio in DTS if
you are willing.
Dean, who works on DTS, has been running various PVP and PVVP virtio
workloads on one of the SUT servers at UNH, as well as some single VM and
double VM (with inter VM DPDK forwarding) vi
I see Luca just sent a new version of 22.11 which includes the Grace build
patch, so this build "issue" should now be resolved for his tree. I hope we
will see the same patch reach 23.11 soon. :)
Thanks for doing this Doug and Luca.
On Tue, May 20, 2025 at 1:15 PM Patrick Robb wrote:
Sending a CI testing retest for this series because of a suspected false
failure on the vlan testsuite.
On Fri, Aug 8, 2025 at 12:59 PM Stephen Hemminger <
step...@networkplumber.org> wrote:
> This adds new feature port mirroring to the ethdev layer.
> And standalone tests for those features.
>
>
Sending a CI testing retest for the v5 of this series because of a
suspected false failure on the packet capture testsuite.
On Wed, Aug 13, 2025 at 11:03 PM Bingbin Chen
wrote:
> v5:
> - modify some error level printing information,
> and other issues from Maintainer's.
>
> V4:
> - repla
Sending a CI testing retest for this series because of a suspected false
failure on the dynamic config testsuite.
On Wed, Aug 13, 2025 at 11:28 AM Thomas Monjalon
wrote:
> After an upgrade to MinGW version 13, some compilation errors appear
> in PCI, mlx5 and bbdev code.
> This series fixes them
Sending a CI testing retest for this series because of a suspected false
failure on the packet capture testsuite.
On Thu, Aug 14, 2025 at 9:22 AM Dariusz Sosnowski
wrote:
> TIR action was not added as an allowed action in FDB domain.
> This prevented the usage of RSS flow action in transfer flow
#
August 14, 2025
Attendees
* Patrick Robb
* Luca Vizzarro
* Paul Szczepanek
* Andrew Bailey
* Manit Mahajan
* Dean Marx
#
Minutes
Apologies for the delay in sending these notes out.
#
August 7, 2025
Attendees
1. Patrick Robb
2. Luca Vizzarro
3. Dean Marx
4. Aaron Conole
#
Minutes
July 31, 2025
Attendees
* Patrick Robb
* Luca Vizzarro
* Paul Szczepanek
* Andrew Bailey
Minutes
On Tue, Aug 12, 2025 at 4:31 AM Luca Vizzarro wrote:
> On 12/08/2025 02:25, Patrick Robb wrote:
> > On Fri, Jul 25, 2025 at 11:15 AM Luca Vizzarro > <mailto:luca.vizza...@arm.com>> wrote:
> >
> >
> > +
> > +@overload
> > +def mak
Reviewed-by: Patrick Robb
On Fri, Jul 25, 2025 at 11:15 AM Luca Vizzarro
wrote:
> Add a new artifact module which provides DTS with remote and local file
> management capabilities. A new Artifact class is provided which acts as
> an abstract representation of a file that is present in any node in the
> testbed model. The
My initial impression is that with the tree
structure, the high number of log files is basically harmless, and would
provide a quick path to finding the specific logs one wants (when they know
the failing testcase) so I'm not requesting a change... just raising the
point for discussion.
>
> 2.43.0
>
>
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
t; file_mode).replace("t", "") + "b")
>
Is it worth logging this event to prevent confusion? (where we change the
requested mode to binary mode)
+elif "b" not in file_mode:
> +actual_mode = cast(BinaryMode, file_mode + "b")
>
same
>
> --
> 2.43.0
>
>
Reviewed-by: Patrick Robb
Reviewed-by: Patrick Robb
On Fri, Jul 25, 2025 at 11:15 AM Luca Vizzarro
wrote:
> Refactor the logic to identify nodes. Add facility to retrieve current
> nodes from context.
>
> Signed-off-by: Luca Vizzarro
> Reviewed-by: Paul Szczepanek
> ---
>
>
Reviewed-by: Patrick Robb
:
> username: str
> password: str
> history: list[CommandResult]
> +session: Connection
> _logger: DTSLogger
> _node_config: NodeConfiguration
>
> 2.43.0
>
>
Happy to see the two classes reduced into just RemoteSession.
Reviewed-by: Patrick Robb
Hi Gavin, I'm just flagging that this patch has a failure for the
dynamic_config testsuite's test_disable_promisc_multicast testcase.
It's a testpmd testcase which disables allmulticast on the port and then
verifies that a multicast packet sent to the DUT is dropped, then enables
allmulticast and
Looks good to me.
Reviewed-by: Patrick Robb
Reviewed-by: Patrick Robb
Acked-by: Patrick Robb
Thanks. Confirming for the mailing list that we discussed this at the DTS
meeting last week and agreed on this course of action.
Reviewed-by: Patrick Robb
On Fri, Aug 1, 2025 at 7:45 AM Luca Vizzarro wrote:
> The CI currently does not support the optional DTS docs dependencies. As
Hello,
The DTS group has met and agreed on the top level goals for 25.11 DTS
development.
DTS Roadmap:
* DTS API
* Provide a single point of entry into the framework for all test
suites, allowing stable usage across releases and user friendly
discoverability of dts functionality
* Pac
#
July 24, 2025
Attendees
1. Patrick Robb
2. Luca Vizzarro
3. Dean Marx
4. Adam Hassick
5. Paul Szczepanek
#
Minutes
Actually, Luca is going to fixup this commit, pulling the function down to
the node setup method, and push to next-dts.
On Tue, Jul 29, 2025 at 9:20 AM Patrick Robb wrote:
> ... Woops.
>
> Will send the correction later today.
>
> On Tue, Jul 29, 2025 at 5:50 AM Luca Vizzarro
&
... Woops.
Will send the correction later today.
On Tue, Jul 29, 2025 at 5:50 AM Luca Vizzarro wrote:
> Hi Patrick,
>
> thank you for the quick v2! I am afraid you may have placed the call in
> the class constructor instead of the setup method :')
>
> Luca
>
hugepages already via kernel parameters
this is harmless, but if they haven't, this bug will cause the DTS
execution to fail. This patch adds a call to the hugepages
configuration method at node setup.
Fixes: d77a4a27bd24 ("dts: remove node distinction")
Signed-off-by: Patrick Robb
Re
On Mon, Jul 28, 2025 at 7:31 AM Luca Vizzarro wrote:
> Really good catch Patrick! Thank you for this!
>
> Would it make more sense to place setup_hugepages under Node.setup()?
> In that case the method can also remain private, involving a single line
> change.
>
Yes, that makes more sense. I'll
istinction")
Signed-off-by: Patrick Robb
---
dts/framework/test_run.py | 1 +
dts/framework/testbed_model/node.py | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/dts/framework/test_run.py b/dts/framework/test_run.py
index 4355aeeb4b..5f4fc0d2bb 100644
---
Hello,
I will be taking the DPDK Community Lab offline at 5pm EST today for system
updates and backups on the Community Lab's Jenkins server. I expect to be
able to bring the Community Lab back online at midday Saturday. If that
schedule changes, I will provide updates on the Slack infra-issues ch
Acked-by: Patrick Robb
I'm not sure whether my approval is needed or not, but for the record Luca
has been making contributions to DTS for more than a year now and is very
capable of acting as maintainer.
On Tue, Jul 22, 2025 at 12:07 PM Luca Vizzarro
wrote:
> Paul is giving up his ro
On Tue, Jul 15, 2025 at 2:57 AM Paul Szczepanek
wrote:
> Hi all,
>
> Now that we've written a significant number of tests and developed a
> consistent usage pattern, I think it's a good time to take the next step
> toward project maturity: establishing a stable, well-defined API that
> developers
#
July 17, 2025
Attendees
* Patrick Robb
* Manit Mahajan
* Dean Marx
* Luca Vizzarro
* Paul Szczepanek
#
Minutes
On Wed, Jul 16, 2025 at 4:54 PM Dean Marx wrote:
> code.
>
>
> How To Write a Test Suite
> -
>
> -All test suites inherit from ``TestSuite`` defined in
> ``dts/framework/test_suite.py``.
> -There are four types of methods that comprise a test suite:
> +All test suites ar
On Wed, Jul 16, 2025 at 9:57 AM Dean Marx wrote:
>
> +
> +* Document ``__init__()`` separately from the class docstring.
> +* If an abstract method simply implements a superclass definition without
> changes, refer to that superclass in the docstring.
> +* Document instance variables in the class
> Reviewed-by: Patrick Robb
> ---
> doc/guides/tools/dts.rst | 194 ++-
> 1 file changed, 90 insertions(+), 104 deletions(-)
>
> diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst
> index 8ba855c6fc..4da55e00ef 100644
>
On Mon, Jul 14, 2025 at 1:13 PM Dean Marx wrote:
>
> +
> +# Simple Linux Setup
> +
> +1. On your TG and SUT nodes, add a dedicated user. In this example I will
> add a dedicated user for DTS.
>
This is getting away from what I was suggesting. The original version was:
On your TG and SUT nodes,
On Tue, Jul 15, 2025 at 3:47 AM Bruce Richardson
wrote:
>
>
> Thanks. Let me know how the testing otherwise goes. If only Intel NICs are
> supporting QinQ, then it can't be that widely used a feature yet, so we may
> be able to tweak things a bit if it diverges from what is expected.
>
Yeah, the
+c...@dpdk.org
+Manit Mahajan
+Andrew Bailey
Thank you for this we will modify our Clang and MSVC build pipelines at UNH.
Acked-by: Patrick Robb
On Tue, Jul 15, 2025 at 10:14 AM Andre Muezerie <
andre...@linux.microsoft.com> wrote:
> The linker parameters to use with MSVC and Cla
On Mon, Jul 14, 2025 at 4:09 PM Dean Marx wrote:
> On Mon, Jul 14, 2025 at 9:30 AM Bruce Richardson
> wrote:
> >
> > The behaviour of VLAN tag stripping Rx offloads is unclear in DPDK, and
> > not very well documented. Even the documentation that does exist appears
> > contradictory.
> >
> > For
.
> + Example: self.verify(link_up, "Link should be up after configuration.")
>
> -#. **Other methods**
> +Other Methods
>
> - Of course, all test suite code should adhere to coding standards.
> - Only the above methods will be treated specially and any other methods
> may be defined
> - (which should be mostly private methods needed by each particular test
> suite).
> - Any specific features (such as NIC configuration) required by a test
> suite
> - should be implemented in the ``SutNode`` class (and the underlying
> classes that ``SutNode`` uses)
> - and used by the test suite via the ``sut_node`` field.
> + All test suite code should follow the project's coding standards.
> + Only test cases, setup/teardown hooks, and verification methods are
> treated specially by the framework.
> + Additional methods may be defined as needed (ideally private).
> + Any specific features (such as NIC configuration) should be
> implemented in the SutNode class or its supporting classes, and accessed
> using the sut_node field.
>
There's no such class as SutNode anymore.
>
>
> .. _dts_dev_tools:
> --
> 2.49.0
>
>
Also, this series should adjust the poetry section to explain that "poetry
shell" is deprecated now and one must use "poetry run" instead.
Reviewed-by: Patrick Robb
are or software-based.
Not to be a grammar nitpicker but I believe semicolons separate independent
clauses. Maybe just change to:
Node that sends traffic to the SUT, which can be hardware or software-based.
>
>
> 2.49.0
>
>
Reviewed-by: Patrick Robb
On Fri, Jul 11, 2025 at 1:25 PM Dean Marx wrote:
> Remove unnecessary information from README.md,
>
I would call the dropped information "extraneous".
> and add new sections to clarify the purpose/use
> of DTS along with clear setup instructions.
>
Maybe say that the goal of the commit is ref
#
July 9, 2025
Attendees
1. Patrick Robb
2. Manit Mahajan
3. Dean Marx
4. Luca Vizzarro
5. Shai Brandes
6. Aaron Conole
#
Minutes
On Wed, Jul 9, 2025 at 3:57 PM Thomas Monjalon wrote:
> 25/06/2025 06:07, Patrick Robb:
> > Applied to next-dts, thanks Dean.
>
> I'm almost sure it has overriden some doc added recently by Nicholas
> Pratte.
>
Good catch. It removed some sentences explaining usage o
On Tue, Jul 8, 2025 at 6:56 PM Patrick Robb wrote:
> #
> July 3, 2025
> Attendees
> * Patrick Robb
> * Manit Mahajan
> * Dean Marx
>
> ###
#
July 3, 2025
Attendees
* Patrick Robb
* Manit Mahajan
* Dean Marx
#
Minutes
=
General
#
June 25, 2025
Attendees
1. Patrick Robb
2. Manit Mahajan
3. Dean Marx
#
Minutes
=
General
FYI based on conversation with Dean I pushed a fixup adding
the use_virtual_functions: false field to the test_run.example.yaml, so
that users can more easily understand how to enable the VF testruns.
https://git.dpdk.org/next/dpdk-next-dts/commit/?id=934206f3bfc10fb8dcd852479f3683c01a18e352
Series applied to next-dts, thanks.
On Fri, Jul 4, 2025 at 12:25 AM Patrick Robb wrote:
> And FYI VF results for ConnectX-5 virtual functions for a testrun I just
> ran
>
> test_suites: ERROR
> vlan: PASS
> test_vlan_header_insertion: PASS
> test_
Applied to next-dts, thanks.
On Fri, Jul 4, 2025 at 11:30 AM Luca Vizzarro wrote:
> Usage of example DPDK apps should be avoided. Therefore, remove
> the function that allows to build example apps. Moreover,
> provide a dedicated helper function to retrieve the path to a
> DPDK app.
>
> Signed-o
Applied to next-dts, thanks.
On Fri, Jul 4, 2025 at 11:30 AM Luca Vizzarro wrote:
> Add a generic blocking app class to allow a test writer to run any app
> in the background. Make the original BlockingDPDKApp class inherit from
> this one. Implement the new BlockingApp class in the packet_captu
And FYI VF results for ConnectX-5 virtual functions for a testrun I just ran
test_suites: ERROR
vlan: PASS
test_vlan_header_insertion: PASS
test_vlan_no_receipt: PASS
test_vlan_receipt_no_stripping: PASS
test_vlan_receipt_stripping: PASS
rte_flow: FAIL
test_drop_action_ETH:
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
oftnic(TestSuite):
> """Softnic test suite."""
> diff --git a/dts/tests/TestSuite_uni_pkt.py
> b/dts/tests/TestSuite_uni_pkt.py
> index fdb9c29059..690c5d4fd1 100644
> --- a/dts/tests/TestSuite_uni_pkt.py
> +++ b/dts/tests/TestSuite_uni_pkt.py
> @@ -20,6 +20,7 @@
> from scapy.packet import Packet, Raw
>
> from framework.remote_session.testpmd_shell import (
> +NicCapability,
> RtePTypes,
> SimpleForwardingModes,
> TestPmdShell,
> @@ -258,6 +259,7 @@ def test_nsh_packet_detect(self) -> None:
> with TestPmdShell() as testpmd:
> self.setup_session(testpmd=testpmd, expected_flags=flag_list,
> packet_list=packet_list)
>
> +@requires(NicCapability.PHYSICAL_FUNCTION)
> @func_test
> def test_vxlan_tunnel_packet_detect(self) -> None:
> """Ensure the correct flags are shown in the verbose output when
> sending VXLAN packets.
> --
> 2.49.0
>
>
In principle some of the functions performed in these testsuites should be
possible via VFs.
As a follow up task in 25.11 we should assess this and see if the total
list of VF compatible testsuites can be extended.
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
you can raise this item at the next DTS meeting for
discussion? It could make sense to support this check for PFs for 25.11.
Anyhow we can discuss.
> def stop(self, verify: bool = True) -> str:
> """Stop packet forwarding.
>
> --
> 2.49.0
>
>
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
On Wed, Jul 2, 2025 at 12:23 PM Dean Marx wrote:
> Add virtual functions to DTS framework, along with
> a field for specifying VF test runs in the config file.
>
> Signed-off-by: Patrick Robb
> Signed-off-by: Dean Marx
> ---
> dts/framework/config/test_run.py
LGTM, thanks.
As it relates to the TREX patch, yes I will try to refactor towards using
this to handle the TREX foreground server process. I guess the one change I
would need to make is changing the default InteractiveShell timeout from 5
seconds to a larger number (like 20) since TREX can take a
uot;""Retrieve path for a DPDK app."""
> +return self._session.join_remote_path(self.remote_dpdk_build_dir,
> "app", f"dpdk-{app_name}")
> +
> @cached_property
> def remote_dpdk_tree_path(self) -> PurePath:
> """The remote DPDK tree path."""
> --
> 2.43.0
>
>
Otherwise this looks fine for dumpcap and the others /app apps - thanks.
Reviewed-by: Patrick Robb
lass ResultLeaf(BaseModel):
> +"""Class representing a result in the results tree.
>
> -class DtsRunResultDict(TypedDict):
> -"""Represents the `DtsRunResult` results.
> +A leaf node that can contain the results for a
> :class:`~.test_suite.TestSuite`,
> +:class:`.test_suite.TestCase` or a DTS execution step.
>
> Attributes:
> -test_runs: A list of test run results.
> -summary: A summary dictionary containing overall statistics for
> the test runs.
> +result: The actual result.
> +reason: The reason of the result.
> """
>
>From running some testcases that resulted in Error or Fail, I agree adding
this is a big benefit. Providing an example for any others on the mailing
list who are curious:
rte_flow: FAIL
test_drop_action_ETH: PASS
test_drop_action_IP: PASS
test_drop_action_L4: PASS
test_drop_action_VLAN: PASS
test_egress_rules: SKIP
reason: flow rule failed validation.
test_jump_action: PASS
test_modify_actions: FAIL
reason: Packet was never received.
test_priority_attribute: PASS
test_queue_action_ETH: PASS
test_queue_action_IP: PASS
test_queue_action_L4: PASS
test_queue_action_VLAN: PASS
>
>
> --
> 2.43.0
>
>
Looks good, I will apply to next-dts now.
Reviewed-by: Patrick Robb
Tested-by Patrick Robb
Reviewed-by: Patrick Robb
On Fri, Jun 27, 2025 at 11:12 AM Thomas Wilks wrote:
> From: Luca Vizzarro
>
> The test suite name property was previously returning the class name
> instead of the way that test suite are actually named, e.g.
> TestHelloWorld instead of hello_world.
1 - 100 of 590 matches
Mail list logo
