[dpdk-dev] [PATCH 1/3] pcap: utilize underlying real interface properties

2015-04-29 Thread Nicolás Pernas Maradei
Hi Tero, Just a few comments on one of your patches - see inline comments below. Interesting features btw. Nico. --? Nicol?s Pernas Maradei On 27 February 2015 at 13:43:14, dev-request at dpdk.org (dev-request at dpdk.org) wrote: Message: 5? Date: Fri, 27 Feb 2015 15:42:38 +0200? From: Tero

[dpdk-dev] [PATCH] maintainers: claim pcap pmd library

2015-03-18 Thread Nicolás Pernas Maradei
Signed-off-by: Nicol?s Pernas Maradei --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index bef7f59..4c780db 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -247,6 +247,7 @@ F: lib/librte_pmd_vmxnet3/ F: doc/guides/prog_guide/poll_mode_drv_paravirtual_

[dpdk-dev] [PATCH] eal: allow virtual devices to be white/black listed

2014-11-16 Thread Nicolás Pernas Maradei
From: Nicol?s Pernas Maradei Virtual and physical devices are now treated the same in terms of white/black listing. Virtual devices can be defined using --vdev as before and also whitelisted (using -w vdev_name) or blacklisted (using -b vdev_name). This allows the user to have only a virtual devi

[dpdk-dev] [PATCH v2] Fix librte_pmd_pcap driver double stop error

2014-10-05 Thread Nicolás Pernas Maradei
Hi, New in Patch v2: - Fixes an issue in eth_dev_start/stop where a single interface was always opened/closed even though pcap files had been selected for rx/tx streams. - The link_status was not being properly updated in case of using a single interface for rx/tx streams. Nico. On 2014-10-0

[dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error

2014-10-04 Thread Nicolás Pernas Maradei
Hi, You are correct, the parameters received in the driver are allocated in devargs_list (char *params variable). However, they already get strdup'd in rte_kvargs_parse(). This newly allocated string is part of kvlist and never freed up. The params variable is never used again so it can be fre

[dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error

2014-09-10 Thread Nicolás Pernas Maradei
From: Nicola?s Pernas Maradei librte_pmd_pcap driver was opening the pcap/interfaces only at init time and closing them only when the port was being stopped. This behaviour would cause problems (leading to segfault) if the user closed the port 2 times. The first time the pcap/interfaces would be